From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: LMML <linux-media@vger.kernel.org>, Daro <ghost-rider@aster.pl>,
Roman Kellner <muzungu@gmx.net>
Subject: Re: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants
Date: Fri, 29 Jan 2010 13:40:41 -0200 [thread overview]
Message-ID: <4B630179.3080006@redhat.com> (raw)
In-Reply-To: <20100127120211.2d022375@hyperion.delvare>
Jean Delvare wrote:
> From: Jean Delvare <khali@linux-fr.org>
> Subject: saa7134: Fix IR support of some ASUS TV-FM 7135 variants
>
> Some variants of the ASUS TV-FM 7135 are handled as the ASUSTeK P7131
> Analog (card=146). However, by the time we find out, some
> card-specific initialization is missed. In particular, the fact that
> the IR is GPIO-based. Set it when we change the card type.
>
> We also have to move the initialization of IR until after the card
> number has been changed. I hope that this won't cause any problem.
Hi Jean,
Moving the initialization will likely cause regressions. The reason why there
are two init codes there were due to the way the old i2c code used to work.
This got fixed after the i2c rework, but it caused regressions on that time.
The proper way would be to just muve the IR initialization on this board
from init1 to init2, instead of changing it for all other devices.
cheers,
Mauro
next prev parent reply other threads:[~2010-01-29 15:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 11:02 [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants Jean Delvare
2010-01-29 15:40 ` Mauro Carvalho Chehab [this message]
2010-01-30 0:47 ` hermann pitton
2010-01-30 10:56 ` Jean Delvare
2010-02-01 1:16 ` hermann pitton
2010-02-01 9:56 ` Jean Delvare
2010-02-02 1:47 ` hermann pitton
2010-02-02 7:54 ` Jean Delvare
2010-02-02 11:50 ` Mauro Carvalho Chehab
2010-02-10 18:09 ` Jean Delvare
2010-02-10 18:40 ` Mauro Carvalho Chehab
2010-02-10 19:36 ` Jean Delvare
2010-02-11 0:58 ` hermann pitton
2010-02-15 5:31 ` hermann pitton
2010-02-20 3:07 ` hermann pitton
2010-02-25 13:12 ` Jean Delvare
2010-02-25 21:50 ` hermann pitton
2010-02-02 23:32 ` hermann pitton
2010-02-10 16:38 ` Daro
2010-02-10 17:00 ` Jean Delvare
2010-02-02 19:09 ` Mauro Carvalho Chehab
2010-02-10 17:01 ` Jean Delvare
[not found] <E1Nl2po-000877-Di@services.gcu-squad.org>
2010-03-12 9:38 ` Jean Delvare
2010-03-14 2:38 ` Daro
2010-03-14 5:08 ` hermann pitton
2010-03-14 8:26 ` Jean Delvare
2010-03-14 19:34 ` Daro
2010-03-14 20:48 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B630179.3080006@redhat.com \
--to=mchehab@redhat.com \
--cc=ghost-rider@aster.pl \
--cc=khali@linux-fr.org \
--cc=linux-media@vger.kernel.org \
--cc=muzungu@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox