public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hdpvr-core: make module parameters local
@ 2010-01-29 20:30 Németh Márton
  0 siblings, 0 replies; only message in thread
From: Németh Márton @ 2010-01-29 20:30 UTC (permalink / raw)
  To: Janne Grunau; +Cc: V4L Mailing List

From: Márton Németh <nm127@freemail.hu>

The default_video_input and default_audio_input module parameters are
only used inside the hdpvr-core.c file so make them static.

This will remove the following sparse warnings (see "make C=1"):
 * warning: symbol 'default_video_input' was not declared. Should it be static?
 * warning: symbol 'default_audio_input' was not declared. Should it be static?

Signed-off-by: Márton Németh <nm127@freemail.hu>
---
diff -r 8b9a62386b64 linux/drivers/media/video/hdpvr/hdpvr-core.c
--- a/linux/drivers/media/video/hdpvr/hdpvr-core.c	Fri Jan 29 01:23:57 2010 -0200
+++ b/linux/drivers/media/video/hdpvr/hdpvr-core.c	Fri Jan 29 21:25:45 2010 +0100
@@ -39,12 +39,12 @@
 module_param(hdpvr_debug, int, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(hdpvr_debug, "enable debugging output");

-uint default_video_input = HDPVR_VIDEO_INPUTS;
+static uint default_video_input = HDPVR_VIDEO_INPUTS;
 module_param(default_video_input, uint, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(default_video_input, "default video input: 0=Component / "
 		 "1=S-Video / 2=Composite");

-uint default_audio_input = HDPVR_AUDIO_INPUTS;
+static uint default_audio_input = HDPVR_AUDIO_INPUTS;
 module_param(default_audio_input, uint, S_IRUGO|S_IWUSR);
 MODULE_PARM_DESC(default_audio_input, "default audio input: 0=RCA back / "
 		 "1=RCA front / 2=S/PDIF");



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-01-29 20:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-29 20:30 [PATCH] hdpvr-core: make module parameters local Németh Márton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox