From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11861 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756527Ab0BBQoY (ORCPT ); Tue, 2 Feb 2010 11:44:24 -0500 Message-ID: <4B685660.3040105@redhat.com> Date: Tue, 02 Feb 2010 14:44:16 -0200 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: Stefan Ringel CC: Devin Heitmueller , linux-media@vger.kernel.org Subject: Re: [PATCH] - tm6000 DVB support References: <4B673790.3030706@arcor.de> <4B673B2D.6040507@arcor.de> <829197381002011252w93b0f17g4c4f6d35ffae45f3@mail.gmail.com> <4B67464B.3020801@arcor.de> <829197381002011344g1c640c4fufa057071b8527d55@mail.gmail.com> <4B674EF9.3020800@arcor.de> <4B675E52.5040306@redhat.com> <4B684F6A.6010902@arcor.de> In-Reply-To: <4B684F6A.6010902@arcor.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Stefan Ringel wrote: >> So, it will basically preserve bits 8,7,6,4 and 1 of register 8, >> and will clear bit 4 (EM_GPIO_4 is 1 << 4 - e. g. bit 4). >> After that, it will sleep for 10 miliseconds, and will then do a >> reset on bit 3 of Register 4 (writing 0, then 1 to the bit). >> > > reset example : > > static struct tm6010_seq terratec[] = { > {TM6010_GPIO_2, 1, 60}, /* GPIO 2 going to high */ > {TM6010_GPIO_2, 0, 75}, /* GPIO 2 going to lo */ > {TM6010_GPIO_2, 1, 60}, /* GPIO 2 going to high */ > { -1 , -1, -1}, > } > > Is that correct? Yes. In the case of tm6010, it has separate registers for each GPIO, so, you don't need a bitmask. >> the hack.c needs to be validated against the zl10353, in order to identify >> what are the exact needs for tm6000. Some devices require serial mode, while >> others require parallel mode. >> >> I bet that playing with zl10353_config, we'll find the proper init values >> required by tm6000. >> >> > > I have separately write in the hack.c the value from terratec hybrid > stick. The older value I haven't clean. Ok, but maybe you missed my point: at the long term, we should get rid of hack.c, and be sure that all needed initializations are done by zl10353 driver or by tm6010-dvb. -- Cheers, Mauro