Re: [PATCH] - tm6000 DVB support

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Stefan Ringel wrote:
> Am 02.02.2010 21:03, schrieb Mauro Carvalho Chehab:
>>>> Those tuner callback initializations are board-specific. So, it is better to test
>>>> for your board model, if you need something different than what's currently done.
>>>>
>>>>   
>>>>       
>>> This tuner reset works with my stick, but I think that can test with
>>> other tm6000 based sticks and if it not works then I can say this as a
>>> board-specific.
>>>     
>> It won't work on my boards. The GPIO pin used by each board is different.
>>
>>   
> Have you the right gpio pin in the card struct. I have the
> ".gpio_addr_tun_reset" the correct gpio pin
> 
>    [TM6010_BOARD_TERRATEC_CINERGY_HYBRID_XE] = {
> +        .name         = "Terratec Cinergy Hybrid XE",
> +        .tuner_type   = TUNER_XC2028, /* has a XC3028 */
> +        .tuner_addr   = 0xc2 >> 1,
> +        .demod_addr   = 0x1e >> 1,
> +        .type         = TM6010,
> +        .caps = {
> +            .has_tuner    = 1,
> +            .has_dvb      = 1,
> +            .has_zl10353  = 1,
> +            .has_eeprom   = 1,
> +            .has_remote   = 1,
> +        },
> +        .gpio_addr_tun_reset = TM6010_GPIO_2, /* here */
> +    }
>  };
>  

Ok, this works :) All needed pins should be customized there, either individually
or via an struct similar to the one done at em28xx driver. Both ways have advantages
and disadvantages.


-- 

Cheers,
Mauro