public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 2/7] drivers/media/video/pms.c needs version.h
@ 2010-02-02 22:40 akpm
  2010-02-03  8:22 ` Mauro Carvalho Chehab
  0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2010-02-02 22:40 UTC (permalink / raw)
  To: mchehab; +Cc: linux-media, akpm, hverkuil

From: Andrew Morton <akpm@linux-foundation.org>

i386 allmodconfig:

drivers/media/video/pms.c: In function 'pms_querycap':
drivers/media/video/pms.c:682: error: implicit declaration of function 'KERNEL_VERSION'

Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/media/video/pms.c |    1 +
 1 file changed, 1 insertion(+)

diff -puN drivers/media/video/pms.c~drivers-media-video-pmsc-needs-versionh drivers/media/video/pms.c
--- a/drivers/media/video/pms.c~drivers-media-video-pmsc-needs-versionh
+++ a/drivers/media/video/pms.c
@@ -24,6 +24,7 @@
 #include <linux/delay.h>
 #include <linux/errno.h>
 #include <linux/fs.h>
+#include <linux/version.h>
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/mm.h>
_

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 2/7] drivers/media/video/pms.c needs version.h
  2010-02-02 22:40 [patch 2/7] drivers/media/video/pms.c needs version.h akpm
@ 2010-02-03  8:22 ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2010-02-03  8:22 UTC (permalink / raw)
  To: akpm; +Cc: linux-media, hverkuil

akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> i386 allmodconfig:
> 
> drivers/media/video/pms.c: In function 'pms_querycap':
> drivers/media/video/pms.c:682: error: implicit declaration of function 'KERNEL_VERSION'

> @@ -24,6 +24,7 @@
>  #include <linux/delay.h>
>  #include <linux/errno.h>
>  #include <linux/fs.h>
> +#include <linux/version.h>
>  #include <linux/kernel.h>
>  #include <linux/slab.h>
>  #include <linux/mm.h>

Hmm... changeset feba2f81 already added linux/version.h:
@@ -27,20 +29,21 @@
 #include <linux/mm.h>
 #include <linux/ioport.h>
 #include <linux/init.h>
+#include <linux/version.h>
+#include <linux/mutex.h>
+#include <asm/uaccess.h>
 #include <asm/io.h>
...

So I think this patch got obsoleted.

Cheers,
Mauro

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-03  8:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-02 22:40 [patch 2/7] drivers/media/video/pms.c needs version.h akpm
2010-02-03  8:22 ` Mauro Carvalho Chehab

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox