* [PATCH v2 2/2] radio: Add radio-timb to the Kconfig and Makefile
@ 2010-01-27 16:22 Richard Röjfors
2010-01-27 16:38 ` Randy Dunlap
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Richard Röjfors @ 2010-01-27 16:22 UTC (permalink / raw)
To: Linux Media Mailing List
Cc: Mauro Carvalho Chehab, Douglas Schilling Landgraf, Hans Verkuil,
Andrew Morton
This patch adds radio-timb to the Makefile and Kconfig.
Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
---
diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
index 3f40f37..46fd8c4 100644
--- a/drivers/media/radio/Kconfig
+++ b/drivers/media/radio/Kconfig
@@ -429,4 +429,14 @@ config RADIO_TEF6862
To compile this driver as a module, choose M here: the
module will be called TEF6862.
+config RADIO_TIMBERDALE
+ tristate "Enable the Timberdale radio driver"
+ depends on MFD_TIMBERDALE && VIDEO_V4L2 && HAS_IOMEM
+ select RADIO_TEF6862
+ select RADIO_SAA7706H
+ ---help---
+ This is a kind of umbrella driver for the Radio Tuner and DSP
+ found behind the Timberdale FPGA on the Russellville board.
+ Enable this driver will automatically select the DSP and tuner.
+
endif # RADIO_ADAPTERS
diff --git a/drivers/media/radio/Makefile b/drivers/media/radio/Makefile
index 01922ad..8973850 100644
--- a/drivers/media/radio/Makefile
+++ b/drivers/media/radio/Makefile
@@ -24,5 +24,6 @@ obj-$(CONFIG_RADIO_SI470X) += si470x/
obj-$(CONFIG_USB_MR800) += radio-mr800.o
obj-$(CONFIG_RADIO_TEA5764) += radio-tea5764.o
obj-$(CONFIG_RADIO_TEF6862) += tef6862.o
+obj-$(CONFIG_RADIO_TIMBERDALE) += radio-timb.o
EXTRA_CFLAGS += -Isound
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] radio: Add radio-timb to the Kconfig and Makefile
2010-01-27 16:22 [PATCH v2 2/2] radio: Add radio-timb to the Kconfig and Makefile Richard Röjfors
@ 2010-01-27 16:38 ` Randy Dunlap
2010-01-27 16:42 ` Hans Verkuil
2010-02-03 9:59 ` Mauro Carvalho Chehab
2 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2010-01-27 16:38 UTC (permalink / raw)
To: Richard Röjfors
Cc: Linux Media Mailing List, Mauro Carvalho Chehab,
Douglas Schilling Landgraf, Hans Verkuil, Andrew Morton
On Wed, 27 Jan 2010 17:22:10 +0100 Richard Röjfors wrote:
> This patch adds radio-timb to the Makefile and Kconfig.
>
> Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
> ---
> diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
> index 3f40f37..46fd8c4 100644
> --- a/drivers/media/radio/Kconfig
> +++ b/drivers/media/radio/Kconfig
> @@ -429,4 +429,14 @@ config RADIO_TEF6862
> To compile this driver as a module, choose M here: the
> module will be called TEF6862.
>
> +config RADIO_TIMBERDALE
> + tristate "Enable the Timberdale radio driver"
> + depends on MFD_TIMBERDALE && VIDEO_V4L2 && HAS_IOMEM
> + select RADIO_TEF6862
> + select RADIO_SAA7706H
> + ---help---
> + This is a kind of umbrella driver for the Radio Tuner and DSP
> + found behind the Timberdale FPGA on the Russellville board.
> + Enable this driver will automatically select the DSP and tuner.
Enabling
> +
> endif # RADIO_ADAPTERS
> diff --git a/drivers/media/radio/Makefile b/drivers/media/radio/Makefile
> index 01922ad..8973850 100644
> --- a/drivers/media/radio/Makefile
> +++ b/drivers/media/radio/Makefile
> @@ -24,5 +24,6 @@ obj-$(CONFIG_RADIO_SI470X) += si470x/
> obj-$(CONFIG_USB_MR800) += radio-mr800.o
> obj-$(CONFIG_RADIO_TEA5764) += radio-tea5764.o
> obj-$(CONFIG_RADIO_TEF6862) += tef6862.o
> +obj-$(CONFIG_RADIO_TIMBERDALE) += radio-timb.o
>
> EXTRA_CFLAGS += -Isound
>
> --
---
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] radio: Add radio-timb to the Kconfig and Makefile
2010-01-27 16:22 [PATCH v2 2/2] radio: Add radio-timb to the Kconfig and Makefile Richard Röjfors
2010-01-27 16:38 ` Randy Dunlap
@ 2010-01-27 16:42 ` Hans Verkuil
2010-02-03 9:58 ` Mauro Carvalho Chehab
2010-02-03 9:59 ` Mauro Carvalho Chehab
2 siblings, 1 reply; 6+ messages in thread
From: Hans Verkuil @ 2010-01-27 16:42 UTC (permalink / raw)
To: Richard Röjfors
Cc: Linux Media Mailing List, Mauro Carvalho Chehab,
Douglas Schilling Landgraf, Andrew Morton
On Wednesday 27 January 2010 17:22:10 Richard Röjfors wrote:
> This patch adds radio-timb to the Makefile and Kconfig.
>
> Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
> ---
> diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
> index 3f40f37..46fd8c4 100644
> --- a/drivers/media/radio/Kconfig
> +++ b/drivers/media/radio/Kconfig
> @@ -429,4 +429,14 @@ config RADIO_TEF6862
> To compile this driver as a module, choose M here: the
> module will be called TEF6862.
>
> +config RADIO_TIMBERDALE
> + tristate "Enable the Timberdale radio driver"
> + depends on MFD_TIMBERDALE && VIDEO_V4L2 && HAS_IOMEM
I think you need a dependency on I2C as well.
Regards,
Hans
> + select RADIO_TEF6862
> + select RADIO_SAA7706H
> + ---help---
> + This is a kind of umbrella driver for the Radio Tuner and DSP
> + found behind the Timberdale FPGA on the Russellville board.
> + Enable this driver will automatically select the DSP and tuner.
> +
> endif # RADIO_ADAPTERS
> diff --git a/drivers/media/radio/Makefile b/drivers/media/radio/Makefile
> index 01922ad..8973850 100644
> --- a/drivers/media/radio/Makefile
> +++ b/drivers/media/radio/Makefile
> @@ -24,5 +24,6 @@ obj-$(CONFIG_RADIO_SI470X) += si470x/
> obj-$(CONFIG_USB_MR800) += radio-mr800.o
> obj-$(CONFIG_RADIO_TEA5764) += radio-tea5764.o
> obj-$(CONFIG_RADIO_TEF6862) += tef6862.o
> +obj-$(CONFIG_RADIO_TIMBERDALE) += radio-timb.o
>
> EXTRA_CFLAGS += -Isound
>
>
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] radio: Add radio-timb to the Kconfig and Makefile
2010-01-27 16:42 ` Hans Verkuil
@ 2010-02-03 9:58 ` Mauro Carvalho Chehab
2010-02-12 11:35 ` Hans Verkuil
0 siblings, 1 reply; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2010-02-03 9:58 UTC (permalink / raw)
To: Hans Verkuil
Cc: Richard Röjfors, Linux Media Mailing List,
Douglas Schilling Landgraf, Andrew Morton
Hans Verkuil wrote:
> On Wednesday 27 January 2010 17:22:10 Richard Röjfors wrote:
>> This patch adds radio-timb to the Makefile and Kconfig.
>> +config RADIO_TIMBERDALE
>> + tristate "Enable the Timberdale radio driver"
>> + depends on MFD_TIMBERDALE && VIDEO_V4L2 && HAS_IOMEM
>
> I think you need a dependency on I2C as well.
It is not needed. VIDEO_V4L2 already takes care of properly handling it.
--
Cheers,
Mauro
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] radio: Add radio-timb to the Kconfig and Makefile
2010-01-27 16:22 [PATCH v2 2/2] radio: Add radio-timb to the Kconfig and Makefile Richard Röjfors
2010-01-27 16:38 ` Randy Dunlap
2010-01-27 16:42 ` Hans Verkuil
@ 2010-02-03 9:59 ` Mauro Carvalho Chehab
2 siblings, 0 replies; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2010-02-03 9:59 UTC (permalink / raw)
To: Richard Röjfors
Cc: Linux Media Mailing List, Douglas Schilling Landgraf,
Hans Verkuil, Andrew Morton
Richard Röjfors wrote:
> This patch adds radio-timb to the Makefile and Kconfig.
On your next submission, please fold with patch 1/2.
>
> Signed-off-by: Richard Röjfors <richard.rojfors@pelagicore.com>
> ---
> diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
> index 3f40f37..46fd8c4 100644
> --- a/drivers/media/radio/Kconfig
> +++ b/drivers/media/radio/Kconfig
> @@ -429,4 +429,14 @@ config RADIO_TEF6862
> To compile this driver as a module, choose M here: the
> module will be called TEF6862.
>
> +config RADIO_TIMBERDALE
> + tristate "Enable the Timberdale radio driver"
> + depends on MFD_TIMBERDALE && VIDEO_V4L2 && HAS_IOMEM
> + select RADIO_TEF6862
> + select RADIO_SAA7706H
> + ---help---
> + This is a kind of umbrella driver for the Radio Tuner and DSP
> + found behind the Timberdale FPGA on the Russellville board.
> + Enable this driver will automatically select the DSP and tuner.
> +
> endif # RADIO_ADAPTERS
> diff --git a/drivers/media/radio/Makefile b/drivers/media/radio/Makefile
> index 01922ad..8973850 100644
> --- a/drivers/media/radio/Makefile
> +++ b/drivers/media/radio/Makefile
> @@ -24,5 +24,6 @@ obj-$(CONFIG_RADIO_SI470X) += si470x/
> obj-$(CONFIG_USB_MR800) += radio-mr800.o
> obj-$(CONFIG_RADIO_TEA5764) += radio-tea5764.o
> obj-$(CONFIG_RADIO_TEF6862) += tef6862.o
> +obj-$(CONFIG_RADIO_TIMBERDALE) += radio-timb.o
>
> EXTRA_CFLAGS += -Isound
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Cheers,
Mauro
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] radio: Add radio-timb to the Kconfig and Makefile
2010-02-03 9:58 ` Mauro Carvalho Chehab
@ 2010-02-12 11:35 ` Hans Verkuil
0 siblings, 0 replies; 6+ messages in thread
From: Hans Verkuil @ 2010-02-12 11:35 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Richard Röjfors, Linux Media Mailing List,
Douglas Schilling Landgraf, Andrew Morton
On Wednesday 03 February 2010 10:58:14 Mauro Carvalho Chehab wrote:
> Hans Verkuil wrote:
> > On Wednesday 27 January 2010 17:22:10 Richard Röjfors wrote:
> >> This patch adds radio-timb to the Makefile and Kconfig.
>
> >> +config RADIO_TIMBERDALE
> >> + tristate "Enable the Timberdale radio driver"
> >> + depends on MFD_TIMBERDALE && VIDEO_V4L2 && HAS_IOMEM
> >
> > I think you need a dependency on I2C as well.
>
>
> It is not needed. VIDEO_V4L2 already takes care of properly handling it.
Where does that happen? I don't see how VIDEO_V4L2 can know when a driver
requires I2C. It's not a universal requirement, after all.
Regards,
Hans
>
>
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-02-12 11:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-27 16:22 [PATCH v2 2/2] radio: Add radio-timb to the Kconfig and Makefile Richard Röjfors
2010-01-27 16:38 ` Randy Dunlap
2010-01-27 16:42 ` Hans Verkuil
2010-02-03 9:58 ` Mauro Carvalho Chehab
2010-02-12 11:35 ` Hans Verkuil
2010-02-03 9:59 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox