public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Stefan Ringel <stefan.ringel@arcor.de>
Cc: linux-media@vger.kernel.org,
	Devin Heitmueller <dheitmueller@kernellabs.com>
Subject: Re: [PATCH 9/15] -  tm6000 analog digital switch
Date: Wed, 03 Feb 2010 18:40:00 -0200	[thread overview]
Message-ID: <4B69DF20.50205@redhat.com> (raw)
In-Reply-To: <4B69DBCC.50108@arcor.de>

Stefan Ringel wrote:

> @@ -994,6 +995,13 @@ static int generic_set_freq(struct dvb_frontend
> *fe, u32 freq /* in HZ */,

Your emailer is damaging the patches. The above should be in the same line,
otherwise the patch won't apply.

It seems that you're using Thunderbird, right?

User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.1.1 Thunderbird/3.0

You should really read the README.patches (http://linuxtv.org/hg/v4l-dvb/raw-file/tip/README.patches)
before submitting your work. In particular, at the end of Part II, there are the procedures for
submissions via email. It ends with:

" BE CAREFUL: several emailers including Thunderdird breaks long lines, causing
  patch corruption.
  In the specific case of Thunderbird, an extension is needed to send the
  patches, called Asalted Patches:
	https://hg.mozilla.org/users/clarkbw_gnome.org/asalted-patches/"

So, please get the asalted-patches extension, apply it on your Thunderbird, review your patch
series based on the contents of README.patches and re-submit.

-- 

Cheers,
Mauro

  reply	other threads:[~2010-02-03 20:40 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-01 20:20 [PATCH] - tm6000 DVB support Stefan Ringel
2010-02-01 20:35 ` Stefan Ringel
2010-02-01 20:52   ` Devin Heitmueller
2010-02-01 21:23     ` Stefan Ringel
2010-02-01 21:44       ` Devin Heitmueller
2010-02-01 22:00         ` Stefan Ringel
2010-02-01 23:05           ` Mauro Carvalho Chehab
2010-02-02 16:14             ` Stefan Ringel
2010-02-02 16:44               ` Mauro Carvalho Chehab
2010-02-02 17:38                 ` Stefan Ringel
2010-02-02 20:05                   ` Mauro Carvalho Chehab
2010-02-01 22:52   ` Mauro Carvalho Chehab
2010-02-02 17:24     ` Stefan Ringel
2010-02-02 20:03       ` Mauro Carvalho Chehab
2010-02-02 20:19         ` Stefan Ringel
2010-02-02 20:30           ` Mauro Carvalho Chehab
2010-02-02 20:42         ` Stefan Ringel
2010-02-02 20:52           ` Mauro Carvalho Chehab
2010-02-02 21:11             ` Stefan Ringel
2010-02-03 20:10               ` [PATCH 1/15] - tm6000 build hunk Stefan Ringel
2010-02-03 20:13                 ` [PATCH 2/15] - tm6000 add Terratec Cinergy Hybrid XE Stefan Ringel
2010-02-03 20:15                   ` [PATCH 3/15] - tm6000 bugfix hunk in init_dev Stefan Ringel
2010-02-03 20:22                     ` Mauro Carvalho Chehab
2010-02-03 20:16                   ` [PATCH 4/15] - tm6000.h Stefan Ringel
2010-02-03 20:25                     ` Mauro Carvalho Chehab
2010-02-03 20:50                       ` Stefan Ringel
2010-02-03 20:58                         ` Devin Heitmueller
2010-02-03 21:31                         ` Mauro Carvalho Chehab
2010-02-03 20:18                   ` [PATCH 5/15] - tm6000 bugfix i2c transfer Stefan Ringel
2010-02-03 20:18                   ` [PATCH 2/15] - tm6000 add Terratec Cinergy Hybrid XE Mauro Carvalho Chehab
2010-02-03 20:20                   ` [PATCH 6/15] - tm6000 bugfix usb transfer in DVB mode Stefan Ringel
2010-02-03 20:22                   ` [PATCH 7/15] - tm6000 Stefan Ringel
2010-02-03 20:23                   ` [PATCH 2/15] - tm6000 bugfix Stefan Ringel
2010-02-03 20:25                   ` [PATCH 9/15] - tm6000 analog digital switch Stefan Ringel
2010-02-03 20:40                     ` Mauro Carvalho Chehab [this message]
2010-02-03 20:55                       ` Stefan Ringel
2010-02-03 21:21                         ` Mauro Carvalho Chehab
2010-02-03 20:27                   ` [PATCH 2/15] - tm6000 add digital init for tm6010 Stefan Ringel
2010-02-03 20:29                   ` [PATCH 11/15] - tm6000 add " Stefan Ringel
2010-02-03 20:31                   ` [PATCH 12/15] - tm6000 bugfix tuner reset time and tuner param Stefan Ringel
2010-02-03 20:52                     ` Devin Heitmueller
2010-02-03 21:15                       ` Stefan Ringel
2010-02-03 20:36                   ` [PATCH 13/15] - xc2028 bugfix for firmware 3.6 -> Zarlink use without shift in DTV8 or DTV78 Stefan Ringel
2010-02-03 20:45                     ` Devin Heitmueller
2010-02-03 20:38                   ` [PATCH 14/15] - zl10353 Stefan Ringel
2010-02-03 20:49                     ` Devin Heitmueller
2010-02-03 21:07                       ` Stefan Ringel
2010-02-04  2:43                         ` Mauro Carvalho Chehab
2010-02-04 21:12                           ` Stefan Ringel
2010-02-05  0:06                             ` Mauro Carvalho Chehab
2010-02-03 20:40                   ` [PATCH 15/15] - tm6000 hack with different demodulator parameter Stefan Ringel
2010-02-03 20:47                     ` Devin Heitmueller
2010-02-03 20:16                 ` [PATCH 1/15] - tm6000 build hunk Mauro Carvalho Chehab
2010-02-03 20:17                 ` Devin Heitmueller
2010-02-03 21:48                 ` Stefan Ringel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B69DF20.50205@redhat.com \
    --to=mchehab@redhat.com \
    --cc=dheitmueller@kernellabs.com \
    --cc=linux-media@vger.kernel.org \
    --cc=stefan.ringel@arcor.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox