public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Ringel <stefan.ringel@arcor.de>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org,
	Devin Heitmueller <dheitmueller@kernellabs.com>
Subject: Re: [PATCH 4/15] -  tm6000.h
Date: Wed, 03 Feb 2010 21:50:27 +0100	[thread overview]
Message-ID: <4B69E193.6040206@arcor.de> (raw)
In-Reply-To: <4B69DB9D.90609@redhat.com>

Am 03.02.2010 21:25, schrieb Mauro Carvalho Chehab:
> This one is a very obscure patch. What are you doing this patch and why?
>
> Stefan Ringel wrote:
>   
>> signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
>>
>> --- a/drivers/staging/tm6000/tm6000.h
>> +++ b/drivers/staging/tm6000/tm6000.h
>> @@ -90,12 +97,14 @@ enum tm6000_core_state {
>>      DEV_MISCONFIGURED = 0x04,
>>  };
>>  
>> +#if 1
>>  /* io methods */
>>  enum tm6000_io_method {
>>      IO_NONE,
>>      IO_READ,
>>      IO_MMAP,
>>  };
>> +#endif
>>  
>>     
? different between git and hg ? not mine
>>  enum tm6000_mode {
>>      TM6000_MODE_UNKNOWN=0,
>> @@ -202,6 +211,9 @@ struct tm6000_fh {
>>              V4L2_STD_PAL_M|V4L2_STD_PAL_60|V4L2_STD_NTSC_M| \
>>              V4L2_STD_NTSC_M_JP|V4L2_STD_SECAM
>>  
>> +/* In tm6000-cards.c */
>> +
>> +int tm6000_tuner_callback (void *ptr, int component, int command, int arg);
>>  /* In tm6000-core.c */
>>  
>>     
I use that for tuner callback in tm6000-dvb --> frontend structure
>>  int tm6000_read_write_usb (struct tm6000_core *dev, u8 reqtype, u8 req,
>> @@ -209,7 +221,6 @@ int tm6000_read_write_usb (struct tm6000_core *dev,
>> u8 reqtype, u8 req,
>>  int tm6000_get_reg (struct tm6000_core *dev, u8 req, u16 value, u16 index);
>>  int tm6000_set_reg (struct tm6000_core *dev, u8 req, u16 value, u16 index);
>>  int tm6000_init (struct tm6000_core *dev);
>> -int tm6000_init_after_firmware (struct tm6000_core *dev);
>>  
>>  int tm6000_init_analog_mode (struct tm6000_core *dev);
>>  int tm6000_init_digital_mode (struct tm6000_core *dev);
>> @@ -231,7 +242,12 @@ int tm6000_set_standard (struct tm6000_core *dev,
>> v4l2_std_id *norm);
>>  int tm6000_i2c_register(struct tm6000_core *dev);
>>  int tm6000_i2c_unregister(struct tm6000_core *dev);
>>  
>> +#if 1
>>  /* In tm6000-queue.c */
>> +#if 0
>> +int tm6000_init_isoc(struct tm6000_core *dev, int max_packets);
>> +void tm6000_uninit_isoc(struct tm6000_core *dev);
>> +#endif
>>  
>>     
? different between git and hg ? not mine
>>  int tm6000_v4l2_mmap(struct file *filp, struct vm_area_struct *vma);
>>  
>> @@ -276,3 +292,4 @@ extern int tm6000_debug;
>>          __FUNCTION__ , ##arg); } while (0)
>>  
>>  
>> +#endif
>>
>>     
>
>   


-- 
Stefan Ringel <stefan.ringel@arcor.de>


  reply	other threads:[~2010-02-03 20:50 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-01 20:20 [PATCH] - tm6000 DVB support Stefan Ringel
2010-02-01 20:35 ` Stefan Ringel
2010-02-01 20:52   ` Devin Heitmueller
2010-02-01 21:23     ` Stefan Ringel
2010-02-01 21:44       ` Devin Heitmueller
2010-02-01 22:00         ` Stefan Ringel
2010-02-01 23:05           ` Mauro Carvalho Chehab
2010-02-02 16:14             ` Stefan Ringel
2010-02-02 16:44               ` Mauro Carvalho Chehab
2010-02-02 17:38                 ` Stefan Ringel
2010-02-02 20:05                   ` Mauro Carvalho Chehab
2010-02-01 22:52   ` Mauro Carvalho Chehab
2010-02-02 17:24     ` Stefan Ringel
2010-02-02 20:03       ` Mauro Carvalho Chehab
2010-02-02 20:19         ` Stefan Ringel
2010-02-02 20:30           ` Mauro Carvalho Chehab
2010-02-02 20:42         ` Stefan Ringel
2010-02-02 20:52           ` Mauro Carvalho Chehab
2010-02-02 21:11             ` Stefan Ringel
2010-02-03 20:10               ` [PATCH 1/15] - tm6000 build hunk Stefan Ringel
2010-02-03 20:13                 ` [PATCH 2/15] - tm6000 add Terratec Cinergy Hybrid XE Stefan Ringel
2010-02-03 20:15                   ` [PATCH 3/15] - tm6000 bugfix hunk in init_dev Stefan Ringel
2010-02-03 20:22                     ` Mauro Carvalho Chehab
2010-02-03 20:16                   ` [PATCH 4/15] - tm6000.h Stefan Ringel
2010-02-03 20:25                     ` Mauro Carvalho Chehab
2010-02-03 20:50                       ` Stefan Ringel [this message]
2010-02-03 20:58                         ` Devin Heitmueller
2010-02-03 21:31                         ` Mauro Carvalho Chehab
2010-02-03 20:18                   ` [PATCH 5/15] - tm6000 bugfix i2c transfer Stefan Ringel
2010-02-03 20:18                   ` [PATCH 2/15] - tm6000 add Terratec Cinergy Hybrid XE Mauro Carvalho Chehab
2010-02-03 20:20                   ` [PATCH 6/15] - tm6000 bugfix usb transfer in DVB mode Stefan Ringel
2010-02-03 20:22                   ` [PATCH 7/15] - tm6000 Stefan Ringel
2010-02-03 20:23                   ` [PATCH 2/15] - tm6000 bugfix Stefan Ringel
2010-02-03 20:25                   ` [PATCH 9/15] - tm6000 analog digital switch Stefan Ringel
2010-02-03 20:40                     ` Mauro Carvalho Chehab
2010-02-03 20:55                       ` Stefan Ringel
2010-02-03 21:21                         ` Mauro Carvalho Chehab
2010-02-03 20:27                   ` [PATCH 2/15] - tm6000 add digital init for tm6010 Stefan Ringel
2010-02-03 20:29                   ` [PATCH 11/15] - tm6000 add " Stefan Ringel
2010-02-03 20:31                   ` [PATCH 12/15] - tm6000 bugfix tuner reset time and tuner param Stefan Ringel
2010-02-03 20:52                     ` Devin Heitmueller
2010-02-03 21:15                       ` Stefan Ringel
2010-02-03 20:36                   ` [PATCH 13/15] - xc2028 bugfix for firmware 3.6 -> Zarlink use without shift in DTV8 or DTV78 Stefan Ringel
2010-02-03 20:45                     ` Devin Heitmueller
2010-02-03 20:38                   ` [PATCH 14/15] - zl10353 Stefan Ringel
2010-02-03 20:49                     ` Devin Heitmueller
2010-02-03 21:07                       ` Stefan Ringel
2010-02-04  2:43                         ` Mauro Carvalho Chehab
2010-02-04 21:12                           ` Stefan Ringel
2010-02-05  0:06                             ` Mauro Carvalho Chehab
2010-02-03 20:40                   ` [PATCH 15/15] - tm6000 hack with different demodulator parameter Stefan Ringel
2010-02-03 20:47                     ` Devin Heitmueller
2010-02-03 20:16                 ` [PATCH 1/15] - tm6000 build hunk Mauro Carvalho Chehab
2010-02-03 20:17                 ` Devin Heitmueller
2010-02-03 21:48                 ` Stefan Ringel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B69E193.6040206@arcor.de \
    --to=stefan.ringel@arcor.de \
    --cc=dheitmueller@kernellabs.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox