public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <shijie8@gmail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org, zyziii@telegent.com, tiwai@suse.de
Subject: Re: [PATCH v2 00/10] add linux driver for chip TLG2300
Date: Thu, 04 Feb 2010 17:06:10 +0800	[thread overview]
Message-ID: <4B6A8E02.3090905@gmail.com> (raw)
In-Reply-To: <4B693AD6.3030005@redhat.com>


> No, I don't meant that.
>
> The differences of FM radio standards are basically the preemphasis and the
> frequency ranges.
>
> For frequency ranges, V4L2_TUNER_RADIO allows specifying the maximum/minimum values.
>
> For preemphasis, you should implement V4L2_CID_TUNE_PREEMPHASIS ctrl. This
> CTRL has 3 states:
>
>          static const char *tune_preemphasis[] = {
>                  "No preemphasis",
>                  "50 useconds",
>                  "75 useconds",
>                  NULL,
>          };
>
> At v4l2-common.c, there are some functions that helps to implement it
> at the driver, like:
> 	v4l2_ctrl_get_menu, v4l2_ctrl_get_name and v4l2_ctrl_query_fill.
>    
I meet a problem now. :(

Even I add the ctrl to the tlg2300 driver, there is no application to
test it :

[1] The Mplayer do not check the ctrl except the "vulume " or "mute".
[2] I do  not know how to use the VLC to listen the radio with ALSA, I
tried many times, but failed. Does someone know this ?

Btw: I will be on my vacation for the following two weeks, I will come 
back to
work at 20th of this month. I afraid I can not finish the patches to 
remove  the
country code in the two days(today and tomorrow).


> Take a look at si4713-i2c.c for an example on how to use it.
>
> Ah, please submit those changes as another series of patches. This helps me
> to not needing to review the entire changeset again.
>
> Cheers,
> Mauro
>
>    
Best Regards
Huang Shijie


  parent reply	other threads:[~2010-02-04  9:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-02  7:07 [PATCH v2 00/10] add linux driver for chip TLG2300 Huang Shijie
2010-02-02  7:07 ` [PATCH v2 01/10] add header files for tlg2300 Huang Shijie
2010-02-02  7:07   ` [PATCH v2 02/10] add the generic file Huang Shijie
2010-02-02  7:07     ` [PATCH v2 03/10] add video/vbi file for tlg2300 Huang Shijie
2010-02-02  7:07       ` [PATCH v2 04/10] add DVB-T support " Huang Shijie
2010-02-02  7:07         ` [PATCH v2 05/10] add FM " Huang Shijie
2010-02-02  7:07           ` [PATCH v2 06/10] add audio " Huang Shijie
2010-02-02  7:07             ` [PATCH v2 07/10] add document file " Huang Shijie
2010-02-02  7:07               ` [PATCH v2 08/10] add Kconfig and Makefile " Huang Shijie
2010-02-02  7:07                 ` [PATCH v2 09/10] modify the " Huang Shijie
2010-02-02 12:17 ` [PATCH v2 00/10] add linux driver for chip TLG2300 Mauro Carvalho Chehab
2010-02-03  6:20   ` Huang Shijie
2010-02-03  7:29     ` Mauro Carvalho Chehab
2010-02-03  8:40       ` Huang Shijie
2010-02-03  8:59         ` Mauro Carvalho Chehab
2010-02-03  9:14           ` Huang Shijie
2010-02-04  9:06           ` Huang Shijie [this message]
2010-02-04 12:19             ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6A8E02.3090905@gmail.com \
    --to=shijie8@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=tiwai@suse.de \
    --cc=zyziii@telegent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox