From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Chicken Shack <chicken.shack@gmx.de>,
Andreas Oberritter <obi@linuxtv.org>,
Andy Walls <awalls@radix.net>, HoP <jpetrous@gmail.com>,
Francesco Lavra <francescolavra@interfree.it>,
linux-media@vger.kernel.org, akpm@linux-foundation.org,
rms@gnu.org, hermann-pitton@arcor.de
Subject: Re: [PATCH] dvb-core: fix initialization of feeds list in demux filter (Was: Videotext application crashes the kernel due to DVB-demux patch)
Date: Mon, 08 Feb 2010 15:22:35 -0200 [thread overview]
Message-ID: <4B70485B.2090600@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1002080746180.3829@localhost.localdomain>
Linus Torvalds wrote:
> - if somebody reports a regression, IT MUST BE FIXED. Not "discussed" for
> two weeks. Not talked around. If we have a bisected commit that starts
> oopsing with an existing setup that used to work, there is no
> discussion. That commit absolutely _has_ to be reverted or fixed. No
> ifs, buts, or maybes about it.
> Anybody who argues anything else is simply totally wrong. And
> discussing various semantic changes or asking people to use other
> programs instead of the one that causes the problem is totally
> irrelevant until the oops has been fixed.
>
> An oops is not acceptable in _any_ situation, and saying that the user
> program is doing something wrong is totally ludicrous. So is breaking a
> program that used to work.
>
> The fix, btw, for those that haven't seen it, seems to be here:
>
> http://patchwork.kernel.org/patch/77615/
Yes, this patch actually fixed the OOPS, although it were a report From Chicken
saying that a previous patch got fixed it (http://patchwork.kernel.org/patch/76071/).
I submitted you both fixes, plus a third one (http://patchwork.kernel.org/patch/76083/)
for a potential usage of vmalloc during interrupt time.
Cheers,
Mauro
next prev parent reply other threads:[~2010-02-08 17:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-07 12:49 [PATCH] dvb-core: fix initialization of feeds list in demux filter Francesco Lavra
2010-02-07 15:13 ` Andy Walls
2010-02-07 21:21 ` hermann pitton
2010-02-08 2:11 ` Mauro Carvalho Chehab
2010-02-08 12:24 ` Andreas Oberritter
2010-02-08 13:43 ` [PATCH] dvb-core: fix initialization of feeds list in demux filter (Was: Videotext application crashes the kernel due to DVB-demux patch) Chicken Shack
2010-02-08 16:14 ` Linus Torvalds
2010-02-08 17:22 ` Mauro Carvalho Chehab [this message]
2010-02-08 18:25 ` Chicken Shack
2010-02-08 19:09 ` Linus Torvalds
2010-02-08 19:20 ` Chicken Shack
2010-02-08 23:30 ` Rudy Zijlstra
[not found] ` <E1NeyGg-0000ze-FG@fencepost.gnu.org>
2010-02-09 22:34 ` Chicken Shack
2010-02-09 0:53 ` hermann pitton
2010-02-09 8:38 ` Chicken Shack
2010-02-11 0:50 ` hermann pitton
2010-02-08 16:15 ` Devin Heitmueller
2010-02-08 18:01 ` Alain Kalker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B70485B.2090600@redhat.com \
--to=mchehab@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=awalls@radix.net \
--cc=chicken.shack@gmx.de \
--cc=francescolavra@interfree.it \
--cc=hermann-pitton@arcor.de \
--cc=jpetrous@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=obi@linuxtv.org \
--cc=rms@gnu.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox