From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: stefan.ringel@arcor.de
Cc: linux-media@vger.kernel.org, dheitmueller@kernellabs.com
Subject: Re: [PATCH 07/11] tm6000: add i2c send recv functions
Date: Thu, 18 Feb 2010 18:28:58 -0200 [thread overview]
Message-ID: <4B7DA30A.5030100@redhat.com> (raw)
In-Reply-To: <1266255444-7422-7-git-send-email-stefan.ringel@arcor.de>
stefan.ringel@arcor.de wrote:
> From: Stefan Ringel <stefan.ringel@arcor.de>
>
> Signed-off-by: Stefan Ringel <stefan.ringel@arcor.de>
Why do you need to split it into two functions? It should be noticed that the naming
tm6000_i2c_recv_word is wrong, since the size can be bigger than 2.
Also, this patch broke compilation on -git:
CC [M] drivers/staging/tm6000/tm6000-i2c.o
drivers/staging/tm6000/tm6000-i2c.c: In function ‘tm6000_i2c_send_byte’:
drivers/staging/tm6000/tm6000-i2c.c:50: error: ‘REQ_16_SET_GET_I2C_WR1_RND’ undeclared (first use in this function)
drivers/staging/tm6000/tm6000-i2c.c:50: error: (Each undeclared identifier is reported only once
drivers/staging/tm6000/tm6000-i2c.c:50: error: for each function it appears in.)
drivers/staging/tm6000/tm6000-i2c.c: In function ‘tm6000_i2c_recv_byte’:
drivers/staging/tm6000/tm6000-i2c.c:55: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘:’ token
drivers/staging/tm6000/tm6000-i2c.c:55: error: expected expression before ‘:’ token
drivers/staging/tm6000/tm6000-i2c.c:60: error: ‘rc’ undeclared (first use in this function)
drivers/staging/tm6000/tm6000-i2c.c: In function ‘tm6000_i2c_recv_word’:
drivers/staging/tm6000/tm6000-i2c.c:68: error: ‘REQ_14_SET_GET_I2C_WR2_RND’ undeclared (first use in this function)
make[1]: ** [drivers/staging/tm6000/tm6000-i2c.o] Erro 1
Cheers,
Mauro
next prev parent reply other threads:[~2010-02-18 20:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 17:37 [PATCH 01/11] xc2028: tm6000: bugfix firmware xc3028L-v36.fw used with Zarlink and DTV78 or DTV8 no shift stefan.ringel
2010-02-15 17:37 ` [PATCH 02/11] tm6000: add i2c bus id for tm6000 stefan.ringel
2010-02-15 17:37 ` [PATCH 03/11] tm6000: add additional init register stefan.ringel
2010-02-15 17:37 ` [PATCH 04/11] tm6000: add different tuner reset for terratec stefan.ringel
2010-02-15 17:37 ` [PATCH 05/11] tm6000: add card setup for terratec cinergy hybrid stefan.ringel
2010-02-15 17:37 ` [PATCH 06/11] tm6000: reset the numbers of feeds to 8 stefan.ringel
2010-02-15 17:37 ` [PATCH 07/11] tm6000: add i2c send recv functions stefan.ringel
2010-02-15 17:37 ` [PATCH 08/11] tm6000: special request for all tuner stefan.ringel
2010-02-15 17:37 ` [PATCH 09/11] zl10353: tm6000: bugfix reading problems with tm6000 i2c host stefan.ringel
2010-02-15 17:37 ` [PATCH 10/11] tm6000: remove hack.c hack.h, switch to zl10353 module stefan.ringel
2010-02-15 17:37 ` [PATCH 11/11] tm6000: change version to 0.0.2 stefan.ringel
2010-02-18 20:20 ` [PATCH 09/11] zl10353: tm6000: bugfix reading problems with tm6000 i2c host Mauro Carvalho Chehab
2010-02-18 20:28 ` Mauro Carvalho Chehab [this message]
2010-02-15 18:36 ` [PATCH 01/11] xc2028: tm6000: bugfix firmware xc3028L-v36.fw used with Zarlink and DTV78 or DTV8 no shift Devin Heitmueller
2010-02-15 19:19 ` Stefan Ringel
2010-02-15 20:29 ` Stefan Ringel
-- strict thread matches above, loose matches on Subject: below --
2010-02-18 21:11 [PATCH 07/11] tm6000: add i2c send recv functions stefan.ringel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7DA30A.5030100@redhat.com \
--to=mchehab@redhat.com \
--cc=dheitmueller@kernellabs.com \
--cc=linux-media@vger.kernel.org \
--cc=stefan.ringel@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox