From: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
To: "Aguirre, Sergio" <saaguirre@ti.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"hverkuil@xs4all.nl" <hverkuil@xs4all.nl>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"iivanov@mm-sol.com" <iivanov@mm-sol.com>,
"gururaj.nagendra@intel.com" <gururaj.nagendra@intel.com>,
"david.cohen@nokia.com" <david.cohen@nokia.com>
Subject: Re: [PATCH v5 1/6] V4L: File handles
Date: Sun, 21 Feb 2010 22:22:30 +0200 [thread overview]
Message-ID: <4B819606.6040602@maxwell.research.nokia.com> (raw)
In-Reply-To: <A24693684029E5489D1D202277BE894453691587@dlee02.ent.ti.com>
Aguirre, Sergio wrote:
> Heippa!
Hi, Sergio!
Thanks for comments!
...
>> @@ -0,0 +1,64 @@
>> +/*
>> + * drivers/media/video/v4l2-fh.c
>
> [1] AFAIK, putting file paths is frowned upon.
>
> Makes maintenance harder if in the future, this files get moved somewhere else.
Ack.
>> + *
>> + * V4L2 file handles.
>> + *
>> + * Copyright (C) 2009 Nokia Corporation.
>
> [2] Shouldn't it be "(C) 2010" already? :)
It is. The patches have been floating around since 2009 and I've just
forgotten to update this. I hope no-one will notify 2010 must be
replaced by 2011 at some point... ;-)
...
>> +#endif /* V4L2_EVENT_H */
>
> Wrong comment, must have been:
>
> /* V4L2_FH_H */
Will fix.
--
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com
next prev parent reply other threads:[~2010-02-21 20:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 19:21 [PATCH v5 0/6] V4L2 file handles and event interface Sakari Ailus
2010-02-19 19:21 ` [PATCH v5 1/6] V4L: File handles Sakari Ailus
2010-02-19 22:29 ` Aguirre, Sergio
2010-02-19 22:34 ` Laurent Pinchart
2010-02-19 22:54 ` Aguirre, Sergio
2010-02-21 20:22 ` Sakari Ailus [this message]
2010-02-22 17:27 ` Aguirre, Sergio
2010-02-22 17:36 ` Sakari Ailus
2010-02-19 19:21 ` [PATCH v5 2/6] V4L: File handles: Add documentation Sakari Ailus
2010-02-20 9:59 ` Hans Verkuil
2010-02-19 19:21 ` [PATCH v5 3/6] V4L: Events: Add new ioctls for events Sakari Ailus
2010-02-19 19:21 ` [PATCH v5 4/6] V4L: Events: Add backend Sakari Ailus
2010-02-19 22:46 ` Aguirre, Sergio
2010-02-21 20:25 ` Sakari Ailus
2010-02-20 9:45 ` Hans Verkuil
2010-02-21 20:57 ` Sakari Ailus
2010-02-22 7:56 ` Hans Verkuil
2010-02-19 19:21 ` [PATCH v5 5/6] V4L: Events: Support event handling in do_ioctl Sakari Ailus
2010-02-20 9:56 ` Hans Verkuil
2010-02-21 22:31 ` Sakari Ailus
2010-02-21 22:54 ` Laurent Pinchart
2010-02-22 7:37 ` Sakari Ailus
2010-02-22 7:53 ` Hans Verkuil
2010-02-22 9:10 ` Laurent Pinchart
2010-02-22 9:21 ` Hans Verkuil
2010-02-22 9:41 ` Sakari Ailus
2010-02-19 19:22 ` [PATCH v5 6/6] V4L: Events: Add documentation Sakari Ailus
2010-02-20 10:15 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B819606.6040602@maxwell.research.nokia.com \
--to=sakari.ailus@maxwell.research.nokia.com \
--cc=david.cohen@nokia.com \
--cc=gururaj.nagendra@intel.com \
--cc=hverkuil@xs4all.nl \
--cc=iivanov@mm-sol.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=saaguirre@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox