From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.nokia.com ([192.100.122.233]:48113 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751547Ab0BUUWk (ORCPT ); Sun, 21 Feb 2010 15:22:40 -0500 Message-ID: <4B819606.6040602@maxwell.research.nokia.com> Date: Sun, 21 Feb 2010 22:22:30 +0200 From: Sakari Ailus MIME-Version: 1.0 To: "Aguirre, Sergio" CC: "linux-media@vger.kernel.org" , "hverkuil@xs4all.nl" , "laurent.pinchart@ideasonboard.com" , "iivanov@mm-sol.com" , "gururaj.nagendra@intel.com" , "david.cohen@nokia.com" Subject: Re: [PATCH v5 1/6] V4L: File handles References: <4B7EE4A4.3080202@maxwell.research.nokia.com> <1266607320-9974-1-git-send-email-sakari.ailus@maxwell.research.nokia.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Aguirre, Sergio wrote: > Heippa! Hi, Sergio! Thanks for comments! ... >> @@ -0,0 +1,64 @@ >> +/* >> + * drivers/media/video/v4l2-fh.c > > [1] AFAIK, putting file paths is frowned upon. > > Makes maintenance harder if in the future, this files get moved somewhere else. Ack. >> + * >> + * V4L2 file handles. >> + * >> + * Copyright (C) 2009 Nokia Corporation. > > [2] Shouldn't it be "(C) 2010" already? :) It is. The patches have been floating around since 2009 and I've just forgotten to update this. I hope no-one will notify 2010 must be replaced by 2011 at some point... ;-) ... >> +#endif /* V4L2_EVENT_H */ > > Wrong comment, must have been: > > /* V4L2_FH_H */ Will fix. -- Sakari Ailus sakari.ailus@maxwell.research.nokia.com