* [PATCH] media: fix precedence in dvb/frontends/tda665x
@ 2010-02-25 22:57 Randy Dunlap
2010-02-26 7:45 ` Manu Abraham
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2010-02-25 22:57 UTC (permalink / raw)
To: Linux Media Mailing List; +Cc: Mauro Carvalho Chehab, Manu Abraham
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix precedence so that data is used correctly.
Fixes sparse warning:
drivers/media/dvb/frontends/tda665x.c:136:55: warning: right shift by bigger than source value
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Manu Abraham <abraham.manu@gmail.com>
---
drivers/media/dvb/frontends/tda665x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- lnx-2633-spr.orig/drivers/media/dvb/frontends/tda665x.c
+++ lnx-2633-spr/drivers/media/dvb/frontends/tda665x.c
@@ -133,7 +133,7 @@ static int tda665x_set_state(struct dvb_
frequency += config->ref_divider >> 1;
frequency /= config->ref_divider;
- buf[0] = (u8) (frequency & 0x7f00) >> 8;
+ buf[0] = (u8) ((frequency & 0x7f00) >> 8);
buf[1] = (u8) (frequency & 0x00ff) >> 0;
buf[2] = 0x80 | 0x40 | 0x02;
buf[3] = 0x00;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: fix precedence in dvb/frontends/tda665x
2010-02-25 22:57 [PATCH] media: fix precedence in dvb/frontends/tda665x Randy Dunlap
@ 2010-02-26 7:45 ` Manu Abraham
0 siblings, 0 replies; 2+ messages in thread
From: Manu Abraham @ 2010-02-26 7:45 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Linux Media Mailing List, Mauro Carvalho Chehab
Hi Randy,
Thanks for catching the bug !
On Fri, Feb 26, 2010 at 2:57 AM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix precedence so that data is used correctly.
> Fixes sparse warning:
> drivers/media/dvb/frontends/tda665x.c:136:55: warning: right shift by bigger than source value
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Manu Abraham <abraham.manu@gmail.com>
Reviewed-by: Manu Abraham <manu@linuxtv.org>
Acked-by: Manu Abraham <manu@linuxtv.org>
> ---
> drivers/media/dvb/frontends/tda665x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- lnx-2633-spr.orig/drivers/media/dvb/frontends/tda665x.c
> +++ lnx-2633-spr/drivers/media/dvb/frontends/tda665x.c
> @@ -133,7 +133,7 @@ static int tda665x_set_state(struct dvb_
> frequency += config->ref_divider >> 1;
> frequency /= config->ref_divider;
>
> - buf[0] = (u8) (frequency & 0x7f00) >> 8;
> + buf[0] = (u8) ((frequency & 0x7f00) >> 8);
> buf[1] = (u8) (frequency & 0x00ff) >> 0;
> buf[2] = 0x80 | 0x40 | 0x02;
> buf[3] = 0x00;
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-26 7:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-25 22:57 [PATCH] media: fix precedence in dvb/frontends/tda665x Randy Dunlap
2010-02-26 7:45 ` Manu Abraham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox