From: "Németh Márton" <nm127@freemail.hu>
To: Jean Delvare <khali@linux-fr.org>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
Douglas Schilling Landgraf <dougsland@redhat.com>
Cc: V4L Mailing List <linux-media@vger.kernel.org>
Subject: [PATCH] bttv: fix compiler warning before kernel 2.6.30
Date: Sat, 06 Mar 2010 10:25:24 +0100 [thread overview]
Message-ID: <4B921F84.3000803@freemail.hu> (raw)
In-Reply-To: <4B921F5F.4000905@freemail.hu>
From: Márton Németh <nm127@freemail.hu>
Fix the following compiler warnings when compiling before Linux
kernel version 2.6.30:
bttv-i2c.c: In function 'init_bttv_i2c':
bttv-i2c.c:440: warning: control reaches end of non-void function
Signed-off-by: Márton Németh <nm127@freemail.hu>
---
diff -r 41c5482f2dac linux/drivers/media/video/bt8xx/bttv-i2c.c
--- a/linux/drivers/media/video/bt8xx/bttv-i2c.c Thu Mar 04 02:49:46 2010 -0300
+++ b/linux/drivers/media/video/bt8xx/bttv-i2c.c Sat Mar 06 10:22:55 2010 +0100
@@ -409,7 +409,6 @@
}
if (0 == btv->i2c_rc && i2c_scan)
do_i2c_scan(btv->c.v4l2_dev.name, &btv->i2c_client);
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 30)
return btv->i2c_rc;
}
@@ -417,6 +416,7 @@
/* Instantiate the I2C IR receiver device, if present */
void __devinit init_bttv_i2c_ir(struct bttv *btv)
{
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 30)
if (0 == btv->i2c_rc) {
struct i2c_board_info info;
/* The external IR receiver is at i2c address 0x34 (0x35 for
next prev parent reply other threads:[~2010-03-06 9:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-16 17:21 [PATCH 1/2] bttv: Move I2C IR initialization Jean Delvare
2010-03-06 9:24 ` Németh Márton
2010-03-06 9:25 ` Németh Márton [this message]
2010-03-06 12:03 ` [PATCH] bttv: fix compiler warning before kernel 2.6.30 Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B921F84.3000803@freemail.hu \
--to=nm127@freemail.hu \
--cc=dougsland@redhat.com \
--cc=khali@linux-fr.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox