From: Huang Shijie <shijie8@gmail.com>
To: Huang Shijie <shijie8@gmail.com>
Cc: mchehab@redhat.com, linux-media@vger.kernel.org
Subject: Re: [BUGFIX][PATCH] change some parameters for tlg2300
Date: Mon, 15 Mar 2010 17:01:13 +0800 [thread overview]
Message-ID: <4B9DF759.2070400@gmail.com> (raw)
In-Reply-To: <1268642648-3132-1-git-send-email-shijie8@gmail.com>
Hi Mauro:
Please ignore this patch.
This patch has side effect : the radio does not run well with this patch.
Best Regards
Huang Shijie.
> The orgin parameters may cause a bug : The audio may lost in certain
> situation (such as open the VLC at the first time).
>
> The origin parameters set a small stop_threshold for snd_pcm_runtime{}.
> So a xrun occurs in some situation.
>
> Signed-off-by: Huang Shijie <shijie8@gmail.com>
> ---
> drivers/media/video/tlg2300/pd-alsa.c | 10 ----------
> 1 files changed, 0 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/media/video/tlg2300/pd-alsa.c b/drivers/media/video/tlg2300/pd-alsa.c
> index 6f42621..e9ad715 100644
> --- a/drivers/media/video/tlg2300/pd-alsa.c
> +++ b/drivers/media/video/tlg2300/pd-alsa.c
> @@ -21,9 +21,6 @@
> static void complete_handler_audio(struct urb *urb);
> #define AUDIO_EP (0x83)
> #define AUDIO_BUF_SIZE (512)
> -#define PERIOD_SIZE (1024 * 8)
> -#define PERIOD_MIN (4)
> -#define PERIOD_MAX PERIOD_MIN
>
> static struct snd_pcm_hardware snd_pd_hw_capture = {
> .info = SNDRV_PCM_INFO_BLOCK_TRANSFER |
> @@ -38,18 +35,11 @@ static struct snd_pcm_hardware snd_pd_hw_capture = {
> .rate_max = 48000,
> .channels_min = 2,
> .channels_max = 2,
> - .buffer_bytes_max = PERIOD_SIZE * PERIOD_MIN,
> - .period_bytes_min = PERIOD_SIZE,
> - .period_bytes_max = PERIOD_SIZE,
> - .periods_min = PERIOD_MIN,
> - .periods_max = PERIOD_MAX,
> - /*
> .buffer_bytes_max = 62720 * 8,
> .period_bytes_min = 64,
> .period_bytes_max = 12544,
> .periods_min = 2,
> .periods_max = 98
> - */
> };
>
> static int snd_pd_capture_open(struct snd_pcm_substream *substream)
>
next prev parent reply other threads:[~2010-03-15 8:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 8:44 [BUGFIX][PATCH] change some parameters for tlg2300 Huang Shijie
2010-03-15 9:01 ` Huang Shijie [this message]
2010-03-16 5:19 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9DF759.2070400@gmail.com \
--to=shijie8@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox