From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63982 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751152Ab0CRREt (ORCPT ); Thu, 18 Mar 2010 13:04:49 -0400 Message-ID: <4BA25D2A.8020005@redhat.com> Date: Thu, 18 Mar 2010 14:04:42 -0300 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: Laurent Pinchart CC: linux-media@vger.kernel.org Subject: Re: [PATCH 1/2] v4l: Add V4L2_CID_IRIS_ABSOLUTE and V4L2_CID_IRIS_RELATIVE controls References: <1268913303-30565-1-git-send-email-laurent.pinchart@ideasonboard.com> <4BA21F80.8050906@redhat.com> <201003181350.53195.laurent.pinchart@ideasonboard.com> <201003181351.43040.laurent.pinchart@ideasonboard.com> In-Reply-To: <201003181351.43040.laurent.pinchart@ideasonboard.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org List-ID: Laurent Pinchart wrote: > Hi Mauro, > > On Thursday 18 March 2010 13:50:50 Laurent Pinchart wrote: >> On Thursday 18 March 2010 13:41:36 Mauro Carvalho Chehab wrote: >>> Laurent Pinchart wrote: >>>> On Thursday 18 March 2010 13:19:57 Mauro Carvalho Chehab wrote: >>>>> Laurent Pinchart wrote: >>>>>> Those control, as their names imply, control the camera aperture >>>>>> settings. >>>>>> >>>>>> Signed-off-by: Laurent Pinchart >>>>>> --- >>>>>> >>>>>> Documentation/DocBook/v4l/compat.xml | 11 +++++++++++ >>>>>> Documentation/DocBook/v4l/controls.xml | 19 +++++++++++++++++++ >>>>>> Documentation/DocBook/v4l/videodev2.h.xml | 3 +++ >>>>>> include/linux/videodev2.h | 3 +++ >>>>>> 4 files changed, 36 insertions(+), 0 deletions(-) >>>>>> >>>>>> diff --git a/Documentation/DocBook/v4l/compat.xml >>>>>> b/Documentation/DocBook/v4l/compat.xml index b9dbdf9..854235b 100644 >>>>>> --- a/Documentation/DocBook/v4l/compat.xml >>>>>> +++ b/Documentation/DocBook/v4l/compat.xml >>>>>> @@ -2332,6 +2332,17 @@ more information. >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> +
>>>>>> + V4L2 in Linux 2.6.34 >>>>>> + >>>>>> + >>>>>> + Added >>>>>> +V4L2_CID_IRIS_ABSOLUTE and >>>>>> +V4L2_CID_IRIS_RELATIVE controls to the >>>>>> + Camera controls class. >>>>>> + >>>>>> + >>>>>> + >>>>>> >>>>>>
>>>>>> >>>>>>
>>>>>> >>>>>> diff --git a/Documentation/DocBook/v4l/controls.xml >>>>>> b/Documentation/DocBook/v4l/controls.xml index f464506..c412e89 >>>>>> 100644 --- a/Documentation/DocBook/v4l/controls.xml >>>>>> +++ b/Documentation/DocBook/v4l/controls.xml >>>>>> @@ -1825,6 +1825,25 @@ wide-angle direction. The zoom speed unit is >>>>>> driver-specific. >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> + >>>>> spanname="id">V4L2_CID_IRIS_ABSOLUTE >>>>> y> + integer >>>>>> + This control sets the >>>>>> +camera aperture's to the specified value. The unit is undefined. >>>>>> +Positive values open the iris, negative close it. >>>>>> + >>>>>> + >>>>>> + >>>>>> + >>>>>> + >>>>> spanname="id">V4L2_CID_IRIS_RELATIVE >>>>> y> + integer >>>>>> + This control modifies the >>>>>> +camera aperture's by the specified amount. The unit is undefined. >>>>>> +Positive values open the iris one step further, negative values >>>>>> close +it one step further. This is a write-only control. >>>>>> + >>>>>> + >>>>>> + >>>>>> + >>>>>> >>>>>> >>>>> > spanname="id">V4L2_CID_PRIVACY >>>>> y> boolean >>>>>> >>>>>> Prevent video from being >>>>>> acquired >>>>> Seems ok to me, but it would be good to add some sort of scale for >>>>> those controls. >>>> I'd love to, but most iris controllers will just let you specify a >>>> value in an arbitrary scale (0 for closed, 255 for fully opened for >>>> instance). In that case do we want to force driver developers to >>>> measure the aperture in µm units with a micrometer caliper ? :-) >>> : >>> :) >>> >>> Well, maybe then you could just comment that higher values means more >>> opened apertures. >> Could point, I will do. > > I spoke too fast, it's already there :-) Oh. OK then ;) Cheers, Mauro