From: Randy Dunlap <rdunlap@xenotime.net>
To: Ricardo Maraschini <xrmarsx@gmail.com>
Cc: linux-media@vger.kernel.org, dougsland@gmail.com, mchehab@infradead.org
Subject: Re: [PATCH] dib7000p.c: Fix for warning: the frame size of 1236 bytes is larger than 1024 bytes
Date: Tue, 30 Mar 2010 11:16:44 -0700 [thread overview]
Message-ID: <4BB2400C.3060509@xenotime.net> (raw)
In-Reply-To: <4BB23CB0.1080501@gmail.com>
On 03/30/10 11:02, Ricardo Maraschini wrote:
> When compiling the last version of v4l-dvb tree I got the following message:
>
> /data/Projects/kernel/v4l-dvb/v4l/dib7000p.c: In function 'dib7000p_i2c_enumeration':
> /data/Projects/kernel/v4l-dvb/v4l/dib7000p.c:1393: warning: the frame size of 1236 bytes is larger than 1024 bytes
>
> I believe that this problem is related to stack size, because we are allocating memory for a big structure.
> I changed the approach to dinamic allocated memory and the warning disappears.
> The same problem appears on dib3000 as well, and I can fix that too if this patch get in.
>
> Any comment on that?
> I'll appreciate to read any comment from more experienced code makers.
Hi,
There is one caller of dib7000p_i2c_enumeration() that does not check its
return value/error code. See
drivers/media/dvb/dvb-usb/cxusb.c::cxusb_dualdig4_rev2_frontend_attach():
dib7000p_i2c_enumeration(&adap->dev->i2c_adap, 1, 18,
&cxusb_dualdig4_rev2_config);
That is in my (similar) patch and I also posted a dib3000 patch.
Yes, it would be good if someone could review & merge them.
https://patchwork.kernel.org/patch/77891/
https://patchwork.kernel.org/patch/77892/
--
~Randy
prev parent reply other threads:[~2010-03-30 18:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 18:02 [PATCH] dib7000p.c: Fix for warning: the frame size of 1236 bytes is larger than 1024 bytes Ricardo Maraschini
2010-03-30 18:16 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB2400C.3060509@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=dougsland@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=xrmarsx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox