From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:54771 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758662Ab0DHNHW (ORCPT ); Thu, 8 Apr 2010 09:07:22 -0400 Message-ID: <4BBDD506.1000202@infradead.org> Date: Thu, 08 Apr 2010 10:07:18 -0300 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: =?ISO-8859-1?Q?David_H=E4rdeman?= CC: linux-input@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [RFC2] Teach drivers/media/IR/ir-raw-event.c to use durations References: <20100407201835.GA8438@hardeman.nu> <4BBD6550.6030000@infradead.org> <20100408112305.GA2803@hardeman.nu> <4BBDC318.4040709@infradead.org> <20100408124315.GA21540@hardeman.nu> In-Reply-To: <20100408124315.GA21540@hardeman.nu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org List-ID: David Härdeman wrote: > On Thu, Apr 08, 2010 at 08:50:48AM -0300, Mauro Carvalho Chehab wrote: >>> - size = sizeof(struct ir_raw_event) * MAX_IR_EVENT_SIZE * 2; >>> - size = roundup_pow_of_two(size); >>> + ir->raw->input_dev = input_dev; >>> + INIT_WORK(&ir->raw->rx_work, ir_raw_event_work); >>> >>> - rc = kfifo_alloc(&ir->raw->kfifo, size, GFP_KERNEL); >>> + rc = kfifo_alloc(&ir->raw->kfifo, sizeof(int) * MAX_IR_EVENT_SIZE, >>> + GFP_KERNEL); >> kfifo logic requires a power of two buffer to work, so, please keep the >> original roundup_pow_of_two() logic, or add a comment before MAX_IR_EVENT_SIZE. > > No, kfifo_alloc() takes care of the rounding up. See the code for > kfifo_alloc() in kernel/kfifo.c. > Ok. -- Cheers, Mauro