public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Ringel <stefan.ringel@arcor.de>
To: Bee Hock Goh <beehock@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
	Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: Help needed in understanding v4l2_device_call_all
Date: Fri, 23 Apr 2010 17:23:33 +0200	[thread overview]
Message-ID: <4BD1BB75.9020907@arcor.de> (raw)
In-Reply-To: <i2k6e8e83e21004221920q3f687324z8d8aba7ca26978ad@mail.gmail.com>

Am 23.04.2010 04:20, schrieb Bee Hock Goh:
> Mauro,
>
> Thanks.
>
> Previously, I have done some limited test and it seem that
> xc2028_signal seem to be getting the correct registered value for the
> detected a signal locked.
>
> Since I am now able to get video working(though somewhat limited since
> it still crashed if i change channel from mythtv), i will be spending
> more time to look getting a lock on the signal.
>
>
> Is line 139,140,155,156 needed? Its slowing down the loading of
> firmware and it working for me with the additional register setting.
>
>  138 if (addr == dev->tuner_addr << 1) {
> 139 tm6000_set_reg(dev, 0x32, 0,0);
> 140 tm6000_set_reg(dev, 0x33, 0,0);
>   
use tm6010
> 141 }
> 142 if (i2c_debug >= 2)
> 143 for (byte = 0; byte < msgs[i].len; byte++)
> 144 printk(" %02x", msgs[i].buf[byte]);
> 145 } else {
> 146 /* write bytes */
> 147 if (i2c_debug >= 2)
> 148 for (byte = 0; byte < msgs[i].len; byte++)
> 149 printk(" %02x", msgs[i].buf[byte]);
> 150 rc = tm6000_i2c_send_regs(dev, addr, msgs[i].buf[0],
> 151 msgs[i].buf + 1, msgs[i].len - 1);
> 152
> 153 if (addr == dev->tuner_addr << 1) {
> 154 tm6000_set_reg(dev, 0x32, 0,0);
> 155 tm6000_set_reg(dev, 0x33, 0,0);
>   
use tm6010
>
> On Fri, Apr 23, 2010 at 4:35 AM, Mauro Carvalho Chehab
> <mchehab@redhat.com> wrote:
>   
>> Bee Hock Goh wrote:
>>     
>>> Hi,
>>>
>>> I am trying to understand how the subdev function are triggered when I
>>> use v4l2_device_call_all(&dev->v4l2_dev, 0, tuner, g_tuner,t) on
>>> tm600-video.
>>>       
>> It calls tuner-core.c code, with g_tuner command. tuner-core
>> checks what's the used tuner and, in the case of tm6000, calls the corresponding
>> function at tuner-xc2028. This is implemented on tuner_g_tuner() function.
>>
>> The function basically does some sanity checks, and some common tuner code, but
>> the actual implementation is handled by some callbacks that the driver needs to
>> define (get_afc, get_status, is_stereo, has_signal). In general, drivers use
>> get_status for it:
>>                fe_tuner_ops->get_status(&t->fe, &tuner_status);
>>
>>
>> You will find a good example of how to implement such code at tuner-simple
>> simple_get_status() function.
>>
>> In the case of tuner-xc2028, we never found a way for it to properly report the
>> status of the tuner lock. That's why this function is not implemented on the driver.
>>
>>     
>>> How am i able to link the callback from the tuner_xc2028 function?
>>>       
>> The callback is used by tuner-xc2028 when it detects the need of changing the
>> firmware (or when the firmware is not loaded yet, or when you select a standard
>> that it is not supported by the current firmware).
>>
>> Basically, xc2028 driver will use the callback that was set previously via:
>>
>>        v4l2_device_call_all(&dev->v4l2_dev, 0, tuner, s_config, &xc2028_cfg);
>>
>>
>>     
>>> Please help me to understand or directly me to any documentation that
>>> I can read up?
>>>
>>> thanks,
>>>  Hock.
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-media" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>       
>>
>> --
>>
>> Cheers,
>> Mauro
>>
>>     
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>   


-- 
Stefan Ringel <stefan.ringel@arcor.de>


  parent reply	other threads:[~2010-04-23 15:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-07  6:10 Help needed in understanding v4l2_device_call_all Bee Hock Goh
2010-04-22 20:35 ` Mauro Carvalho Chehab
2010-04-23  2:20   ` Bee Hock Goh
2010-04-23 12:22     ` Mauro Carvalho Chehab
2010-04-23 15:23     ` Stefan Ringel [this message]
2010-04-23 15:28       ` Bee Hock Goh
2010-04-23 15:32         ` Stefan Ringel
2010-04-23 16:52           ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BD1BB75.9020907@arcor.de \
    --to=stefan.ringel@arcor.de \
    --cc=beehock@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox