From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: "Aguirre, Sergio" <saaguirre@ti.com>
Cc: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH] V4L: Events: Include slab.h explicitly
Date: Tue, 27 Apr 2010 13:09:41 -0300 [thread overview]
Message-ID: <4BD70C45.7030408@redhat.com> (raw)
In-Reply-To: <A24693684029E5489D1D202277BE894454F77AEF@dlee02.ent.ti.com>
Aguirre, Sergio wrote:
> Sakari,
>
> This patch is based on your event branch:
>
> http://gitorious.org/omap3camera/mainline/commits/event
>
> And is required on latest kernel to compile v4l2-event.c, to make use of kmalloc and other slab.h functions/defines.
True.
Sakari,
Please, add this patch on your series before any Makefile entries that would try to compile
the events interface (or just fold it to the patch that added v4l2-event.c).
Cheers,
Mauro.
> Regards,
> Sergio
>
>> -----Original Message-----
>> From: Aguirre, Sergio
>> Sent: Tuesday, April 27, 2010 10:08 AM
>> To: Sakari Ailus
>> Cc: linux-media@vger.kernel.org; Aguirre, Sergio
>> Subject: [PATCH] V4L: Events: Include slab.h explicitly
>>
>> After commit ID:
>>
>> commit de380b55f92986c1a84198149cb71b7228d15fbd
>> Author: Tejun Heo <tj@kernel.org>
>> Date: Wed Mar 24 17:06:43 2010 +0900
>>
>> percpu: don't implicitly include slab.h from percpu.h
>>
>> slab.h include was not longer implicitly included with sched.h.
>>
>> So, now we have to include slab.h explicitly.
>>
>> Signed-off-by: Sergio Aguirre <saaguirre@ti.com>
>> ---
>> drivers/media/video/v4l2-event.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/media/video/v4l2-event.c b/drivers/media/video/v4l2-
>> event.c
>> index aea4332..7f31cd2 100644
>> --- a/drivers/media/video/v4l2-event.c
>> +++ b/drivers/media/video/v4l2-event.c
>> @@ -26,6 +26,7 @@
>> #include <media/v4l2-fh.h>
>> #include <media/v4l2-event.h>
>>
>> +#include <linux/slab.h>
>> #include <linux/sched.h>
>>
>> int v4l2_event_init(struct v4l2_fh *fh)
>> --
>> 1.6.3.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Cheers,
Mauro
next prev parent reply other threads:[~2010-04-27 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 15:08 [PATCH] V4L: Events: Include slab.h explicitly Sergio Aguirre
2010-04-27 15:08 ` Aguirre, Sergio
2010-04-27 16:09 ` Mauro Carvalho Chehab [this message]
2010-04-27 16:16 ` Sakari Ailus
2010-04-27 16:30 ` Mauro Carvalho Chehab
2010-04-27 20:23 ` Sakari Ailus
2010-04-28 14:27 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD70C45.7030408@redhat.com \
--to=mchehab@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=saaguirre@ti.com \
--cc=sakari.ailus@maxwell.research.nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox