Re: [hg:v4l-dvb] Add FE_CAN_PSK_8 to allow apps to identify PSK_8 capable DVB devices

Re: [hg:v4l-dvb] Add FE_CAN_PSK_8 to allow apps to identify PSK_8 capable DVB devices

[Klaus Schmidinger]

On 10.05.2010 06:40, Patch from Klaus Schmidinger wrote:
> The patch number 14692 was added via Douglas Schilling Landgraf <dougsland@redhat.com>
> to http://linuxtv.org/hg/v4l-dvb master development tree.
> 
> Kernel patches in this development tree may be modified to be backward
> compatible with older kernels. Compatibility modifications will be
> removed before inclusion into the mainstream Kernel
> 
> If anyone has any objections, please let us know by sending a message to:
> 	Linux Media Mailing List <linux-media@vger.kernel.org>

This patch should not have been applied, as was decided in
the original thread.

I'm still waiting for any response to my new patch, posted in

  "[PATCH] Add FE_CAN_TURBO_FEC (was: Add FE_CAN_PSK_8 to allow apps to identify PSK_8 capable DVB devices)"

which replaces my original suggestion.

Klaus

> ------
> 
> From: Klaus Schmidinger  <Klaus.Schmidinger@tvdr.de>
> Add FE_CAN_PSK_8 to allow apps to identify PSK_8 capable DVB devices
> 
> 
> The enum fe_caps provides flags that allow an application to detect
> whether a device is capable of handling various modulation types etc.
> A flag for detecting PSK_8, however, is missing.
> This patch adds the flag FE_CAN_PSK_8 to frontend.h and implements
> it for the gp8psk-fe.c and cx24116.c driver (apparently the only ones
> with PSK_8). Only the gp8psk-fe.c has been explicitly tested, though.
> 
> Priority: normal
> 
> Signed-off-by: Klaus Schmidinger <Klaus.Schmidinger@tvdr.de>
> Tested-by: Derek Kelly <user.vdr@gmail.com>
> Acked-by: Manu Abraham <manu@linuxtv.org>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
> 
> 
> ---
> 
>  linux/drivers/media/dvb/dvb-usb/gp8psk-fe.c |    2 +-
>  linux/drivers/media/dvb/frontends/cx24116.c |    2 +-
>  linux/include/linux/dvb/frontend.h          |    1 +
>  3 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff -r 31df1af24206 -r 0eabd1e76386 linux/drivers/media/dvb/dvb-usb/gp8psk-fe.c
> --- a/linux/drivers/media/dvb/dvb-usb/gp8psk-fe.c	Mon May 10 01:31:11 2010 -0300
> +++ b/linux/drivers/media/dvb/dvb-usb/gp8psk-fe.c	Mon May 10 01:32:52 2010 -0300
> @@ -349,7 +349,7 @@
>  			 * FE_CAN_QAM_16 is for compatibility
>  			 * (Myth incorrectly detects Turbo-QPSK as plain QAM-16)
>  			 */
> -			FE_CAN_QPSK | FE_CAN_QAM_16
> +		       FE_CAN_QPSK | FE_CAN_QAM_16 | FE_CAN_PSK_8
>  	},
>  
>  	.release = gp8psk_fe_release,
> diff -r 31df1af24206 -r 0eabd1e76386 linux/drivers/media/dvb/frontends/cx24116.c
> --- a/linux/drivers/media/dvb/frontends/cx24116.c	Mon May 10 01:31:11 2010 -0300
> +++ b/linux/drivers/media/dvb/frontends/cx24116.c	Mon May 10 01:32:52 2010 -0300
> @@ -1496,7 +1496,7 @@
>  			FE_CAN_FEC_4_5 | FE_CAN_FEC_5_6 | FE_CAN_FEC_6_7 |
>  			FE_CAN_FEC_7_8 | FE_CAN_FEC_AUTO |
>  			FE_CAN_2G_MODULATION |
> -			FE_CAN_QPSK | FE_CAN_RECOVER
> +		       FE_CAN_QPSK | FE_CAN_RECOVER | FE_CAN_PSK_8
>  	},
>  
>  	.release = cx24116_release,
> diff -r 31df1af24206 -r 0eabd1e76386 linux/include/linux/dvb/frontend.h
> --- a/linux/include/linux/dvb/frontend.h	Mon May 10 01:31:11 2010 -0300
> +++ b/linux/include/linux/dvb/frontend.h	Mon May 10 01:32:52 2010 -0300
> @@ -62,6 +62,7 @@
>  	FE_CAN_8VSB			= 0x200000,
>  	FE_CAN_16VSB			= 0x400000,
>  	FE_HAS_EXTENDED_CAPS		= 0x800000,   /* We need more bitspace for newer APIs, indicate this. */
> +       FE_CAN_PSK_8                    = 0x8000000,  /* frontend supports "8psk modulation" */
>  	FE_CAN_2G_MODULATION		= 0x10000000, /* frontend supports "2nd generation modulation" (DVB-S2) */
>  	FE_NEEDS_BENDING		= 0x20000000, /* not supported anymore, don't use (frontend requires frequency bending) */
>  	FE_CAN_RECOVER			= 0x40000000, /* frontend can recover from a cable unplug automatically */
> 
> 
> ---
> 
> Patch is available at: http://linuxtv.org/hg/v4l-dvb/rev/0eabd1e76386c37db6cef0a608901d3dd04a301f

Re: [hg:v4l-dvb] Add FE_CAN_PSK_8 to allow apps to identify PSK_8 capable DVB devices

[Mauro Carvalho Chehab]

Klaus Schmidinger wrote:
> On 10.05.2010 06:40, Patch from Klaus Schmidinger wrote:
>> The patch number 14692 was added via Douglas Schilling Landgraf <dougsland@redhat.com>
>> to http://linuxtv.org/hg/v4l-dvb master development tree.
>>
>> Kernel patches in this development tree may be modified to be backward
>> compatible with older kernels. Compatibility modifications will be
>> removed before inclusion into the mainstream Kernel
>>
>> If anyone has any objections, please let us know by sending a message to:
>> 	Linux Media Mailing List <linux-media@vger.kernel.org>
> 
> This patch should not have been applied, as was decided in
> the original thread.

Douglas is synchronizing with git. As the revert patch is a separate patch,
he'll probably apply it later, after finishing sync with -git.

> I'm still waiting for any response to my new patch, posted in
> 
>   "[PATCH] Add FE_CAN_TURBO_FEC (was: Add FE_CAN_PSK_8 to allow apps to identify PSK_8 capable DVB devices)"
> 
> which replaces my original suggestion.

Your new patch is already queued at Patchwork. In order to avoid the risk 
of applying it earlier, I'm waiting for some more acks/comments before 
applying it. If nothing happens, I'll queue it for 2.6.35, since, for me
your new patch is ok.

Cheers,
Mauro

Re: [hg:v4l-dvb] Add FE_CAN_PSK_8 to allow apps to identify PSK_8 capable DVB devices

[Manu Abraham]

On Mon, May 10, 2010 at 9:45 PM, Klaus Schmidinger
<Klaus.Schmidinger@tvdr.de> wrote:
> On 10.05.2010 06:40, Patch from Klaus Schmidinger wrote:
>> The patch number 14692 was added via Douglas Schilling Landgraf <dougsland@redhat.com>
>> to http://linuxtv.org/hg/v4l-dvb master development tree.
>>
>> Kernel patches in this development tree may be modified to be backward
>> compatible with older kernels. Compatibility modifications will be
>> removed before inclusion into the mainstream Kernel
>>
>> If anyone has any objections, please let us know by sending a message to:
>>       Linux Media Mailing List <linux-media@vger.kernel.org>
>
> This patch should not have been applied, as was decided in
> the original thread.
>
> I'm still waiting for any response to my new patch, posted in
>
>  "[PATCH] Add FE_CAN_TURBO_FEC (was: Add FE_CAN_PSK_8 to allow apps to identify PSK_8 capable DVB devices)"
>
> which replaces my original suggestion.

I did a reply but that happened to be on another thread on patchwork,
but here it is again.

Reviewed-by: Manu Abraham <manu <at> linuxtv.org>
Acked-by: Manu Abraham <manu <at> linuxtv.org>

Re: [hg:v4l-dvb] Add FE_CAN_PSK_8 to allow apps to identify PSK_8 capable DVB devices

[Douglas Schilling Landgraf]

Hello Klaus,

On Mon, May 10, 2010 at 2:45 PM, Klaus Schmidinger
<Klaus.Schmidinger@tvdr.de> wrote:
> On 10.05.2010 06:40, Patch from Klaus Schmidinger wrote:
>> The patch number 14692 was added via Douglas Schilling Landgraf <dougsland@redhat.com>
>> to http://linuxtv.org/hg/v4l-dvb master development tree.
>>
>> Kernel patches in this development tree may be modified to be backward
>> compatible with older kernels. Compatibility modifications will be
>> removed before inclusion into the mainstream Kernel
>>
>> If anyone has any objections, please let us know by sending a message to:
>>       Linux Media Mailing List <linux-media@vger.kernel.org>
>
> This patch should not have been applied, as was decided in
> the original thread.

The patch was reverted yesterday during the hg - git sync.
http://linuxtv.org/hg/v4l-dvb/rev/9b6b81d5efbd

Thanks
Douglas