From: Antti Palosaari <crope@iki.fi>
To: matthieu castet <castet.matthieu@free.fr>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] af9015 : more robust eeprom parsing
Date: Fri, 14 May 2010 00:28:35 +0300 [thread overview]
Message-ID: <4BEC6F03.4000403@iki.fi> (raw)
In-Reply-To: <4BA5FFA5.7030800@free.fr>
Terve!
And sorry I have been "out of the office" for few months... Now I am
back and I think I have again time for this project...
On 03/21/2010 01:14 PM, matthieu castet wrote:
> the af9015 eeprom parsing accept 0x38 as 2nd demodulator. But this is
> impossible because the
> first one is already hardcoded to 0x38.
> This remove a special case for AverMedia AVerTV Volar Black HD.
I don't like this. It adds one more rather unnecessary if(). Of course
we can validity check many kind of values from eeprom but I think it is
not rather wise. Just trust eeprom and if there is device which does
have garbage content in eeprom then add special case for that broken
device. Currently AverMedia AVerTV Volar Black HD (A850) is only device
I know which does have bad eeprom content.
> Also in af9015_copy_firmware don't hardcode the 2nd demodulator address
> to 0x3a.
This one looks good.
>
>
> Signed-off-by: Matthieu CASTET <castet.matthieu@free.fr>
regards
Antti
--
http://palosaari.fi/
prev parent reply other threads:[~2010-05-13 21:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 11:14 [PATCH] af9015 : more robust eeprom parsing matthieu castet
2010-05-13 21:28 ` Antti Palosaari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEC6F03.4000403@iki.fi \
--to=crope@iki.fi \
--cc=castet.matthieu@free.fr \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox