From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: post 2.6.34 bug: new code enabled by default
Date: Wed, 26 May 2010 01:12:21 -0300 [thread overview]
Message-ID: <4BFC9FA5.3040201@redhat.com> (raw)
In-Reply-To: <tkrat.872472794cabd92e@s5r6.in-berlin.de>
Stefan Richter wrote:
> $ make oldconfig
> ...
> * Multimedia drivers
> *
> Compile Remote Controller keymap modules (RC_MAP) [M/n/?] (NEW) n
> Enable IR raw decoder for the NEC protocol (IR_NEC_DECODER) [M/n/?] (NEW) n
> Enable IR raw decoder for the RC-5 protocol (IR_RC5_DECODER) [M/n/?] (NEW) n
> Enable IR raw decoder for the RC6 protocol (IR_RC6_DECODER) [M/n/?] (NEW) n
> Enable IR raw decoder for the JVC protocol (IR_JVC_DECODER) [M/n/?] (NEW) n
> Enable IR raw decoder for the Sony protocol (IR_SONY_DECODER) [M/n/?] (NEW) n
>
> Please leave the default of new options at N.
>
> (Unless this were a special case of new options that replaced older
> options and need to be migrated to 'on' per default in make oldconfig.
> I think this is not the case here.)
This is the case here. Before the RC subsystem, the decoding for NEC and RC-5
were done inside ir-core (at ir-functions). Also, all the keymap entries (RC_MAP)
were compiled in-kernel.
The intention is to move the RC_MAP keytables to userspace, by default, but there
are still some work to be done at the userspace application before we can do it.
So, without RC_MAP, IR_NEC_DECODER and IR_RC5_DECODER, the input driver will be
compiled, but the IR support may not actually work, if the board needs IR raw
support.
That's said, the support for RC-6, JVC and Sony protocols (IR_RC6_DECODER,
IR_JVC_DECODER and IR_SONY_DECODER) are new. Yet, even on this case, it may make
sense to keep the default to Y, or to add a logic to auto-select the IR decoder
protocols that are needed in order to support the bundled IR found at the compiled
drivers.
--
Cheers,
Mauro
next prev parent reply other threads:[~2010-05-26 4:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 19:45 post 2.6.34 bug: new code enabled by default Stefan Richter
2010-05-26 4:12 ` Mauro Carvalho Chehab [this message]
2010-05-26 8:03 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BFC9FA5.3040201@redhat.com \
--to=mchehab@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox