post 2.6.34 bug: new code enabled by default

post 2.6.34 bug: new code enabled by default

[Stefan Richter]

$ make oldconfig
...
  * Multimedia drivers
  *
  Compile Remote Controller keymap modules (RC_MAP) [M/n/?] (NEW) n
  Enable IR raw decoder for the NEC protocol (IR_NEC_DECODER) [M/n/?] (NEW) n
  Enable IR raw decoder for the RC-5 protocol (IR_RC5_DECODER) [M/n/?] (NEW) n
  Enable IR raw decoder for the RC6 protocol (IR_RC6_DECODER) [M/n/?] (NEW) n
  Enable IR raw decoder for the JVC protocol (IR_JVC_DECODER) [M/n/?] (NEW) n
  Enable IR raw decoder for the Sony protocol (IR_SONY_DECODER) [M/n/?] (NEW) n

Please leave the default of new options at N.

(Unless this were a special case of new options that replaced older
options and need to be migrated to 'on' per default in make oldconfig.
I think this is not the case here.)
-- 
Stefan Richter
-=====-==-=- -=-= ==--=
http://arcgraph.de/sr/

Re: post 2.6.34 bug: new code enabled by default

[Mauro Carvalho Chehab]

Stefan Richter wrote:
> $ make oldconfig
> ...
>   * Multimedia drivers
>   *
>   Compile Remote Controller keymap modules (RC_MAP) [M/n/?] (NEW) n
>   Enable IR raw decoder for the NEC protocol (IR_NEC_DECODER) [M/n/?] (NEW) n
>   Enable IR raw decoder for the RC-5 protocol (IR_RC5_DECODER) [M/n/?] (NEW) n
>   Enable IR raw decoder for the RC6 protocol (IR_RC6_DECODER) [M/n/?] (NEW) n
>   Enable IR raw decoder for the JVC protocol (IR_JVC_DECODER) [M/n/?] (NEW) n
>   Enable IR raw decoder for the Sony protocol (IR_SONY_DECODER) [M/n/?] (NEW) n
> 
> Please leave the default of new options at N.
> 
> (Unless this were a special case of new options that replaced older
> options and need to be migrated to 'on' per default in make oldconfig.
> I think this is not the case here.)

This is the case here. Before the RC subsystem, the decoding for NEC and RC-5
were done inside ir-core (at ir-functions). Also, all the keymap entries (RC_MAP)
were compiled in-kernel.

The intention is to move the RC_MAP keytables to userspace, by default, but there
are still some work to be done at the userspace application before we can do it.

So, without RC_MAP, IR_NEC_DECODER and IR_RC5_DECODER, the input driver will be 
compiled, but the IR support may not actually work, if the board needs IR raw
support.

That's said, the support for RC-6, JVC and Sony protocols (IR_RC6_DECODER, 
IR_JVC_DECODER and IR_SONY_DECODER) are new. Yet, even on this case, it may make
sense to keep the default to Y, or to add a logic to auto-select the IR decoder 
protocols that are needed in order to support the bundled IR found at the compiled
drivers.

-- 

Cheers,
Mauro

Re: post 2.6.34 bug: new code enabled by default

[Stefan Richter]

Mauro Carvalho Chehab wrote:
> Stefan Richter wrote:
[CONFIG_RC_MAP et al]
>> Please leave the default of new options at N.
>>
>> (Unless this were a special case of new options that replaced older
>> options and need to be migrated to 'on' per default in make oldconfig.
>> I think this is not the case here.)
> 
> This is the case here. Before the RC subsystem, the decoding for NEC and RC-5
> were done inside ir-core (at ir-functions). Also, all the keymap entries (RC_MAP)
> were compiled in-kernel.

OK.  I happened to have a setup in which nothing of this was actually
used before.  (CONFIG_FIREDTV as only DVB tuner driver.)  --- Aha, it is
just a consequence of ir-core being enabled by default regardless if
needed, since 2.6.33:

config IR_CORE
	tristate
	depends on INPUT
	default INPUT
-- 
Stefan Richter
-=====-==-=- -=-= ==-=-
http://arcgraph.de/sr/