From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH RESEND] FusionHDTV: Use quick reads for I2C IR device probing
Date: Fri, 04 Jun 2010 15:44:31 -0300 [thread overview]
Message-ID: <4C09498F.6070909@infradead.org> (raw)
In-Reply-To: <20100604171404.27fe7773@hyperion.delvare>
Em 04-06-2010 12:14, Jean Delvare escreveu:
> Mauro,
>
> On Wed, 26 May 2010 15:05:11 +0200, Jean Delvare wrote:
>> IR support on FusionHDTV cards is broken since kernel 2.6.31. One side
>> effect of the switch to the standard binding model for IR I2C devices
>> was to let i2c-core do the probing instead of the ir-kbd-i2c driver.
>> There is a slight difference between the two probe methods: i2c-core
>> uses 0-byte writes, while the ir-kbd-i2c was using 0-byte reads. As
>> some IR I2C devices only support reads, the new probe method fails to
>> detect them.
>>
>> For now, revert to letting the driver do the probe, using 0-byte
>> reads. In the future, i2c-core will be extended to let callers of
>> i2c_new_probed_device() provide a custom probing function.
>>
>> Signed-off-by: Jean Delvare <khali@linux-fr.org>
>> Tested-by: "Timothy D. Lenz" <tlenz@vorgon.com>
>> ---
>> This fix applies to kernels 2.6.31 to 2.6.34. Should be sent to Linus
>> quickly. I had already sent on March 29th, but apparently it was
>> overlooked. I have further i2c patches which depend on this one, so
>> please process it quickly, otherwise I'll have to push it myself.
>
> This fix is still not upstream! What do I have to do to get it there?
> Please!
Just sent a pull request.
Cheers,
Mauro
prev parent reply other threads:[~2010-06-04 18:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 13:05 [PATCH RESEND] FusionHDTV: Use quick reads for I2C IR device probing Jean Delvare
2010-06-04 15:14 ` Jean Delvare
2010-06-04 18:44 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C09498F.6070909@infradead.org \
--to=mchehab@infradead.org \
--cc=khali@linux-fr.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).