From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:48955 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750739Ab0FHEAl (ORCPT ); Tue, 8 Jun 2010 00:00:41 -0400 Message-ID: <4C0DC04E.5000600@infradead.org> Date: Tue, 08 Jun 2010 01:00:14 -0300 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: Jonathan Corbet CC: Laurent Pinchart , linux-media@vger.kernel.org, Florian Tobias Schandinat Subject: Re: [PATCH] Add the viafb video capture driver References: <20100607172615.311edce9@bike.lwn.net> <201006080303.14784.laurent.pinchart@ideasonboard.com> <20100607203158.4ec59ab1@bike.lwn.net> In-Reply-To: <20100607203158.4ec59ab1@bike.lwn.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em 07-06-2010 23:31, Jonathan Corbet escreveu: > On Tue, 8 Jun 2010 03:03:14 +0200 > Laurent Pinchart wrote: > >> If it's not too late for review, here are some comments. I've reviewed the >> code from bottom to top, so comments might be a bit inconsistent sometimes. > > Never too late to make the code better. These are good comments, thanks. > Mauro, I guess I've got another version coming...:) Ok, I'll be waiting for it ;) Cheers, Mauro