Linux Media Controller development
 help / color / mirror / Atom feed
From: Marko Ristola <marko.ristola@kolumbus.fi>
To: linux-media@vger.kernel.org
Cc: Oliver Endriss <o.endriss@gmx.de>,
	Jaroslav Klaus <jaroslav.klaus@gmail.com>
Subject: Re: TS discontinuity with TT S-2300
Date: Sun, 27 Jun 2010 23:51:25 +0300	[thread overview]
Message-ID: <4C27B9CD.4070404@kolumbus.fi> (raw)
In-Reply-To: <201006272025.39822@orion.escape-edv.de>

27.06.2010 21:25, Oliver Endriss wrote:
> Are you sure that Mantis driver delivers garbage, not partial packets?
> Please note that the dvb_dmx_swfilter[_204]() routines must accept
> partial packets, i.e. the rest of the packet will be dellivered with the
> next call.
>   
Yes, I'm sure that the garbage comes from the PCI device itself:
garbage should be found at less than 204 byte position otherwise.

My latest mailed patch that I use makes sure 0x47 is found at
demux->tsbufp[0],
if there is at least one spared byte. Otherwise the resulting 188 sized
packet would be discarded eventually.

It would be good if Mauro would accept my patch for dvb_dmx_swfilter(_204)
functions some day. It increases robustness with garbage input, and
performance by avoiding unnecessary packet copying.

> dvb_dmx_swfilter_packets() expects complete TS packets from the driver.
> The saa7146 does so. It does not deliver garbage data. (Otherwise this
> would have been noticed a long time ago. The ttpci drivers are the
> oldest DVB drivers and are very well tested.)
>   
I'm very sorry I even questioned ttpci's and the hardware's robustness.

I'm delighted to hear that ttpci is so well implemented and tested and
so long :)
I was very impressed in the quality of the code with
dvb_dmx_swfilter_packets():
so simple and efficient.

Unfortunately I have had lots of problems with Mantis.
But because of that, I've learned DVB driver programming.

H.264 works now mostly in one TV channel without crashing Xine with
remote vdr.
I had to modify streamdev plugin too for vdr.

CU
Marko


      reply	other threads:[~2010-06-27 20:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-26 23:05 TS discontinuity with TT S-2300 Jaroslav Klaus
2010-06-27 12:37 ` Oliver Endriss
2010-06-27 15:23   ` Jaroslav Klaus
2010-06-27 15:56   ` Marko Ristola
2010-06-27 18:25     ` Oliver Endriss
2010-06-27 20:51       ` Marko Ristola [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C27B9CD.4070404@kolumbus.fi \
    --to=marko.ristola@kolumbus.fi \
    --cc=jaroslav.klaus@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=o.endriss@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox