From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Palash Bandyopadhyay <Palash.Bandyopadhyay@conexant.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Jay Guillory <Jay.Guillory@conexant.com>
Subject: Re: [cx25821] Removed duplicate code and cleaned up
Date: Mon, 05 Jul 2010 02:26:36 -0300 [thread overview]
Message-ID: <4C316D0C.6070707@redhat.com> (raw)
In-Reply-To: <34B38BE41EDBA046A4AFBB591FA31132F4B404@NBMBX01.bbnet.ad>
Em 10-06-2010 01:27, Palash Bandyopadhyay escreveu:
> From 58fd4cad5f6acbe16bff86b8e878d2352cc73637 Mon Sep 17 00:00:00 2001
> Message-Id: <58fd4cad5f6acbe16bff86b8e878d2352cc73637.1276143362.git.palash.bandyopadhyay@conexant.com>
> From: palash <palash.bandyopadhyay@conexant.com>
> Date: Wed, 9 Jun 2010 21:11:20 -0700
> Subject: [cx25821] Removed duplicate code and cleaned up
> To: linux-media@vger.kernel.org
>
> Signed-off-by: palash <palash.bandyopadhyay@conexant.com>
>
> delete mode 100644 drivers/staging/cx25821/cx25821-audups11.c
> delete mode 100644 drivers/staging/cx25821/cx25821-video0.c
> delete mode 100644 drivers/staging/cx25821/cx25821-video1.c
> delete mode 100644 drivers/staging/cx25821/cx25821-video2.c
> delete mode 100644 drivers/staging/cx25821/cx25821-video3.c
> delete mode 100644 drivers/staging/cx25821/cx25821-video4.c
> delete mode 100644 drivers/staging/cx25821/cx25821-video5.c
> delete mode 100644 drivers/staging/cx25821/cx25821-video6.c
> delete mode 100644 drivers/staging/cx25821/cx25821-video7.c
> delete mode 100644 drivers/staging/cx25821/cx25821-videoioctl.c
> delete mode 100644 drivers/staging/cx25821/cx25821-vidups10.c
> delete mode 100644 drivers/staging/cx25821/cx25821-vidups9.c
Hi Palash,
I've applied your patch at "staging/other" branch, and added there a few patches to cleanup
some troubles I saw on the driver. I was wanting to move it out of staging, but, unfortunately,
the driver is not ready yet.
One of the bad things I saw on the driver is this part:
$ grep /root/ drivers/staging/cx25821/*
drivers/staging/cx25821/cx25821-audio-upstream.c: dev->_audiofilename = "/root/audioGOOD.wav";
drivers/staging/cx25821/cx25821-audio-upstream.h:char *_defaultAudioName = "/root/audioGOOD.wav";
drivers/staging/cx25821/cx25821-video-upstream.c: PIXEL_FRMT_411) ? "/root/vid411.yuv" :
drivers/staging/cx25821/cx25821-video-upstream.c: "/root/vidtest.yuv";
drivers/staging/cx25821/cx25821-video-upstream.c: PIXEL_FRMT_411) ? "/root/pal411.yuv" :
drivers/staging/cx25821/cx25821-video-upstream.c: "/root/pal422.yuv";
drivers/staging/cx25821/cx25821-video-upstream-ch2.c: PIXEL_FRMT_411) ? "/root/vid411.yuv" :
drivers/staging/cx25821/cx25821-video-upstream-ch2.c: "/root/vidtest.yuv";
drivers/staging/cx25821/cx25821-video-upstream-ch2.c: PIXEL_FRMT_411) ? "/root/pal411.yuv" :
drivers/staging/cx25821/cx25821-video-upstream-ch2.c: "/root/pal422.yuv";
The driver should not get any file name from userspace, not should read directly to any file.
Instead, it should be using V4L2 and ALSA API's for any kind of streams. Please fix it.
Cheers,
Mauro.
next prev parent reply other threads:[~2010-07-05 5:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-10 4:25 [cx231xx 1/2] Added support for s5h1432 demod Palash Bandyopadhyay
2010-06-10 4:27 ` [cx25821] Removed duplicate code and cleaned up Palash Bandyopadhyay
2010-07-05 5:26 ` Mauro Carvalho Chehab [this message]
2010-07-05 6:49 ` Palash Bandyopadhyay
2010-07-05 14:34 ` Mauro Carvalho Chehab
2010-07-05 22:29 ` [cx231xx 1/2] Added support for s5h1432 demod Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C316D0C.6070707@redhat.com \
--to=mchehab@redhat.com \
--cc=Jay.Guillory@conexant.com \
--cc=Palash.Bandyopadhyay@conexant.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).