From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Dmitri Belimov <d.belimov@gmail.com>
Cc: Devin Heitmueller <dheitmueller@kernellabs.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Stefan Ringel <stefan.ringel@arcor.de>,
Bee Hock Goh <beehock@gmail.com>
Subject: Re: [PATCH] xc5000, rework xc_write_reg
Date: Mon, 05 Jul 2010 13:11:56 -0300 [thread overview]
Message-ID: <4C32044C.3060007@redhat.com> (raw)
In-Reply-To: <20100525114939.067404eb@glory.loctelecom.ru>
Em 24-05-2010 22:49, Dmitri Belimov escreveu:
> Hi Devin
>
>> On Tue, May 18, 2010 at 3:30 AM, Dmitri Belimov <d.belimov@gmail.com>
>> wrote:
>>> Hi
>>>
>>> Rework xc_write_reg function for correct read register of the
>>> xc5000. It is very useful for tm6000.
>>>
>>> Tested for tm6000 and for saa7134 works well.
>>
>> Hi Dmitri,
>>
>> I've put this on my list of patches to review. My concern is that the
>> xc_wait logic is pretty nasty since it's related to timing of the bus
>> (it took several weeks as well as a dozen emails with the people at
>> Xceive), and hence I am loathed to change it since it took quite a bit
>> of time to test against all the different cards that use xc5000 (and
>> in some cases there were bugs exposed in various bridge's i2c
>> implementations).
>>
>> That said, I think I actually did attempt to implement a patch
>> comparable to what you did here, but I backed it out for some reason.
>> I will need to review my trees and my notes to see what the rationale
>> was for doing such.
>
> Ok. I can test your solution on our hardware.
> XC5000+SAA7134
> XC5000+TM6010
Devin/Dmitri,
Any progress about this patch?
Cheers,
Mauro
next prev parent reply other threads:[~2010-07-05 16:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 7:30 [PATCH] xc5000, rework xc_write_reg Dmitri Belimov
2010-05-24 2:38 ` Devin Heitmueller
2010-05-25 1:49 ` Dmitri Belimov
2010-07-05 16:11 ` Mauro Carvalho Chehab [this message]
2010-07-05 19:07 ` Devin Heitmueller
2010-10-06 19:52 ` xc5000 and switch RF input Dmitri Belimov
2010-10-06 12:25 ` Mauro Carvalho Chehab
2010-10-06 12:40 ` [RFC] Resource reservation for frontend - Was: " Mauro Carvalho Chehab
2010-10-07 13:00 ` Dmitri Belimov
2010-10-07 0:28 ` Mauro Carvalho Chehab
2010-10-12 18:32 ` Dmitri Belimov
2010-10-14 8:33 ` Antti Palosaari
2010-10-14 8:41 ` Devin Heitmueller
2010-10-15 15:33 ` Antti Palosaari
2010-10-13 21:30 ` [PATCH] " Dmitri Belimov
2010-10-14 0:50 ` Devin Heitmueller
2010-10-14 16:12 ` Dmitri Belimov
2010-10-14 19:27 ` hermann pitton
2010-10-26 3:31 ` [PATCH] saa7134 behold A7 and H7 Dmitri Belimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C32044C.3060007@redhat.com \
--to=mchehab@redhat.com \
--cc=beehock@gmail.com \
--cc=d.belimov@gmail.com \
--cc=dheitmueller@kernellabs.com \
--cc=linux-media@vger.kernel.org \
--cc=stefan.ringel@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox