Re: [RFC/PATCH v2 7/7] v4l: subdev: Generic ioctl support

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 10-07-2010 13:31, Hans Verkuil escreveu:
> On Saturday 10 July 2010 16:08:46 Mauro Carvalho Chehab wrote:
>> Em 09-07-2010 12:31, Laurent Pinchart escreveu:

>> Hmm... private ioctls at subdev... I'm not sure if I like this idea. I prefer to merge this patch
>> only after having a driver actually needing it, after discussing why not using a standard ioctl
>> for that driver.
> 
> Part of the reason for making these subdev device nodes is to actually allow
> private ioctls (after properly discussing it and with documentation). SoCs tend
> to have a lot of very hardware specific features that do not translate to generic
> ioctls. Until now these are either ignored or handled through custom drivers, but
> but it is much better to handle them in a 'controlled' fashion.

I understand that SoC's may have lots of features that are currently not being exposed,
but if they'll be either be shown as CTRL or as new ioctls need further discussions. That's
why I prefer to receive this patch in a patch series where such needed is required.

Cheers,
Mauro.