Re: cx23885: Unknown symbol __ir_input_register

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 25-07-2010 10:22, Andy Walls escreveu:
> On Sun, 2010-07-25 at 08:44 -0400, Andy Walls wrote:
>> On Sat, 2010-07-24 at 18:45 +0200, vvvl@onet.pl wrote:
>>> with linux-2.6.34-gentoo-r1 and V4L/DVB repository of July 24 I get these errors:
>>> cx23885: Unknown symbol __ir_input_register
>>> cx23885: Unknown symbol get_rc_map
>>
>> Those are IR related.
>>
>> I forgot to add "IR_CORE" to the Kconfig file for the cx23885 driver,
>> but the the "VIDEO_IR" selection in that Kconfig depends on "IR_CORE",
>> so I think that should be OK.
> 
> Hmmm...
> 
> "select VIDEO_IR" in the cx23885 Kconfig doesn't revisit the
> dependencies on "IR_CORE" and "INPUT".
> 
> 
> Mauro,
> 
> What's the correct thing to do here?
> 
> Change it to
> 
> 	"depends VIDEO_IR"
> 
> or add
> 
> 	"depends IR_CORE"
> 
> or add
> 
> 	"select INPUT"
> 	"select IR_CORE"
> 
> 
> The first is easiet to maintain, but might have something built
> in-kernel vs. module in the wrong order.
> 
> The second repeats a known dependency, expressed elsewhere, which will
> have to be kept in sync (and could still get the build wrong).
> 
> The third repeats more known dependencies, expressed elsewhere, which
> will have to be kept in sync, but at least the build should always have
> the right components built in-kernel.
> 
> 
> Or do I misunderstand the select & depends keywords?

IMHO, we need to re-work at the IR dependencies. The better is to not use
"select". The proper solution seems to re-work on the existing drivers to allow
them to work with IR disabled via Kconfig.

So, if IR support were compiled, it will enable the *-input. Otherwise, the driver
will keep compiling, but without IR.

Cheers,
Mauro.