Re: V4L hg tree fails to compile against kernel 2.6.28

[Jan Hoogenraad <jan-conceptronic@hoogenraad.net>]

Thanks for your help. I pulled the code

Actually, now the function definition in compat.h causes a compilation 
error: see first text below.

I fixed that by inserting
#include <linux/err.h>
at line 38 in compat.h in my local branch

After that, compilation succeeds.

Now, the device will not install, as dvb_usb cannot install anymore.
see second text below.

Therefore, I have replaced the __kmalloc_track_caller with kmalloc (as 
it was in dvb_demux.c before the change 2ceef3d75547 at line 49

can you make both changes in the hg branch ?
-----

make[2]: Entering directory `/usr/src/linux-headers-2.6.28-19-generic'
   CC [M]  tuner-xc2028.o
In file included from tuner-xc2028.c:19:
compat.h: In function 'memdup_user':
compat.h:50: error: implicit declaration of function 'ERR_PTR'
compat.h:50: warning: return makes pointer from integer without a cast
compat.h:54: warning: return makes pointer from integer without a cast
In file included from include/linux/fs.h:1891,
                  from include/linux/poll.h:11,
                  from dvbdev.h:27,
                  from dvb_frontend.h:43,
                  from tuner-xc2028.h:10,
                  from tuner-xc2028.c:22:
include/linux/err.h: At top level:
include/linux/err.h:22: error: conflicting types for 'ERR_PTR'
----
sudo modprobe dvb-usb-rtl2831u ir_protocol=2
WARNING: Error inserting dvb_usb 
(/lib/modules/2.6.28-19-generic/kernel/drivers/media/dvb/dvb-usb/dvb-usb.ko): 
Unknown symbol in module, or unknown parameter (see dmesg)
WARNING: Error inserting dvb_usb_dibusb_common 
(/lib/modules/2.6.28-19-generic/kernel/drivers/media/dvb/dvb-usb/dvb-usb-dibusb-common.ko): 
Unknown symbol in module, or unknown parameter (see dmesg)
FATAL: Error inserting dvb_usb_rtl2831u 
(/lib/modules/2.6.28-19-generic/kernel/drivers/media/dvb/rtl2831/dvb-usb-rtl2831u.ko): 
Unknown symbol in module, or unknown parameter (see dmesg)

in the system log, I find:

dvb_core: Unknown symbol __kmalloc_track_caller
dvb_core: Unknown symbol __kmalloc_track_caller




Douglas Schilling Landgraf wrote:
> Hello Jan,
> 
> On Tue, Aug 24, 2010 at 5:04 PM, Jan Hoogenraad
> <jan-conceptronic@hoogenraad.net> wrote:
>> Douglas:
>>
>> On compiling with  Linux  2.6.28-19-generic #62-Ubuntu
>>
>> I now get:
>>
>> dvb_demux.c: In function 'dvbdmx_write':
>> dvb_demux.c:1137: error: implicit declaration of function 'memdup_user'
>> dvb_demux.c:1137: warning: assignment makes pointer from integer without a
>> cast
>>
>> This is probably due to changeset 2ceef3d75547
>>
>> which introduced the use of this function:
>> http://linuxtv.org/hg/v4l-dvb/diff/2ceef3d75547/linux/drivers/media/dvb/dvb-core/dvb_demux.c
>>
>> This function is not available in linux/string.h in kernel 2.6.29 and lower.
>>
>> http://lxr.free-electrons.com/source/include/linux/string.h?v=2.6.28
>>
>> Could you please advise me on what to do ?
> 
> For this issue, I have fixed right now, please try again with a
> updated repository. But since I have commited several patches
> yesterday,
> we have another one that probably will reach your compilantion (the
> kfifo one). I will work to fix this one too.
> 
> Thanks for the report.
> 
> Cheers
> Douglas
> 


-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht