public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Hoogenraad <jan-conceptronic@hoogenraad.net>
To: linux-media@vger.kernel.org,
	Douglas Schilling Landgraf <dougsland@gmail.com>
Cc: Thomas Holzeisen <thomas@holzeisen.de>
Subject: HG has errors on kernel 2.6.32
Date: Thu, 26 Aug 2010 21:54:10 +0200	[thread overview]
Message-ID: <4C76C662.3070003@hoogenraad.net> (raw)
In-Reply-To: <4C768B43.9080403@holzeisen.de>

Douglas:

I see on that
http://www.xs4all.nl/~hverkuil/logs/Thursday.log
that building linux-2.6.32 yields ERRORS

skip_spaces has only been included in string.h starting from linux-2.6.33.

Should I have a look on how to fix this, or do you want to do this ?

--

second request: can we do some small changes to avoid the compiler 
warnings ?

include the line
         rc=0;
at line 187 of linux/drivers/media/IR/ir-raw-event.c


and change
static  void jpeg_set_qual(u8 *jpeg_hdr,
into
static __attribute__ (( unused )) void jpeg_set_qual(u8 *jpeg_hdr,

at line 152 of linux/drivers/media/video/gspca/jpeg.h

Yours,
		Jan

Thomas Holzeisen wrote:
> Hi Jan,
> 
> this looks great. At first the checkout did not build throwing me this 
> error:
> 
>> /usr/src/rtl2831-r2/v4l/ir-sysfs.c: In function 'store_protocols':
>> /usr/src/rtl2831-r2/v4l/ir-sysfs.c:137: error: implicit declaration of 
>> function 'skip_spaces'
>> /usr/src/rtl2831-r2/v4l/ir-sysfs.c:137: warning: assignment makes 
>> pointer from integer without a cast
>> /usr/src/rtl2831-r2/v4l/ir-sysfs.c:178: warning: assignment makes 
>> pointer from integer without a cast
> 
> i replaced the file by an older version from a previous checkout and 
> then it build perfectly. It also gets initialized without a flaw:
> 


-- 
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht

  reply	other threads:[~2010-08-26 19:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-19 18:53 dvb_usb_rtl2831u module cause "oops" on kernel 2.6.32 when loading Thomas Holzeisen
2010-06-24 14:55 ` Help wanted on removing dibusb_rc_keys from dvb_usb_rtl2831u module Jan Hoogenraad
2010-08-06  5:43   ` Jan Hoogenraad
2010-08-06  5:45 ` dvb_usb_rtl2831u module cause "oops" on kernel 2.6.32 when loading Jan Hoogenraad
2010-08-13 11:42   ` thomas
2010-08-26  6:46     ` Jan Hoogenraad
2010-08-26 15:41       ` Thomas Holzeisen
2010-08-26 19:54         ` Jan Hoogenraad [this message]
2010-08-27  6:01           ` HG has errors on kernel 2.6.32 Douglas Schilling Landgraf
2010-08-27  6:25             ` Jan Hoogenraad
2010-08-28  7:46           ` Jean-Francois Moine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C76C662.3070003@hoogenraad.net \
    --to=jan-conceptronic@hoogenraad.net \
    --cc=dougsland@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=thomas@holzeisen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox