From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:64423 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785Ab0IENtM (ORCPT ); Sun, 5 Sep 2010 09:49:12 -0400 Message-ID: <4C83A12F.1070009@redhat.com> Date: Sun, 05 Sep 2010 15:54:55 +0200 From: Hans de Goede MIME-Version: 1.0 To: Jean-Francois Moine CC: linux-media@vger.kernel.org Subject: Re: [PATCH] LED control References: <20100904131048.6ca207d1@tele> <4C834D46.5030801@redhat.com> <20100905105627.0d5d3dab@tele> In-Reply-To: <20100905105627.0d5d3dab@tele> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-ID: Sender: Mauro Carvalho Chehab Hi, On 09/05/2010 10:56 AM, Jean-Francois Moine wrote: > On Sun, 05 Sep 2010 09:56:54 +0200 > Hans de Goede wrote: > >> I think that using one control for both status leds (which is what we >> are usually talking about) and illuminator(s) is a bad idea. I'm fine >> with standardizing these, but can we please have 2 CID's one for >> status lights and one for the led. Esp, as I can easily see us >> supporting a microscope in the future where the microscope itself or >> other devices with the same bridge will have a status led, so then we >> will need 2 separate controls anyways. > > Hi Hans, > > I was not thinking about the status light (I do not see any other usage > for it), but well about illuminators which I saw only in microscopes. > Ah, ok thanks for clarifying. For some more on this see p.s. below. > So, which is the better name? V4L2_CID_LAMPS? V4L2_CID_ILLUMINATORS? I think that V4L2_CID_ILLUMINATORS together with a comment in the .h and explanation in the spec that this specifically applies to microscopes would be good. Regards, Hans p.s. I think it would be good to have a V4L2_CID_STATUS_LED too. In many drivers we are explicitly controlling the led by register writes. Some people may very well prefer the led to always be off. I know that uvc logitech cameras have controls for the status led through the extended uvc controls. Once we have a standardized LED control, we can move the logitech uvc cams over from using their own private one to this one. Once this is in place I would like to build some framework in to gspca for supporting this control in gspca (the control would be handled by the core, and sub drivers would have an sd_set_led function). While at it could you write a proposal / patch for adding this control to the spec as well ?