From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Antti Palosaari <crope@iki.fi>
Cc: Stefan Lippers-Hollmann <s.l-h@gmx.de>,
linux-media@vger.kernel.org, TerraTux <terratux@terratec.de>,
Patrick Boettcher <patrick.boettcher@desy.de>
Subject: Re: [GIT PULL FOR 2.6.37] new AF9015 devices
Date: Wed, 22 Sep 2010 16:02:48 -0300 [thread overview]
Message-ID: <4C9A52D8.1090402@redhat.com> (raw)
In-Reply-To: <4C894DB8.8080908@iki.fi>
Em 09-09-2010 18:12, Antti Palosaari escreveu:
> Moikka Mauro!
> This patch series adds support for TerraTec Cinergy T Stick Dual RC and TerraTec Cinergy T Stick RC. Also MxL5007T devices with ref. design IDs should be working. Cinergy T Stick remote is most likely not working since it seems to use different remote as Cinergy T Dual... Stefan could you test and ensure T Stick is working?
>
> and thanks to TerraTec!
>
> t. Antti
>
>
> The following changes since commit c9889354c6d36d6278ed851c74ace02d72efdd59:
>
> V4L/DVB: rc-core: increase repeat time (2010-09-08 13:04:40 -0300)
>
> are available in the git repository at:
> git://linuxtv.org/anttip/media_tree.git af9015
>
> Antti Palosaari (6):
> af9015: simple comment update
Hmm... dvb-usb.h defines it as:
struct dvb_usb_device_description devices[12];
It took me some time to find the current limit ;)
IMO, instead of just comment it as:
.num_device_descs = 9, /* check max from dvb-usb.h */
The better would be to add a definition at dvb-usb.h header for the max limit, and properly pointing it
on your drivers, like:
on dvb-usb.h:
#define MAX_DEVICES_PER_DEV_PROPS 12
...
struct dvb_usb_device_description devices[MAX_DEVICES_PER_DEV_PROPS];
on af9015 (and others):
.num_device_descs = 9, /* max is MAX_DEVICES_PER_DEV_PROPS as defined on dvb-usb.h */
I'll apply this patch to avoid breaking your series, but please provide me a fix.
> af9015: fix bug introduced by commit 490ade7e3f4474f626a8f5d778ead4e599b94fbcas
> af9013: add support for MaxLinear MxL5007T tuner
> af9015: add support for TerraTec Cinergy T Stick Dual RC
> af9015: add remote support for TerraTec Cinergy T Stick Dual RC
> af9015: map TerraTec Cinergy T Stick Dual RC remote to device ID
>
> drivers/media/dvb/dvb-usb/Kconfig | 1 +
> drivers/media/dvb/dvb-usb/af9015.c | 50 +++++++++++++----------
> drivers/media/dvb/dvb-usb/af9015.h | 63 +++++++++++++++++++++++++++++
> drivers/media/dvb/dvb-usb/dvb-usb-ids.h | 1 +
> drivers/media/dvb/frontends/af9013.c | 1 +
> drivers/media/dvb/frontends/af9013.h | 1 +
> drivers/media/dvb/frontends/af9013_priv.h | 5 +-
> 7 files changed, 99 insertions(+), 23 deletions(-)
>
>
Cheers,
Mauro
prev parent reply other threads:[~2010-09-22 19:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 21:12 [GIT PULL FOR 2.6.37] new AF9015 devices Antti Palosaari
2010-09-09 23:19 ` Stefan Lippers-Hollmann
2010-09-10 0:54 ` Stefan Lippers-Hollmann
2010-09-10 10:12 ` Antti Palosaari
2010-09-10 11:47 ` Stefan Lippers-Hollmann
2010-09-22 19:02 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C9A52D8.1090402@redhat.com \
--to=mchehab@redhat.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=patrick.boettcher@desy.de \
--cc=s.l-h@gmx.de \
--cc=terratux@terratec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).