[PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Yann E. MORIN]

Hello All!

This patch adds support for The AverMedia AVerTV Red HD+ (aka A850T)
DVB-T USB stick, available (exclusively?) on the french market.

checkpatch.pl warns about two lines that are longer then 80 chars, but
I am not sure how to split them and still keep readable code. Suggestions
welcome. ;-)

The patch is based off Mauro's linux-2.6 tree on git.kernel.org. On the
WiKi, there are references to the Hg tree on some pages, and references
to the git tree on other pages. The trees differ from each others, and
the git tree seemed more up-to-date wrt af9015. So I choosed the git tree.
If needed, I can rebase ontop the Hg tree.

Regards,
Yann E. MORIN.

[PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Yann E. MORIN]

The AVerTV Red HD+ (A850T) is basically the same as the existing
AVerTV Volar Black HD 9A850), but is specific to the french market.

This is a collection of information gathered from the french support
forums for Ubuntu, which I tried to properly format:
  http://forum.ubuntu-fr.org/viewtopic.php?pid=3322825

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
---
 drivers/media/dvb/dvb-usb/af9015.c      |   12 ++++++++----
 drivers/media/dvb/dvb-usb/dvb-usb-ids.h |    1 +
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/media/dvb/dvb-usb/af9015.c b/drivers/media/dvb/dvb-usb/af9015.c
index ea1ed3b..17faeb2 100644
--- a/drivers/media/dvb/dvb-usb/af9015.c
+++ b/drivers/media/dvb/dvb-usb/af9015.c
@@ -1020,9 +1020,11 @@ error:
 		err("eeprom read failed:%d", ret);
 
 	/* AverMedia AVerTV Volar Black HD (A850) device have bad EEPROM
-	   content :-( Override some wrong values here. */
+	   content :-( Override some wrong values here. Ditto for the
+	   AVerTV Red HD+ (A850T) device. */
 	if (le16_to_cpu(udev->descriptor.idVendor) == USB_VID_AVERMEDIA &&
-	    le16_to_cpu(udev->descriptor.idProduct) == USB_PID_AVERMEDIA_A850) {
+	    ((le16_to_cpu(udev->descriptor.idProduct) == USB_PID_AVERMEDIA_A850) ||
+	     (le16_to_cpu(udev->descriptor.idProduct) == USB_PID_AVERMEDIA_A850T))) {
 		deb_info("%s: AverMedia A850: overriding config\n", __func__);
 		/* disable dual mode */
 		af9015_config.dual_mode = 0;
@@ -1300,6 +1302,7 @@ static struct usb_device_id af9015_usb_table[] = {
 /* 30 */{USB_DEVICE(USB_VID_KWORLD_2,  USB_PID_KWORLD_UB383_T)},
 	{USB_DEVICE(USB_VID_KWORLD_2,  USB_PID_KWORLD_395U_4)},
 	{USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A815M)},
+	{USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A850T)},
 	{0},
 };
 MODULE_DEVICE_TABLE(usb, af9015_usb_table);
@@ -1518,8 +1521,9 @@ static struct dvb_usb_device_properties af9015_properties[] = {
 			},
 			{
 				.name = "AverMedia AVerTV Volar Black HD " \
-					"(A850)",
-				.cold_ids = {&af9015_usb_table[20], NULL},
+					"(A850) / AVerTV Volar Red HD+ (A850T)",
+				.cold_ids = {&af9015_usb_table[20],
+					     &af9015_usb_table[33], NULL},
 				.warm_ids = {NULL},
 			},
 		}
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
index 1a774d5..f52714c 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
@@ -196,6 +196,7 @@
 #define USB_PID_AVERMEDIA_A309				0xa309
 #define USB_PID_AVERMEDIA_A310				0xa310
 #define USB_PID_AVERMEDIA_A850				0x850a
+#define USB_PID_AVERMEDIA_A850T				0x850b
 #define USB_PID_AVERMEDIA_A805				0xa805
 #define USB_PID_AVERMEDIA_A815M				0x815a
 #define USB_PID_TECHNOTREND_CONNECT_S2400               0x3006
-- 
1.7.1

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Antti Palosaari]

On 09/30/2010 12:18 AM, Yann E. MORIN wrote:
> The AVerTV Red HD+ (A850T) is basically the same as the existing
> AVerTV Volar Black HD 9A850), but is specific to the french market.
>
> This is a collection of information gathered from the french support
> forums for Ubuntu, which I tried to properly format:
>    http://forum.ubuntu-fr.org/viewtopic.php?pid=3322825

>   	/* AverMedia AVerTV Volar Black HD (A850) device have bad EEPROM
> -	   content :-( Override some wrong values here. */
> +	   content :-( Override some wrong values here. Ditto for the
> +	   AVerTV Red HD+ (A850T) device. */
>   	if (le16_to_cpu(udev->descriptor.idVendor) == USB_VID_AVERMEDIA&&
> -	    le16_to_cpu(udev->descriptor.idProduct) == USB_PID_AVERMEDIA_A850) {
> +	    ((le16_to_cpu(udev->descriptor.idProduct) == USB_PID_AVERMEDIA_A850) ||
> +	     (le16_to_cpu(udev->descriptor.idProduct) == USB_PID_AVERMEDIA_A850T))) {
>   		deb_info("%s: AverMedia A850: overriding config\n", __func__);
>   		/* disable dual mode */
>   		af9015_config.dual_mode = 0;

Are you sure it does also have such bad eeprom content? Is that really 
needed? What it happens without this hack?


>   				.name = "AverMedia AVerTV Volar Black HD " \
> -					"(A850)",
> -				.cold_ids = {&af9015_usb_table[20], NULL},
> +					"(A850) / AVerTV Volar Red HD+ (A850T)",
> +				.cold_ids = {&af9015_usb_table[20],
> +					&af9015_usb_table[33], NULL},

Add new entry for that device (and leave A850 as untouched).

Antti
-- 
http://palosaari.fi/

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Yann E. MORIN]

Antti, All,

On Thursday 30 September 2010 11:40:12 Antti Palosaari wrote:
> >   	/* AverMedia AVerTV Volar Black HD (A850) device have bad EEPROM
> > -	   content :-( Override some wrong values here. */
> > +	   content :-( Override some wrong values here. Ditto for the
> > +	   AVerTV Red HD+ (A850T) device. */
> >   	if (le16_to_cpu(udev->descriptor.idVendor) == USB_VID_AVERMEDIA&&
> > -	    le16_to_cpu(udev->descriptor.idProduct) == USB_PID_AVERMEDIA_A850) {
> > +	    ((le16_to_cpu(udev->descriptor.idProduct) == USB_PID_AVERMEDIA_A850) ||
> > +	     (le16_to_cpu(udev->descriptor.idProduct) == USB_PID_AVERMEDIA_A850T))) {
> >   		deb_info("%s: AverMedia A850: overriding config\n", __func__);
> >   		/* disable dual mode */
> >   		af9015_config.dual_mode = 0;
> Are you sure it does also have such bad eeprom content? Is that really 
> needed? What it happens without this hack?

Well, not really sure. The fact is that it works with the kludge, and that
the device is very similar to the A850. On the Ubuntu forums, they simply
suggested replacing the A850 Product ID 0x850a with the A850T PID 0x850b
to make it work. And indeed it does work flawlessly so far.

Disabling dual mode when it is working, is better that enabling it when it
is not working. I tried to be conservative in this case.

I'll be doing some testing without the kludge later tonight, or at worst
during the WE. Unfortunately, the current v4l git tree BUGs in the USB
sub-system on my machine (even without my changes).

> >   				.name = "AverMedia AVerTV Volar Black HD " \
> > -					"(A850)",
> > -				.cold_ids = {&af9015_usb_table[20], NULL},
> > +					"(A850) / AVerTV Volar Red HD+ (A850T)",
> > +				.cold_ids = {&af9015_usb_table[20],
> > +					&af9015_usb_table[33], NULL},
> Add new entry for that device (and leave A850 as untouched).

OK. The number of supported devices is already 9 in all sections, so I guess
I'll have to add a new entry in the af9015_properties array, before I can
add a new device, right?

And what is the intrinsic difference between adding a new device section,
compared to adding a new PID to an existing device (just curious) ?

Thanks for the review. :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Antti Palosaari]

On 09/30/2010 08:56 PM, Yann E. MORIN wrote:
> OK. The number of supported devices is already 9 in all sections, so I guess
> I'll have to add a new entry in the af9015_properties array, before I can
> add a new device, right?

Actually you are using too old code as base. You should take latest GIT 
media tree and 2.6.37 branch. IIRC max is currently 12 devices per entry.

> And what is the intrinsic difference between adding a new device section,
> compared to adding a new PID to an existing device (just curious) ?

Not much more than a little bit different device name. Technically you 
can add all IDs to one device, but I feel better to add new entry per 
device. If device name is same but only ID is different it typically 
means different hw revision and in that case I would like to put those 
same for same entry. In that case device is also a little bit different 
- at least case colour.

Antti
-- 
http://palosaari.fi/

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Yann E. MORIN]

Antti, All,

On Thursday 30 September 2010 22:42:40 Antti Palosaari wrote:
> On 09/30/2010 08:56 PM, Yann E. MORIN wrote:
> > OK. The number of supported devices is already 9 in all sections, so I guess
> > I'll have to add a new entry in the af9015_properties array, before I can
> > add a new device, right?
> Actually you are using too old code as base. You should take latest GIT 
> media tree and 2.6.37 branch.

I'm using the latest tree from:
  git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git

Is that OK?

> IIRC max is currently 12 devices per entry. 

Yes, the array in the struct has 12 entries, but the comments in the
af9015 code said: "/* max 9 */". So I stuck to the comment.

I would make use of the entries left. The af9015_properties is an array
with currently 3 entries. Each entries currently all have 9 device
description. Do you prefer that I add the new description:
- in the first entry,
- just below the existing A850, (my pick)
- or in the last entry?

And to answer your previous question:
> Are you sure it does also have such bad eeprom content? Is that really
> needed? What it happens without this hack?

Yes, I just tried without the hack and it breaks. With the hack, it works.
I can provide the failing dmesg output if needed (see working one below).

> > And what is the intrinsic difference between adding a new device section,
> > compared to adding a new PID to an existing device (just curious) ?
> Not much more than a little bit different device name. Technically you 
> can add all IDs to one device, but I feel better to add new entry per 
> device. If device name is same but only ID is different it typically 
> means different hw revision and in that case I would like to put those 
> same for same entry. In that case device is also a little bit different 
> - at least case colour.

OK, got it. I'm afraid the A850T is just a A850 re-branded for the french
market. Here is the relevant dmesg output when I plug the stick (with my
changes applied on a 2.6.35.6):

[12547.002398] usb 3-3.1: new high speed USB device using ehci_hcd and address 9
[12547.090226] usb 3-3.1: New USB device found, idVendor=07ca, idProduct=850b
[12547.090228] usb 3-3.1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[12547.090230] usb 3-3.1: Product: A850 DVBT
[12547.090231] usb 3-3.1: Manufacturer: AVerMedia
[12547.090232] usb 3-3.1: SerialNumber: 302970601989000
[12547.093558] input: AVerMedia A850 DVBT as /class/input/input14
[12547.093603] generic-usb 0003:07CA:850B.000A: input,hidraw6: USB HID v1.01 Keyboard [AVerMedia A850 DVBT] on usb-0000:07:02.2-3.1/input1
[12547.488128] dvb-usb: found a 'AverMedia AVerTV Red HD+' in cold state, will try to load a firmware
[12547.492200] dvb-usb: downloading firmware from file 'dvb-usb-af9015.fw'
[12547.563986] dvb-usb: found a 'AverMedia AVerTV Red HD+' in warm state.
[12547.564032] dvb-usb: will pass the complete MPEG2 transport stream to the software demuxer.
[12547.564372] DVB: registering new adapter (AverMedia AVerTV Red HD+)
[12547.572230] af9013: firmware version:5.1.0
[12547.576731] DVB: registering adapter 0 frontend 0 (Afatech AF9013 DVB-T)...
[12547.581615] MXL5005S: Attached at address 0xc6
[12547.581653] input: IR-receiver inside an USB DVB receiver as /class/input/input15
[12547.581656] dvb-usb: schedule remote query interval to 150 msecs.
[12547.581658] dvb-usb: AverMedia AVerTV Red HD+ successfully initialized and connected.
[12547.678851] usbcore: registered new interface driver dvb_usb_af9015

See the part that reads:
  input: AVerMedia A850 DVBT as /class/input/input14
         ^^^^^^^^^^^^^^^^^^^

This is no kernel message, and (I guess) it comes as the ID string from the
device. It also appears on a machine where I have no DVB support.

So I believe the patch is OK in the state, unless you really want a new
device description, instead of adding to the existing A850 ( yes, granted,
it's not the same color ;-] ). What is your final word? ;-)

Anyway, before you get action and push this patch, Eric helped in the testing
so far. Maybe he'll want to add his tested-by?

Thank you very much for your comments and guidance!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Antti Palosaari]

Moi Yann

On 10/01/2010 12:09 AM, Yann E. MORIN wrote:
> Antti, All,
>
> On Thursday 30 September 2010 22:42:40 Antti Palosaari wrote:
>> On 09/30/2010 08:56 PM, Yann E. MORIN wrote:
>>> OK. The number of supported devices is already 9 in all sections, so I guess
>>> I'll have to add a new entry in the af9015_properties array, before I can
>>> add a new device, right?
>> Actually you are using too old code as base. You should take latest GIT
>> media tree and 2.6.37 branch.
>
> I'm using the latest tree from:
>    git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git
>
> Is that OK?

No, it is too old. Correct tree is staging/v2.6.37 at:
http://git.linuxtv.org/media_tree.git

>> IIRC max is currently 12 devices per entry.
>
> Yes, the array in the struct has 12 entries, but the comments in the
> af9015 code said: "/* max 9 */". So I stuck to the comment.

That`s since count is increased after comment. I have changed it already.

> I would make use of the entries left. The af9015_properties is an array
> with currently 3 entries. Each entries currently all have 9 device
> description. Do you prefer that I add the new description:
> - in the first entry,
> - just below the existing A850, (my pick)
> - or in the last entry?

Add it to the first free slot find. It was TerraTec Cinergy T Dual RC I 
added lastly. If there is free space put it just behind that, otherwise 
to the first free slot in next entry. This entry/dev count really sucks 
a little bit, it should be fixed if possible... but as now we left it.

> And to answer your previous question:
>> Are you sure it does also have such bad eeprom content? Is that really
>> needed? What it happens without this hack?
>
> Yes, I just tried without the hack and it breaks. With the hack, it works.
> I can provide the failing dmesg output if needed (see working one below).

OK, then hack is needed.

>>> And what is the intrinsic difference between adding a new device section,
>>> compared to adding a new PID to an existing device (just curious) ?
>> Not much more than a little bit different device name. Technically you
>> can add all IDs to one device, but I feel better to add new entry per
>> device. If device name is same but only ID is different it typically
>> means different hw revision and in that case I would like to put those
>> same for same entry. In that case device is also a little bit different
>> - at least case colour.
>
> OK, got it. I'm afraid the A850T is just a A850 re-branded for the french
> market. Here is the relevant dmesg output when I plug the stick (with my
> changes applied on a 2.6.35.6):
>
> [12547.002398] usb 3-3.1: new high speed USB device using ehci_hcd and address 9
> [12547.090226] usb 3-3.1: New USB device found, idVendor=07ca, idProduct=850b
> [12547.090228] usb 3-3.1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
> [12547.090230] usb 3-3.1: Product: A850 DVBT
> [12547.090231] usb 3-3.1: Manufacturer: AVerMedia
> [12547.090232] usb 3-3.1: SerialNumber: 302970601989000
> [12547.093558] input: AVerMedia A850 DVBT as /class/input/input14
> [12547.093603] generic-usb 0003:07CA:850B.000A: input,hidraw6: USB HID v1.01 Keyboard [AVerMedia A850 DVBT] on usb-0000:07:02.2-3.1/input1
> [12547.488128] dvb-usb: found a 'AverMedia AVerTV Red HD+' in cold state, will try to load a firmware
> [12547.492200] dvb-usb: downloading firmware from file 'dvb-usb-af9015.fw'
> [12547.563986] dvb-usb: found a 'AverMedia AVerTV Red HD+' in warm state.
> [12547.564032] dvb-usb: will pass the complete MPEG2 transport stream to the software demuxer.
> [12547.564372] DVB: registering new adapter (AverMedia AVerTV Red HD+)
> [12547.572230] af9013: firmware version:5.1.0
> [12547.576731] DVB: registering adapter 0 frontend 0 (Afatech AF9013 DVB-T)...
> [12547.581615] MXL5005S: Attached at address 0xc6
> [12547.581653] input: IR-receiver inside an USB DVB receiver as /class/input/input15
> [12547.581656] dvb-usb: schedule remote query interval to 150 msecs.
> [12547.581658] dvb-usb: AverMedia AVerTV Red HD+ successfully initialized and connected.
> [12547.678851] usbcore: registered new interface driver dvb_usb_af9015
>
> See the part that reads:
>    input: AVerMedia A850 DVBT as /class/input/input14
>           ^^^^^^^^^^^^^^^^^^^
>
> This is no kernel message, and (I guess) it comes as the ID string from the
> device. It also appears on a machine where I have no DVB support.

Yes, it comes from eeprom, also lsusb should show it (lsusb -vvd usb-id)

> So I believe the patch is OK in the state, unless you really want a new
> device description, instead of adding to the existing A850 ( yes, granted,
> it's not the same color ;-] ). What is your final word? ;-)

Hmm, now I like it when it is identified as AverMedia AVerTV Red HD+.
>
> Anyway, before you get action and push this patch, Eric helped in the testing
> so far. Maybe he'll want to add his tested-by?
>
> Thank you very much for your comments and guidance!
>
> Regards,
> Yann E. MORIN.
>

If you can make patch against latest 2.6.37 pointed I it will be OK. 
Also possible remote could be nice... 2.6.37 af9015 have totally 
different remote implementation.

thanks,
Antti
-- 
http://palosaari.fi/

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Yann E. MORIN]

Antti, All,

On Thursday 30 September 2010 23:48:57 Antti Palosaari wrote:
> On 10/01/2010 12:09 AM, Yann E. MORIN wrote:
> > I'm using the latest tree from:
> >    git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git
> No, it is too old. Correct tree is staging/v2.6.37 at:
> http://git.linuxtv.org/media_tree.git

OK!

> > I would make use of the entries left. The af9015_properties is an array
> > with currently 3 entries. Each entries currently all have 9 device
> > description. Do you prefer that I add the new description:
> > - in the first entry,
> > - just below the existing A850, (my pick)
> > - or in the last entry?
> Add it to the first free slot find. It was TerraTec Cinergy T Dual RC I 
> added lastly. If there is free space put it just behind that, otherwise 
> to the first free slot in next entry. This entry/dev count really sucks 
> a little bit, it should be fixed if possible... but as now we left it.

OK!

> Hmm, now I like it when it is identified as AverMedia AVerTV Red HD+.
[--SNIP--]
> If you can make patch against latest 2.6.37 pointed I it will be OK. 

Yes, I will.

> Also possible remote could be nice... 2.6.37 af9015 have totally 
> different remote implementation.

I am not using the remote for now. As soon I have it working, I'll either
submit a patch, or acknowledge existing stuff works.

Thank you!

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Eric Valette]

On 09/30/2010 11:48 PM, Antti Palosaari wrote:
> Moi Yann
>
> On 10/01/2010 12:09 AM, Yann E. MORIN wrote:
>> Antti, All,
>>
>> On Thursday 30 September 2010 22:42:40 Antti Palosaari wrote:
>>> On 09/30/2010 08:56 PM, Yann E. MORIN wrote:
>>>> OK. The number of supported devices is already 9 in all sections, so
>>>> I guess
>>>> I'll have to add a new entry in the af9015_properties array, before
>>>> I can
>>>> add a new device, right?
>>> Actually you are using too old code as base. You should take latest GIT
>>> media tree and 2.6.37 branch.
>>
>> I'm using the latest tree from:
>> git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git
>>
>> Is that OK?
>
> No, it is too old. Correct tree is staging/v2.6.37 at:
> http://git.linuxtv.org/media_tree.git

Antti,

just a side comment: the web pages at http://linuxtv.org are, how could 
I say it politely, confusing.

The cvs page are still there but speak about mercurial. The hg page 
speak about git and points to the wrong repository

V4L-DVB repository (http://git.linuxtv.org/v4l-dvb.git)	Git repository 
with V4L/DVB patches for next kernels 	Mauro Carvalho Chehab 	RSS


>> Anyway, before you get action and push this patch, Eric helped in the
>> testing
>> so far. Maybe he'll want to add his tested-by?

I would prefer to have better web pages for the project ;-)

Thanks for the good work anyway,

--eric

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Mauro Carvalho Chehab]

Em 01-10-2010 05:05, Eric Valette escreveu:
> On 09/30/2010 11:48 PM, Antti Palosaari wrote:
> Antti,
> 
> just a side comment: the web pages at http://linuxtv.org are, how could I say it politely, confusing.
> 
> The cvs page are still there but speak about mercurial. The hg page speak about git and points to the wrong repository
> 
> V4L-DVB repository (http://git.linuxtv.org/v4l-dvb.git)    Git repository with V4L/DVB patches for next kernels     Mauro Carvalho Chehab     RSS
> 
> 
>>> Anyway, before you get action and push this patch, Eric helped in the
>>> testing
>>> so far. Maybe he'll want to add his tested-by?
> 
> I would prefer to have better web pages for the project ;-)


Eric,

If you find an error at the wiki pages or some legacy information, please help us
to maintain it by editing them! It is a huge work to keep the drivers updated, consuming
lots of the developers available time, and generally done after hours. We simply don't 
have time to also keep the wiki updated ;)

We count on the LinuxTV users community to help us with the wiki.

So, be welcome to improve the wiki and to fix any issues there. If you find a bug outside
the wiki pages, feel free to send me an email pointing the issues, and proposing a
new text to fix the issue
 
> Thanks for the good work anyway,

Thanks,
Mauro

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Eric Valette]

On 10/01/2010 01:57 PM, Mauro Carvalho Chehab wrote:
>
> If you find an error at the wiki pages or some legacy information, please help us
> to maintain it by editing them!

Its not in the wiki but in the web pages <http://www.linuxtv.org/> that 
offer no way to update them. Look the content on the left and browse 
through CVS/Mercurial/HG/git


> We count on the LinuxTV users community to help us with the wiki.

Again, its the web pages not the wiki. I think explaining how to get the 
right sources for submitting patches takes less time than asking all 
people supplying code to rebase their patch. YMMV

-- eric

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Mauro Carvalho Chehab]

Em 01-10-2010 09:06, Eric Valette escreveu:
> On 10/01/2010 01:57 PM, Mauro Carvalho Chehab wrote:
>>
>> If you find an error at the wiki pages or some legacy information, please help us
>> to maintain it by editing them!
> 
> Its not in the wiki but in the web pages <http://www.linuxtv.org/> that offer no way to update them. Look the content on the left and browse through CVS/Mercurial/HG/git
> 
> 
>> We count on the LinuxTV users community to help us with the wiki.
> 
> Again, its the web pages not the wiki. I think explaining how to get the right sources for submitting patches takes less time than asking all people supplying code to rebase their patch. YMMV

If you're talking about http://linuxtv.org/repo/, I just updated it.

Thanks,
Mauro

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Eric Valette]

On 10/01/2010 04:53 PM, Mauro Carvalho Chehab wrote:

> If you're talking about http://linuxtv.org/repo/, I just updated it.

Thanks. If you find some extra time look at <http://linuxtv.org/hg/> 
(points to incorrect git tree) and <http://git.linuxtv.org/> that should 
have the same explantion as repo on top maybe.

Again thanks for the hard work. And have a nice week-end.

-- eric

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Mauro Carvalho Chehab]

Em 01-10-2010 12:05, Eric Valette escreveu:
> On 10/01/2010 04:53 PM, Mauro Carvalho Chehab wrote:
> 
>> If you're talking about http://linuxtv.org/repo/, I just updated it.
> 
> Thanks. If you find some extra time look at <http://linuxtv.org/hg/> (points to incorrect git tree) 

Fixed.

> and <http://git.linuxtv.org/> that should have the same explantion as repo on top maybe.

It is not that easy to do it with gitweb. Well, I just added it at the header file, pointing
to the 3 main trees (drivers, dvb apps and v4l utils).
> 
> Again thanks for the hard work. And have a nice week-end.
> 
> -- eric
> 

Thanks,
Mauro

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Yann E. MORIN]

Hell all!

On Friday 01 October 2010 165318 Mauro Carvalho Chehab wrote:
> If you're talking about http://linuxtv.org/repo/, I just updated it.

Just nit-picking here, but the instructions still have some typoes:

git remote add linuxtv git://linuxtv.org/media-tree.git
-> the name of the tree uses a '_'            ^

git pull . remotes/staging/v2.6.37
-> should be (at least the above does not work for me):
git pull . remotes/linuxtv/staging/v2.6.37

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software  Designer | \ / CAMPAIGN     |   ^                |
| --==< O_o >==-- '------------.-------:  X  AGAINST      |  /e\  There is no  |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL    |  """  conspiracy.  |
'------------------------------'-------'------------------'--------------------'

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Mauro Carvalho Chehab]

Em 01-10-2010 12:05, Yann E. MORIN escreveu:
> Hell all!
> 
> On Friday 01 October 2010 165318 Mauro Carvalho Chehab wrote:
>> If you're talking about http://linuxtv.org/repo/, I just updated it.
> 
> Just nit-picking here, but the instructions still have some typoes:
> 
> git remote add linuxtv git://linuxtv.org/media-tree.git
> -> the name of the tree uses a '_'            ^
> 
> git pull . remotes/staging/v2.6.37
> -> should be (at least the above does not work for me):
> git pull . remotes/linuxtv/staging/v2.6.37

fixed, thanks.
> 
> Regards,
> Yann E. MORIN.
> 

[PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T), v2

[Yann E. MORIN]

Hello All!

This patch adds support for the AverMedia AVerTV Red HD+ (aka A850T)
DVB-T USB stick, available (exclusively?) on the french market.

Changes since v1:
- move to its own device description
- rebase on top staging/v2.6.37 in the media_tree git tree

checkpatch.pl warns about two lines that are longer than 80 chars,
but I am not sure how to split them and still keep readable code.
Suggestions welcome. ;-)

Note: only the DVB-T reception has been tested, not the remote
controler part, as I do not use it. It may come later as I may
eventually need it.

Thanks to Antti for his suggestions and guidance. :-)

Regards,
Yann E. MORIN.

[PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Yann E. MORIN]

The AVerTV Red HD+ (A850T) is basically the same as the existing
AVerTV Volar Black HD (A850), but is specific to the french market.
The A850T identifies itself as a A850, but has its own PID. It even
suffers from the same EEPROM deficiencies.

This is based off a collection of information gathered from the
french support forums for Ubuntu, which I tried to properly format
into this patch:
  http://forum.ubuntu-fr.org/viewtopic.php?pid=3322825

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
---
 drivers/media/dvb/dvb-usb/af9015.c      |   14 +++++++++++---
 drivers/media/dvb/dvb-usb/dvb-usb-ids.h |    1 +
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/drivers/media/dvb/dvb-usb/af9015.c b/drivers/media/dvb/dvb-usb/af9015.c
index f63cb18..8c073ab 100644
--- a/drivers/media/dvb/dvb-usb/af9015.c
+++ b/drivers/media/dvb/dvb-usb/af9015.c
@@ -966,9 +966,11 @@ error:
 		err("eeprom read failed:%d", ret);
 
 	/* AverMedia AVerTV Volar Black HD (A850) device have bad EEPROM
-	   content :-( Override some wrong values here. */
+	   content :-( Override some wrong values here. Ditto for the
+	   AVerTV Red HD+ (A850T) device. */
 	if (le16_to_cpu(udev->descriptor.idVendor) == USB_VID_AVERMEDIA &&
-	    le16_to_cpu(udev->descriptor.idProduct) == USB_PID_AVERMEDIA_A850) {
+	    ((le16_to_cpu(udev->descriptor.idProduct) == USB_PID_AVERMEDIA_A850) ||
+	     (le16_to_cpu(udev->descriptor.idProduct) == USB_PID_AVERMEDIA_A850T))) {
 		deb_info("%s: AverMedia A850: overriding config\n", __func__);
 		/* disable dual mode */
 		af9015_config.dual_mode = 0;
@@ -1299,6 +1301,7 @@ static struct usb_device_id af9015_usb_table[] = {
 	{USB_DEVICE(USB_VID_TERRATEC,  USB_PID_TERRATEC_CINERGY_T_STICK_RC)},
 	{USB_DEVICE(USB_VID_TERRATEC,
 		USB_PID_TERRATEC_CINERGY_T_STICK_DUAL_RC)},
+/* 35 */{USB_DEVICE(USB_VID_AVERMEDIA, USB_PID_AVERMEDIA_A850T)},
 	{0},
 };
 MODULE_DEVICE_TABLE(usb, af9015_usb_table);
@@ -1361,7 +1364,7 @@ static struct dvb_usb_device_properties af9015_properties[] = {
 
 		.i2c_algo = &af9015_i2c_algo,
 
-		.num_device_descs = 11, /* check max from dvb-usb.h */
+		.num_device_descs = 12, /* check max from dvb-usb.h */
 		.devices = {
 			{
 				.name = "Afatech AF9015 DVB-T USB2.0 stick",
@@ -1423,6 +1426,11 @@ static struct dvb_usb_device_properties af9015_properties[] = {
 				.cold_ids = {&af9015_usb_table[34], NULL},
 				.warm_ids = {NULL},
 			},
+			{
+				.name = "AverMedia AVerTV Red HD+ (A850T)",
+				.cold_ids = {&af9015_usb_table[35], NULL},
+				.warm_ids = {NULL},
+			},
 		}
 	}, {
 		.caps = DVB_USB_IS_AN_I2C_ADAPTER,
diff --git a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
index 436d53d..cc398ec 100644
--- a/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
+++ b/drivers/media/dvb/dvb-usb/dvb-usb-ids.h
@@ -198,6 +198,7 @@
 #define USB_PID_AVERMEDIA_A309				0xa309
 #define USB_PID_AVERMEDIA_A310				0xa310
 #define USB_PID_AVERMEDIA_A850				0x850a
+#define USB_PID_AVERMEDIA_A850T				0x850b
 #define USB_PID_AVERMEDIA_A805				0xa805
 #define USB_PID_AVERMEDIA_A815M				0x815a
 #define USB_PID_TECHNOTREND_CONNECT_S2400               0x3006
-- 
1.7.1

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Yann E. MORIN]

All,

On Friday 01 October 2010 21:55:43 Yann E. MORIN wrote:
> The AVerTV Red HD+ (A850T) is basically the same as the existing
> AVerTV Volar Black HD (A850), but is specific to the french market.
> The A850T identifies itself as a A850, but has its own PID. It even
> suffers from the same EEPROM deficiencies.

Ping? Is there something that I should still work on?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

Re: [PATCH] v4l/dvb: add support for AVerMedia AVerTV Red HD+ (A850T)

[Antti Palosaari]

On 10/04/2010 11:55 PM, Yann E. MORIN wrote:
> All,
>
> On Friday 01 October 2010 21:55:43 Yann E. MORIN wrote:
>> The AVerTV Red HD+ (A850T) is basically the same as the existing
>> AVerTV Volar Black HD (A850), but is specific to the french market.
>> The A850T identifies itself as a A850, but has its own PID. It even
>> suffers from the same EEPROM deficiencies.
>
> Ping? Is there something that I should still work on?

No. I will pick it up and forward to the master.

thanks
Antti


>
> Regards,
> Yann E. MORIN.
>


-- 
http://palosaari.fi/