* Confusing dmx_pes_type_t in dmx.h
@ 2010-10-05 6:28 Jan Hoogenraad
2010-10-05 14:05 ` Andreas Oberritter
0 siblings, 1 reply; 2+ messages in thread
From: Jan Hoogenraad @ 2010-10-05 6:28 UTC (permalink / raw)
To: linux-media@vger.kernel.org, Hans Verkuil
The file dmx.h declares dmx_pes_type_t which is ONLY used in this header
file.
It is easy to make mistakes, as its member DMX_PES_OTHER resembles a
similar symbol in demux.h from enum dmx_ts_pes: DMX_TS_PES_OTHER
One problem was found because of Hans' compiler upgrade.
I think it would be safer (because it is easy to make mistakes) to
remove dmx_pes_type_t from dmx.h.
Who knows more on this driver ?
The found bug is fixed in the patch on:
http://linuxtv.org/hg/~jhoogenraad/ubuntu-firedtv/rev/44751f6fba2f
--
Jan Hoogenraad
Hoogenraad Interface Services
Postbus 2717
3500 GS Utrecht
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Confusing dmx_pes_type_t in dmx.h
2010-10-05 6:28 Confusing dmx_pes_type_t in dmx.h Jan Hoogenraad
@ 2010-10-05 14:05 ` Andreas Oberritter
0 siblings, 0 replies; 2+ messages in thread
From: Andreas Oberritter @ 2010-10-05 14:05 UTC (permalink / raw)
To: Jan Hoogenraad; +Cc: linux-media@vger.kernel.org, Hans Verkuil
On 05.10.2010 08:28, Jan Hoogenraad wrote:
> The file dmx.h declares dmx_pes_type_t which is ONLY used in this header
> file.
> It is easy to make mistakes, as its member DMX_PES_OTHER resembles a
> similar symbol in demux.h from enum dmx_ts_pes: DMX_TS_PES_OTHER
>
> One problem was found because of Hans' compiler upgrade.
>
> I think it would be safer (because it is easy to make mistakes) to
> remove dmx_pes_type_t from dmx.h.
The file dmx.h defines the interface for userspace applications, hence
dmx_pes_type_t must not be removed. Instead, removing enum dmx_ts_pes
from demux.h seems to be useful to me.
Regards,
Andreas
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-05 14:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-05 6:28 Confusing dmx_pes_type_t in dmx.h Jan Hoogenraad
2010-10-05 14:05 ` Andreas Oberritter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox