From: Sakari Ailus <sakari.ailus@maxwell.research.nokia.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH/RFC v3 01/11] v4l: Move the media/v4l2-mediabus.h header to include/linux
Date: Wed, 06 Oct 2010 01:31:08 +0300 [thread overview]
Message-ID: <4CABA72C.3070509@maxwell.research.nokia.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1010051728360.31708@axis700.grange>
Hi Guennadi!
Guennadi Liakhovetski wrote:
> On Tue, 5 Oct 2010, Sakari Ailus wrote:
...
>>> +/**
>>> + * struct v4l2_mbus_framefmt - frame format on the media bus
>>> + * @width: frame width
>>> + * @height: frame height
>>> + * @code: data format code
>>> + * @field: used interlacing type
>>> + * @colorspace: colorspace of the data
>>> + */
>>> +struct v4l2_mbus_framefmt {
>>> + __u32 width;
>>> + __u32 height;
>>> + __u32 code;
>>> + enum v4l2_field field;
>>> + enum v4l2_colorspace colorspace;
>>> +};
>>
>> I think this struct would benefit from some reserved fields since it's
>> part of the user space interface.
>
> IIUC, this struct is not going to be used in ioctl()s, that's what struct
> v4l2_subdev_mbus_code_enum is for. But in this case - why don't we make
Oh, you're right. My mistake.
--
Sakari Ailus
sakari.ailus@maxwell.research.nokia.com
next prev parent reply other threads:[~2010-10-05 22:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 14:25 [PATCH/RFC v3 00/11] Sub-device pad-level operations Laurent Pinchart
2010-10-05 14:25 ` [PATCH/RFC v3 01/11] v4l: Move the media/v4l2-mediabus.h header to include/linux Laurent Pinchart
2010-10-05 14:43 ` Sakari Ailus
2010-10-05 15:30 ` Guennadi Liakhovetski
2010-10-05 15:34 ` Hans Verkuil
2010-10-05 22:32 ` Sakari Ailus
2010-10-05 22:31 ` Sakari Ailus [this message]
2010-10-06 6:23 ` Laurent Pinchart
2010-10-05 14:25 ` [PATCH/RFC v3 02/11] v4l: Rename V4L2_MBUS_FMT_GREY8_1X8 to V4L2_MBUS_FMT_Y8_1X8 Laurent Pinchart
2010-10-05 14:25 ` [PATCH/RFC v3 03/11] v4l: Group media bus pixel codes by types and sort them alphabetically Laurent Pinchart
2010-10-05 15:32 ` Guennadi Liakhovetski
2010-10-06 9:19 ` Hiremath, Vaibhav
2010-10-06 10:13 ` Laurent Pinchart
2010-10-06 10:19 ` Hiremath, Vaibhav
2010-10-05 14:25 ` [PATCH/RFC v3 04/11] v4l: Add 8-bit YUYV on 16-bit bus and SGRBG10 media bus pixel codes Laurent Pinchart
2010-10-06 9:19 ` Hiremath, Vaibhav
2010-10-06 10:18 ` Laurent Pinchart
2010-10-06 10:21 ` Hiremath, Vaibhav
2010-10-05 14:25 ` [PATCH/RFC v3 05/11] v4l: Add remaining RAW10 patterns w DPCM pixel code variants Laurent Pinchart
2010-10-05 14:25 ` [PATCH/RFC v3 06/11] v4l: Create v4l2 subdev file handle structure Laurent Pinchart
2010-10-05 14:25 ` [PATCH/RFC v3 07/11] v4l: v4l2_subdev pad-level operations Laurent Pinchart
2010-10-05 14:25 ` [PATCH/RFC v3 08/11] v4l: v4l2_subdev userspace format API - documentation binary files Laurent Pinchart
2010-10-05 14:25 ` [PATCH/RFC v3 09/11] v4l: v4l2_subdev userspace format API Laurent Pinchart
2010-10-05 14:25 ` [PATCH/RFC v3 10/11] v4l: v4l2_subdev userspace frame interval API Laurent Pinchart
2010-10-05 14:25 ` [PATCH/RFC v3 11/11] v4l: v4l2_subdev userspace crop API Laurent Pinchart
2010-10-05 14:33 ` [PATCH/RFC v3 00/11] Sub-device pad-level operations Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CABA72C.3070509@maxwell.research.nokia.com \
--to=sakari.ailus@maxwell.research.nokia.com \
--cc=g.liakhovetski@gmx.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox