From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59579 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753524Ab0JHAb4 (ORCPT ); Thu, 7 Oct 2010 20:31:56 -0400 Message-ID: <4CAE6677.3070906@redhat.com> Date: Thu, 07 Oct 2010 21:31:51 -0300 From: Mauro Carvalho Chehab MIME-Version: 1.0 To: Devin Heitmueller CC: Srinivasa.Deevi@conexant.com, Palash.Bandyopadhyay@conexant.com, Linux Media Mailing List Subject: Re: [PATCH 01/10] V4L/DVB: cx231xx: remove a printk warning at -avcore and at -417 References: <20100928154653.785c1f3f@pedra> <4CAE4020.4000209@redhat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit List-ID: Sender: Em 07-10-2010 19:04, Devin Heitmueller escreveu: > On Thu, Oct 7, 2010 at 5:48 PM, Mauro Carvalho Chehab > wrote: >> Em 28-09-2010 15:46, Mauro Carvalho Chehab escreveu: >>> drivers/media/video/cx231xx/cx231xx-avcore.c:1608: warning: format ‘%d’ expects type ‘int’, but argument 3 has type ‘long unsigned int’ >>> drivers/media/video/cx231xx/cx231xx-417.c:1047: warning: format ‘%d’ expects type ‘int’, but argument 3 has type ‘size_t’ >>> >>> Signed-off-by: Mauro Carvalho Chehab >> >> OK, I just updated my tree with the patches that Mkrufky acked. >> It basically contains the same patches from my previous post, plus >> the patches that Palash sent, and Devin/Mkrufky patches from polaris4 >> tree, rebased over the top of kernel v2.6.36-rc7 (this makes easier >> for me to test and to merge). >> >> The patches are at: >> http://git.linuxtv.org/mchehab/cx231xx.git >> >> Sri already sent his ack for the first series of the patches. >> >> The tree contains two extra patches: >> >> 1) a cx231xx large CodingStyle fix patch: >> http://git.linuxtv.org/mchehab/cx231xx.git?a=commit;h=eacd1a7749ae45d1f2f5782c013b863ff480746d >> >> It basically solves the issues that checkpatch.pl complained on this series of patches; >> >> 2) a cx231xx-417 gcc warning fix: >> http://git.linuxtv.org/mchehab/cx231xx.git?a=commit;h=ca3a6a8c2a4819702e93b9612c4a6d90474ea9b5 >> >> Devin, >> >> Would it be ok for you if I merge them on my main tree? They're needed for one >> board I'm working with (a Pixelview SBTVD Hybrid - that supports both analog >> and full-seg ISDB-T). > > Yeah, I've got additional fixes which aren't on that tree yet, but I > don't see any reason why what's there cannot be merged. Applied, thanks! Thanks to the compilation tests I do here, I discovered some duplicated symbols between cx23885 and cx231xx-417. I just fixed the errors. Patches were post to the ML and were also applied to the tree, to avoid compilation breakages. Cheers, Mauro.