From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: Paul Walmsley <paul@booyaka.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH] V4L/DVB: tvp5150: COMPOSITE0 input should not force-enable TV mode
Date: Sat, 09 Oct 2010 10:03:02 -0300 [thread overview]
Message-ID: <4CB06806.2070900@infradead.org> (raw)
In-Reply-To: <AANLkTinhS=GOV=1uR6H=9_=S-nyirdm6Z7HF6N5wKw2T@mail.gmail.com>
Em 09-10-2010 09:33, Devin Heitmueller escreveu:
> On Sat, Oct 9, 2010 at 12:31 AM, Paul Walmsley <paul@booyaka.com> wrote:
>>
>> When digitizing composite video from a analog videotape source using the
>> TVP5150's first composite input channel, the captured stream exhibits
>> tearing and synchronization problems[1].
>>
>> It turns out that commit c0477ad9feca01bd8eff95d7482c33753d05c700 caused
>> "TV mode" (as opposed to "VCR mode" or "auto-detect") to be forcibly
>> enabled for both composite inputs. According to the chip
>> documentation[2], "TV mode" disables a "chrominance trap" input filter,
>> which appears to be necessary for high-quality video capture from an
>> analog videotape source. [ Commit
>> c7c0b34c27bbf0671807e902fbfea6270c8f138d subsequently restricted the
>> problem to the first composite input, apparently inadvertently. ]
>
> FYI: This isn't a newly discovered issue:
>
> http://www.mail-archive.com/linux-media@vger.kernel.org/msg13869.html
Yeah. I basically asked people to do more tests, but never got any feedback
about that issue. Provided that it won't break anything, I'm ok on merging
it.
Cheers,
Mauro
next prev parent reply other threads:[~2010-10-09 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-09 4:31 [PATCH] V4L/DVB: tvp5150: COMPOSITE0 input should not force-enable TV mode Paul Walmsley
2010-10-09 12:33 ` Devin Heitmueller
2010-10-09 13:03 ` Mauro Carvalho Chehab [this message]
2010-10-09 15:10 ` Paul Walmsley
2010-10-09 15:22 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB06806.2070900@infradead.org \
--to=mchehab@infradead.org \
--cc=dheitmueller@kernellabs.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=paul@booyaka.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox