public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
	linux-media@vger.kernel.org,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [git:v4l-dvb/v2.6.37] [media] Add driver for Siliconfile SR030PC30 VGA camera
Date: Mon, 18 Oct 2010 14:58:04 +0200	[thread overview]
Message-ID: <4CBC445C.5000903@samsung.com> (raw)
In-Reply-To: <201010172214.15773.hverkuil@xs4all.nl>


Hello Hans,

On 10/17/2010 10:14 PM, Hans Verkuil wrote:
> On Sunday, October 17, 2010 21:28:29 Mauro Carvalho Chehab wrote:
>> This is an automatic generated email to let you know that the following patch were queued at the 
>> http://git.linuxtv.org/media_tree.git tree:
>>
>> Subject: [media] Add driver for Siliconfile SR030PC30 VGA camera
>> Author:  Sylwester Nawrocki <s.nawrocki@samsung.com>
>> Date:    Mon Oct 11 13:33:57 2010 -0300
>>
[snip]
> It fails to compile with this error:
> 
> drivers/media/video/sr030pc30.c: In function ‘sr030pc30_probe’:
> drivers/media/video/sr030pc30.c:834: error: implicit declaration of function ‘kzalloc’
> drivers/media/video/sr030pc30.c:834: warning: assignment makes pointer from integer without a cast
> drivers/media/video/sr030pc30.c: In function ‘sr030pc30_remove’:
> drivers/media/video/sr030pc30.c:858: error: implicit declaration of function ‘kfree’
> 
> Here is the patch to fix this:
[snip]
> Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
> 

Thank you for fixing this. I will definitely improve my test environment
so this kind of errors do not appear in the future.

Regards,
Sylwester

-- 
Sylwester Nawrocki
Linux Platform Group
Samsung Poland R&D Center

  parent reply	other threads:[~2010-10-18 12:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1P7Yvq-0001kW-Pf@www.linuxtv.org>
2010-10-17 20:14 ` [git:v4l-dvb/v2.6.37] [media] Add driver for Siliconfile SR030PC30 VGA camera Hans Verkuil
2010-10-17 21:30   ` Mauro Carvalho Chehab
2010-10-18 12:58   ` Sylwester Nawrocki [this message]
2010-10-18 13:14     ` Mauro Carvalho Chehab
2010-10-18 13:21       ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CBC445C.5000903@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=hverkuil@xs4all.nl \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox