* Re: [git:v4l-dvb/v2.6.37] [media] Add driver for Siliconfile SR030PC30 VGA camera [not found] <E1P7Yvq-0001kW-Pf@www.linuxtv.org> @ 2010-10-17 20:14 ` Hans Verkuil 2010-10-17 21:30 ` Mauro Carvalho Chehab 2010-10-18 12:58 ` Sylwester Nawrocki 0 siblings, 2 replies; 5+ messages in thread From: Hans Verkuil @ 2010-10-17 20:14 UTC (permalink / raw) To: Mauro Carvalho Chehab, linux-media; +Cc: Kyungmin Park, Sylwester Nawrocki On Sunday, October 17, 2010 21:28:29 Mauro Carvalho Chehab wrote: > This is an automatic generated email to let you know that the following patch were queued at the > http://git.linuxtv.org/media_tree.git tree: > > Subject: [media] Add driver for Siliconfile SR030PC30 VGA camera > Author: Sylwester Nawrocki <s.nawrocki@samsung.com> > Date: Mon Oct 11 13:33:57 2010 -0300 > > Add an I2C/v4l2-subdev driver for Siliconfile SR030PC30 VGA > camera sensor with Image Signal Processor. SR030PC30 is > the low resolution camera sensor on Samsung Aquila boards. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> > > drivers/media/video/Kconfig | 6 + > drivers/media/video/Makefile | 1 + > drivers/media/video/sr030pc30.c | 893 +++++++++++++++++++++++++++++++++++++++ > include/media/sr030pc30.h | 21 + > 4 files changed, 921 insertions(+), 0 deletions(-) It fails to compile with this error: drivers/media/video/sr030pc30.c: In function ‘sr030pc30_probe’: drivers/media/video/sr030pc30.c:834: error: implicit declaration of function ‘kzalloc’ drivers/media/video/sr030pc30.c:834: warning: assignment makes pointer from integer without a cast drivers/media/video/sr030pc30.c: In function ‘sr030pc30_remove’: drivers/media/video/sr030pc30.c:858: error: implicit declaration of function ‘kfree’ Here is the patch to fix this: diff --git a/drivers/media/video/sr030pc30.c b/drivers/media/video/sr030pc30.c index f82e1f3..ec8d875 100644 --- a/drivers/media/video/sr030pc30.c +++ b/drivers/media/video/sr030pc30.c @@ -18,6 +18,7 @@ #include <linux/i2c.h> #include <linux/delay.h> +#include <linux/slab.h> #include <media/v4l2-device.h> #include <media/v4l2-subdev.h> #include <media/v4l2-mediabus.h> Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> -- Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [git:v4l-dvb/v2.6.37] [media] Add driver for Siliconfile SR030PC30 VGA camera 2010-10-17 20:14 ` [git:v4l-dvb/v2.6.37] [media] Add driver for Siliconfile SR030PC30 VGA camera Hans Verkuil @ 2010-10-17 21:30 ` Mauro Carvalho Chehab 2010-10-18 12:58 ` Sylwester Nawrocki 1 sibling, 0 replies; 5+ messages in thread From: Mauro Carvalho Chehab @ 2010-10-17 21:30 UTC (permalink / raw) To: Hans Verkuil; +Cc: linux-media, Kyungmin Park, Sylwester Nawrocki Em 17-10-2010 18:14, Hans Verkuil escreveu: > On Sunday, October 17, 2010 21:28:29 Mauro Carvalho Chehab wrote: >> This is an automatic generated email to let you know that the following patch were queued at the >> http://git.linuxtv.org/media_tree.git tree: >> >> Subject: [media] Add driver for Siliconfile SR030PC30 VGA camera >> Author: Sylwester Nawrocki <s.nawrocki@samsung.com> >> Date: Mon Oct 11 13:33:57 2010 -0300 >> >> Add an I2C/v4l2-subdev driver for Siliconfile SR030PC30 VGA >> camera sensor with Image Signal Processor. SR030PC30 is >> the low resolution camera sensor on Samsung Aquila boards. >> >> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> >> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> >> >> drivers/media/video/Kconfig | 6 + >> drivers/media/video/Makefile | 1 + >> drivers/media/video/sr030pc30.c | 893 +++++++++++++++++++++++++++++++++++++++ >> include/media/sr030pc30.h | 21 + >> 4 files changed, 921 insertions(+), 0 deletions(-) > > It fails to compile with this error: > > drivers/media/video/sr030pc30.c: In function ‘sr030pc30_probe’: > drivers/media/video/sr030pc30.c:834: error: implicit declaration of function ‘kzalloc’ > drivers/media/video/sr030pc30.c:834: warning: assignment makes pointer from integer without a cast > drivers/media/video/sr030pc30.c: In function ‘sr030pc30_remove’: > drivers/media/video/sr030pc30.c:858: error: implicit declaration of function ‘kfree’ Hmm... it is funny that the driver compiled well here, but failed for you... I've compiled it with allyesconfig. I got just some warnings... > > Here is the patch to fix this: Applied. Thanks for the fix! Thanks, Mauro ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [git:v4l-dvb/v2.6.37] [media] Add driver for Siliconfile SR030PC30 VGA camera 2010-10-17 20:14 ` [git:v4l-dvb/v2.6.37] [media] Add driver for Siliconfile SR030PC30 VGA camera Hans Verkuil 2010-10-17 21:30 ` Mauro Carvalho Chehab @ 2010-10-18 12:58 ` Sylwester Nawrocki 2010-10-18 13:14 ` Mauro Carvalho Chehab 1 sibling, 1 reply; 5+ messages in thread From: Sylwester Nawrocki @ 2010-10-18 12:58 UTC (permalink / raw) To: Hans Verkuil; +Cc: Mauro Carvalho Chehab, linux-media, Kyungmin Park Hello Hans, On 10/17/2010 10:14 PM, Hans Verkuil wrote: > On Sunday, October 17, 2010 21:28:29 Mauro Carvalho Chehab wrote: >> This is an automatic generated email to let you know that the following patch were queued at the >> http://git.linuxtv.org/media_tree.git tree: >> >> Subject: [media] Add driver for Siliconfile SR030PC30 VGA camera >> Author: Sylwester Nawrocki <s.nawrocki@samsung.com> >> Date: Mon Oct 11 13:33:57 2010 -0300 >> [snip] > It fails to compile with this error: > > drivers/media/video/sr030pc30.c: In function ‘sr030pc30_probe’: > drivers/media/video/sr030pc30.c:834: error: implicit declaration of function ‘kzalloc’ > drivers/media/video/sr030pc30.c:834: warning: assignment makes pointer from integer without a cast > drivers/media/video/sr030pc30.c: In function ‘sr030pc30_remove’: > drivers/media/video/sr030pc30.c:858: error: implicit declaration of function ‘kfree’ > > Here is the patch to fix this: [snip] > Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> > Thank you for fixing this. I will definitely improve my test environment so this kind of errors do not appear in the future. Regards, Sylwester -- Sylwester Nawrocki Linux Platform Group Samsung Poland R&D Center ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [git:v4l-dvb/v2.6.37] [media] Add driver for Siliconfile SR030PC30 VGA camera 2010-10-18 12:58 ` Sylwester Nawrocki @ 2010-10-18 13:14 ` Mauro Carvalho Chehab 2010-10-18 13:21 ` Hans Verkuil 0 siblings, 1 reply; 5+ messages in thread From: Mauro Carvalho Chehab @ 2010-10-18 13:14 UTC (permalink / raw) To: Sylwester Nawrocki; +Cc: Hans Verkuil, linux-media, Kyungmin Park Em 18-10-2010 10:58, Sylwester Nawrocki escreveu: > > Hello Hans, > > On 10/17/2010 10:14 PM, Hans Verkuil wrote: >> On Sunday, October 17, 2010 21:28:29 Mauro Carvalho Chehab wrote: >>> This is an automatic generated email to let you know that the following patch were queued at the >>> http://git.linuxtv.org/media_tree.git tree: >>> >>> Subject: [media] Add driver for Siliconfile SR030PC30 VGA camera >>> Author: Sylwester Nawrocki <s.nawrocki@samsung.com> >>> Date: Mon Oct 11 13:33:57 2010 -0300 >>> > [snip] >> It fails to compile with this error: >> >> drivers/media/video/sr030pc30.c: In function ‘sr030pc30_probe’: >> drivers/media/video/sr030pc30.c:834: error: implicit declaration of function ‘kzalloc’ >> drivers/media/video/sr030pc30.c:834: warning: assignment makes pointer from integer without a cast >> drivers/media/video/sr030pc30.c: In function ‘sr030pc30_remove’: >> drivers/media/video/sr030pc30.c:858: error: implicit declaration of function ‘kfree’ >> >> Here is the patch to fix this: > [snip] >> Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> >> > > Thank you for fixing this. I will definitely improve my test environment > so this kind of errors do not appear in the future. I suspect that, depending on what are compiled, slab.h is included on some cases, as, on my tests with allyesconfig, I didn't notice the need for slab.h. Cheers, Mauro ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [git:v4l-dvb/v2.6.37] [media] Add driver for Siliconfile SR030PC30 VGA camera 2010-10-18 13:14 ` Mauro Carvalho Chehab @ 2010-10-18 13:21 ` Hans Verkuil 0 siblings, 0 replies; 5+ messages in thread From: Hans Verkuil @ 2010-10-18 13:21 UTC (permalink / raw) To: Mauro Carvalho Chehab; +Cc: Sylwester Nawrocki, linux-media, Kyungmin Park > Em 18-10-2010 10:58, Sylwester Nawrocki escreveu: >> >> Hello Hans, >> >> On 10/17/2010 10:14 PM, Hans Verkuil wrote: >>> On Sunday, October 17, 2010 21:28:29 Mauro Carvalho Chehab wrote: >>>> This is an automatic generated email to let you know that the >>>> following patch were queued at the >>>> http://git.linuxtv.org/media_tree.git tree: >>>> >>>> Subject: [media] Add driver for Siliconfile SR030PC30 VGA camera >>>> Author: Sylwester Nawrocki <s.nawrocki@samsung.com> >>>> Date: Mon Oct 11 13:33:57 2010 -0300 >>>> >> [snip] >>> It fails to compile with this error: >>> >>> drivers/media/video/sr030pc30.c: In function ‘sr030pc30_probe’: >>> drivers/media/video/sr030pc30.c:834: error: implicit declaration of >>> function ‘kzalloc’ >>> drivers/media/video/sr030pc30.c:834: warning: assignment makes pointer >>> from integer without a cast >>> drivers/media/video/sr030pc30.c: In function ‘sr030pc30_remove’: >>> drivers/media/video/sr030pc30.c:858: error: implicit declaration of >>> function ‘kfree’ >>> >>> Here is the patch to fix this: >> [snip] >>> Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> >>> >> >> Thank you for fixing this. I will definitely improve my test environment >> so this kind of errors do not appear in the future. > > I suspect that, depending on what are compiled, slab.h is included on some > cases, as, > on my tests with allyesconfig, I didn't notice the need for slab.h. For the record: this was a x86_64 compilation. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-10-18 13:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1P7Yvq-0001kW-Pf@www.linuxtv.org>
2010-10-17 20:14 ` [git:v4l-dvb/v2.6.37] [media] Add driver for Siliconfile SR030PC30 VGA camera Hans Verkuil
2010-10-17 21:30 ` Mauro Carvalho Chehab
2010-10-18 12:58 ` Sylwester Nawrocki
2010-10-18 13:14 ` Mauro Carvalho Chehab
2010-10-18 13:21 ` Hans Verkuil
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox