Re: [git:v4l-dvb/v2.6.37] [media] Add driver for Siliconfile SR030PC30 VGA camera

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 18-10-2010 10:58, Sylwester Nawrocki escreveu:
> 
> Hello Hans,
> 
> On 10/17/2010 10:14 PM, Hans Verkuil wrote:
>> On Sunday, October 17, 2010 21:28:29 Mauro Carvalho Chehab wrote:
>>> This is an automatic generated email to let you know that the following patch were queued at the 
>>> http://git.linuxtv.org/media_tree.git tree:
>>>
>>> Subject: [media] Add driver for Siliconfile SR030PC30 VGA camera
>>> Author:  Sylwester Nawrocki <s.nawrocki@samsung.com>
>>> Date:    Mon Oct 11 13:33:57 2010 -0300
>>>
> [snip]
>> It fails to compile with this error:
>>
>> drivers/media/video/sr030pc30.c: In function ‘sr030pc30_probe’:
>> drivers/media/video/sr030pc30.c:834: error: implicit declaration of function ‘kzalloc’
>> drivers/media/video/sr030pc30.c:834: warning: assignment makes pointer from integer without a cast
>> drivers/media/video/sr030pc30.c: In function ‘sr030pc30_remove’:
>> drivers/media/video/sr030pc30.c:858: error: implicit declaration of function ‘kfree’
>>
>> Here is the patch to fix this:
> [snip]
>> Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
>>
> 
> Thank you for fixing this. I will definitely improve my test environment
> so this kind of errors do not appear in the future.

I suspect that, depending on what are compiled, slab.h is included on some cases, as,
on my tests with allyesconfig, I didn't notice the need for slab.h.

Cheers,
Mauro