* [PATCH] stb0899: Removed an extra byte sent at init on DiSEqC bus @ 2010-06-11 16:01 Florent AUDEBERT 2010-10-19 12:55 ` Florent AUDEBERT 0 siblings, 1 reply; 6+ messages in thread From: Florent AUDEBERT @ 2010-06-11 16:01 UTC (permalink / raw) To: linux-media; +Cc: abraham.manu, Florent Audebert Hi, I noticed a stray 0x00 at init on DiSEqC bus (KNC1 DVB-S2) with a DiSEqC tool analyzer. I removed the register from initialization table and all seem to go well (at least for my KNC board). Regards, Signed-off-by: Florent Audebert <florent.audebert@anevia.com> --- drivers/media/dvb/dvb-usb/az6027.c | 1 - drivers/media/dvb/mantis/mantis_vp1041.c | 1 - drivers/media/dvb/ttpci/budget-av.c | 1 - drivers/media/dvb/ttpci/budget-ci.c | 1 - 4 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/az6027.c b/drivers/media/dvb/dvb-usb/az6027.c index 6681ac1..9710e7b 100644 --- a/drivers/media/dvb/dvb-usb/az6027.c +++ b/drivers/media/dvb/dvb-usb/az6027.c @@ -40,7 +40,6 @@ static const struct stb0899_s1_reg az6027_stb0899_s1_init_1[] = { { STB0899_DISRX_ST0 , 0x04 }, { STB0899_DISRX_ST1 , 0x00 }, { STB0899_DISPARITY , 0x00 }, - { STB0899_DISFIFO , 0x00 }, { STB0899_DISSTATUS , 0x20 }, { STB0899_DISF22 , 0x99 }, { STB0899_DISF22RX , 0xa8 }, diff --git a/drivers/media/dvb/mantis/mantis_vp1041.c b/drivers/media/dvb/mantis/mantis_vp1041.c index d1aa2bc..7bb1f28 100644 --- a/drivers/media/dvb/mantis/mantis_vp1041.c +++ b/drivers/media/dvb/mantis/mantis_vp1041.c @@ -51,7 +51,6 @@ static const struct stb0899_s1_reg vp1041_stb0899_s1_init_1[] = { { STB0899_DISRX_ST0 , 0x04 }, { STB0899_DISRX_ST1 , 0x00 }, { STB0899_DISPARITY , 0x00 }, - { STB0899_DISFIFO , 0x00 }, { STB0899_DISSTATUS , 0x20 }, { STB0899_DISF22 , 0x99 }, { STB0899_DISF22RX , 0xa8 }, diff --git a/drivers/media/dvb/ttpci/budget-av.c b/drivers/media/dvb/ttpci/budget-av.c index 983672a..b697af4 100644 --- a/drivers/media/dvb/ttpci/budget-av.c +++ b/drivers/media/dvb/ttpci/budget-av.c @@ -896,7 +896,6 @@ static const struct stb0899_s1_reg knc1_stb0899_s1_init_1[] = { { STB0899_DISRX_ST0 , 0x04 }, { STB0899_DISRX_ST1 , 0x00 }, { STB0899_DISPARITY , 0x00 }, - { STB0899_DISFIFO , 0x00 }, { STB0899_DISSTATUS , 0x20 }, { STB0899_DISF22 , 0x8c }, { STB0899_DISF22RX , 0x9a }, diff --git a/drivers/media/dvb/ttpci/budget-ci.c b/drivers/media/dvb/ttpci/budget-ci.c index 13ac9e3..da5a72c 100644 --- a/drivers/media/dvb/ttpci/budget-ci.c +++ b/drivers/media/dvb/ttpci/budget-ci.c @@ -1046,7 +1046,6 @@ static const struct stb0899_s1_reg tt3200_stb0899_s1_init_1[] = { { STB0899_DISRX_ST0 , 0x04 }, { STB0899_DISRX_ST1 , 0x00 }, { STB0899_DISPARITY , 0x00 }, - { STB0899_DISFIFO , 0x00 }, { STB0899_DISSTATUS , 0x20 }, { STB0899_DISF22 , 0x8c }, { STB0899_DISF22RX , 0x9a }, -- 1.7.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] stb0899: Removed an extra byte sent at init on DiSEqC bus 2010-06-11 16:01 [PATCH] stb0899: Removed an extra byte sent at init on DiSEqC bus Florent AUDEBERT @ 2010-10-19 12:55 ` Florent AUDEBERT 2010-10-19 16:05 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 6+ messages in thread From: Florent AUDEBERT @ 2010-10-19 12:55 UTC (permalink / raw) To: linux-media; +Cc: abraham.manu, Florent Audebert On 06/11/2010 06:01 PM, Florent AUDEBERT wrote: > I noticed a stray 0x00 at init on DiSEqC bus (KNC1 DVB-S2) with a DiSEqC > tool analyzer. > > I removed the register from initialization table and all seem to go well > (at least for my KNC board). Hi, This old small patch had been marked superseded on patchwork[1]. Is there an non-obvious case when patches go superseded ? Perhaps I missed something but it seems to me no other patch replaced it. Regards, [1] https://patchwork.kernel.org/patch/105621/ -- Florent AUDEBERT ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] stb0899: Removed an extra byte sent at init on DiSEqC bus 2010-10-19 12:55 ` Florent AUDEBERT @ 2010-10-19 16:05 ` Mauro Carvalho Chehab 2011-06-01 13:57 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 6+ messages in thread From: Mauro Carvalho Chehab @ 2010-10-19 16:05 UTC (permalink / raw) To: Florent AUDEBERT, abraham.manu; +Cc: linux-media, Florent Audebert Em 19-10-2010 10:55, Florent AUDEBERT escreveu: > On 06/11/2010 06:01 PM, Florent AUDEBERT wrote: >> I noticed a stray 0x00 at init on DiSEqC bus (KNC1 DVB-S2) with a DiSEqC >> tool analyzer. >> >> I removed the register from initialization table and all seem to go well >> (at least for my KNC board). > > Hi, > > This old small patch had been marked superseded on patchwork[1]. > > Is there an non-obvious case when patches go superseded ? Perhaps I missed > something but it seems to me no other patch replaced it. This is one of the bad things with patchwork: there's no "reason" field associated to a status change, nor it marks when the status were changed. A search on my linux-media box, showed that this patch were there, waiting for Manu review, at the email I sent on Jul, 6 2010. The patch still applies, and I didn't find any reply from Manu giving any feedback about it. So, I'm re-tagging it as under review. Manu, any comments about this patch (and the other remaining patches that we're waiting fro your review) ? > > > Regards, > > > [1] https://patchwork.kernel.org/patch/105621/ > Cheers, Mauro ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] stb0899: Removed an extra byte sent at init on DiSEqC bus 2010-10-19 16:05 ` Mauro Carvalho Chehab @ 2011-06-01 13:57 ` Mauro Carvalho Chehab 2011-06-01 16:24 ` Manu Abraham 0 siblings, 1 reply; 6+ messages in thread From: Mauro Carvalho Chehab @ 2011-06-01 13:57 UTC (permalink / raw) To: abraham.manu; +Cc: Florent AUDEBERT, linux-media, Florent Audebert Em 19-10-2010 14:05, Mauro Carvalho Chehab escreveu: > Em 19-10-2010 10:55, Florent AUDEBERT escreveu: >> On 06/11/2010 06:01 PM, Florent AUDEBERT wrote: >>> I noticed a stray 0x00 at init on DiSEqC bus (KNC1 DVB-S2) with a DiSEqC >>> tool analyzer. >>> >>> I removed the register from initialization table and all seem to go well >>> (at least for my KNC board). >> >> Hi, >> >> This old small patch had been marked superseded on patchwork[1]. >> >> Is there an non-obvious case when patches go superseded ? Perhaps I missed >> something but it seems to me no other patch replaced it. > > This is one of the bad things with patchwork: there's no "reason" field associated > to a status change, nor it marks when the status were changed. > > A search on my linux-media box, showed that this patch were there, waiting for > Manu review, at the email I sent on Jul, 6 2010. The patch still applies, and > I didn't find any reply from Manu giving any feedback about it. > > So, I'm re-tagging it as under review. > > Manu, any comments about this patch (and the other remaining patches that we're > waiting fro your review) ? Manu, Please ack or nack this patch. It was sent about 1,5 years ago! if you don't comment, I'll assume that this patch is ok and I'll apply it. Thanks, Mauro. Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: stb0899: Removed an extra byte sent at init on DiSEqC bus Date: Fri, 11 Jun 2010 16:01:25 -0000 From: Florent AUDEBERT <florent.audebert@anevia.com> X-Patchwork-Id: 105621 Message-Id: <4C125DD5.6060604@anevia.com> To: linux-media@vger.kernel.org Cc: abraham.manu@gmail.com, Florent Audebert <faudebert@anevia.com> diff --git a/drivers/media/dvb/dvb-usb/az6027.c b/drivers/media/dvb/dvb-usb/az6027.c index 6681ac1..9710e7b 100644 --- a/drivers/media/dvb/dvb-usb/az6027.c +++ b/drivers/media/dvb/dvb-usb/az6027.c @@ -40,7 +40,6 @@ static const struct stb0899_s1_reg az6027_stb0899_s1_init_1[] = { { STB0899_DISRX_ST0 , 0x04 }, { STB0899_DISRX_ST1 , 0x00 }, { STB0899_DISPARITY , 0x00 }, - { STB0899_DISFIFO , 0x00 }, { STB0899_DISSTATUS , 0x20 }, { STB0899_DISF22 , 0x99 }, { STB0899_DISF22RX , 0xa8 }, diff --git a/drivers/media/dvb/mantis/mantis_vp1041.c b/drivers/media/dvb/mantis/mantis_vp1041.c index d1aa2bc..7bb1f28 100644 --- a/drivers/media/dvb/mantis/mantis_vp1041.c +++ b/drivers/media/dvb/mantis/mantis_vp1041.c @@ -51,7 +51,6 @@ static const struct stb0899_s1_reg vp1041_stb0899_s1_init_1[] = { { STB0899_DISRX_ST0 , 0x04 }, { STB0899_DISRX_ST1 , 0x00 }, { STB0899_DISPARITY , 0x00 }, - { STB0899_DISFIFO , 0x00 }, { STB0899_DISSTATUS , 0x20 }, { STB0899_DISF22 , 0x99 }, { STB0899_DISF22RX , 0xa8 }, diff --git a/drivers/media/dvb/ttpci/budget-av.c b/drivers/media/dvb/ttpci/budget-av.c index 983672a..b697af4 100644 --- a/drivers/media/dvb/ttpci/budget-av.c +++ b/drivers/media/dvb/ttpci/budget-av.c @@ -896,7 +896,6 @@ static const struct stb0899_s1_reg knc1_stb0899_s1_init_1[] = { { STB0899_DISRX_ST0 , 0x04 }, { STB0899_DISRX_ST1 , 0x00 }, { STB0899_DISPARITY , 0x00 }, - { STB0899_DISFIFO , 0x00 }, { STB0899_DISSTATUS , 0x20 }, { STB0899_DISF22 , 0x8c }, { STB0899_DISF22RX , 0x9a }, diff --git a/drivers/media/dvb/ttpci/budget-ci.c b/drivers/media/dvb/ttpci/budget-ci.c index 13ac9e3..da5a72c 100644 --- a/drivers/media/dvb/ttpci/budget-ci.c +++ b/drivers/media/dvb/ttpci/budget-ci.c @@ -1046,7 +1046,6 @@ static const struct stb0899_s1_reg tt3200_stb0899_s1_init_1[] = { { STB0899_DISRX_ST0 , 0x04 }, { STB0899_DISRX_ST1 , 0x00 }, { STB0899_DISPARITY , 0x00 }, - { STB0899_DISFIFO , 0x00 }, { STB0899_DISSTATUS , 0x20 }, { STB0899_DISF22 , 0x8c }, { STB0899_DISF22RX , 0x9a }, ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] stb0899: Removed an extra byte sent at init on DiSEqC bus 2011-06-01 13:57 ` Mauro Carvalho Chehab @ 2011-06-01 16:24 ` Manu Abraham 2011-06-01 18:56 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 6+ messages in thread From: Manu Abraham @ 2011-06-01 16:24 UTC (permalink / raw) To: Mauro Carvalho Chehab; +Cc: Florent AUDEBERT, linux-media, Florent Audebert On 6/1/11, Mauro Carvalho Chehab <mchehab@redhat.com> wrote: > Em 19-10-2010 14:05, Mauro Carvalho Chehab escreveu: >> Em 19-10-2010 10:55, Florent AUDEBERT escreveu: >>> On 06/11/2010 06:01 PM, Florent AUDEBERT wrote: >>>> I noticed a stray 0x00 at init on DiSEqC bus (KNC1 DVB-S2) with a DiSEqC >>>> tool analyzer. >>>> >>>> I removed the register from initialization table and all seem to go well >>>> (at least for my KNC board). >>> >>> Hi, >>> >>> This old small patch had been marked superseded on patchwork[1]. >>> >>> Is there an non-obvious case when patches go superseded ? Perhaps I >>> missed >>> something but it seems to me no other patch replaced it. >> >> This is one of the bad things with patchwork: there's no "reason" field >> associated >> to a status change, nor it marks when the status were changed. >> >> A search on my linux-media box, showed that this patch were there, waiting >> for >> Manu review, at the email I sent on Jul, 6 2010. The patch still applies, >> and >> I didn't find any reply from Manu giving any feedback about it. >> >> So, I'm re-tagging it as under review. >> >> Manu, any comments about this patch (and the other remaining patches that >> we're >> waiting fro your review) ? > > Manu, > > Please ack or nack this patch. It was sent about 1,5 years ago! if you don't > comment, I'll assume that this patch is ok and I'll apply it. > > Thanks, > Mauro. Mauro, I have been away from home and not yet back due to a nasty back sprain, but expect to return mid next week. Please hold off on the patches that you need inputs from my side. I will get back on these, the following weekend. Sorry about any inconvenience caused. Thanks, Manu ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] stb0899: Removed an extra byte sent at init on DiSEqC bus 2011-06-01 16:24 ` Manu Abraham @ 2011-06-01 18:56 ` Mauro Carvalho Chehab 0 siblings, 0 replies; 6+ messages in thread From: Mauro Carvalho Chehab @ 2011-06-01 18:56 UTC (permalink / raw) To: Manu Abraham; +Cc: Florent AUDEBERT, linux-media, Florent Audebert Em 01-06-2011 13:24, Manu Abraham escreveu: > On 6/1/11, Mauro Carvalho Chehab <mchehab@redhat.com> wrote: > Mauro, > > I have been away from home and not yet back due to a nasty back > sprain, but expect to return mid next week. Sorry to hear about it. I hope you to recover soon from the sprain. > Please hold off on the > patches that you need inputs from my side. I will get back on these, > the following weekend. > Sorry about any inconvenience caused. Ok. Thanks! Mauro > > Thanks, > Manu > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-01 18:56 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-06-11 16:01 [PATCH] stb0899: Removed an extra byte sent at init on DiSEqC bus Florent AUDEBERT 2010-10-19 12:55 ` Florent AUDEBERT 2010-10-19 16:05 ` Mauro Carvalho Chehab 2011-06-01 13:57 ` Mauro Carvalho Chehab 2011-06-01 16:24 ` Manu Abraham 2011-06-01 18:56 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox