From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michael Krufky <mkrufky@kernellabs.com>
Subject: Re: [GIT PULL for 2.6.37-rc1] V4L/DVB updates
Date: Wed, 27 Oct 2010 14:52:01 -0200 [thread overview]
Message-ID: <4CC858B1.6090408@redhat.com> (raw)
In-Reply-To: <4CC8558C.3000209@gmail.com>
Em 27-10-2010 14:38, Jiri Slaby escreveu:
> On 10/27/2010 06:36 PM, Mauro Carvalho Chehab wrote:
>> Basically, af9015 broke due to (3), as .small_i2c = 1 means nothing. It should be using
>> .small_i2c = TDA18271_16_BYTE_CHUNK_INIT, instead.
>>
>> What I don't understand is why a patch doing this change didn't fix the issue. Please
>> test the patch I posted on the original -next thread. Let's try to identify why
>> tda18271_write_regs() is not breaking the data into smaller writes.
>
> It helps, but one needs to unplug and replug the device. So care to
> respin the pull request with the patch included?
AH! Yes, this is sometimes needed on some hardware: when a longer or wrong I2C transaction
is received, the hardware simply stops working. You need to replug it for it to return to
life.
Ok, I'll add the patch that changes it to .small_i2c = TDA18271_16_BYTE_CHUNK_INIT
to the series.
Thanks,
Mauro.
next prev parent reply other threads:[~2010-10-27 16:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 14:32 [GIT PULL for 2.6.37-rc1] V4L/DVB updates Mauro Carvalho Chehab
2010-10-27 15:30 ` Jiri Slaby
2010-10-27 15:41 ` Mauro Carvalho Chehab
2010-10-27 15:48 ` Devin Heitmueller
2010-10-27 16:46 ` Mauro Carvalho Chehab
2010-10-27 17:52 ` Devin Heitmueller
2010-10-27 15:53 ` Jiri Slaby
2010-10-27 16:36 ` Mauro Carvalho Chehab
2010-10-27 16:38 ` Jiri Slaby
2010-10-27 16:52 ` Mauro Carvalho Chehab [this message]
2010-10-27 17:39 ` Hans de Goede
2010-10-27 17:52 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC858B1.6090408@redhat.com \
--to=mchehab@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mkrufky@kernellabs.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox