From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Arnaud Lacombe <lacombar@gmail.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
Michal Marek <mmarek@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>,
kyle@redhat.com, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: REGRESSION: Re: [GIT] kconfig rc fixes
Date: Thu, 04 Nov 2010 14:51:24 -0400 [thread overview]
Message-ID: <4CD300AC.3010708@redhat.com> (raw)
In-Reply-To: <AANLkTikx+RkV82Cb1YQfYNzVWpMqRQOnvhNY4LtS64FC@mail.gmail.com>
Em 04-11-2010 14:32, Arnaud Lacombe escreveu:
> Hi,
>
> On Thu, Nov 4, 2010 at 2:11 PM, Mauro Carvalho Chehab
> <mchehab@redhat.com> wrote:
>> [...]
>> Yes, but this makes things worse: it will allow compiling drivers that Kernel
>> will never use, as they won't work without an I2C adapter, and the I2C adapter
>> is not compiled.
>>
>> Worse than that: if you go into all V4L bridge drivers, that implements the I2C
>> adapters and disable them, the I2C ancillary adapters will still be compiled
>> (as they won't return to 'n'), but they will never ever be used...
>>
>> So, no, this is not a solution.
>>
>> What we need is to prompt the menu only if the user wants to do some manual configuration.
>> Otherwise, just use the selects done by the drivers that implement the I2C bus adapters,
>> and have some code to use those selected I2C devices.
>>
> These is an easy solution: doing as
> `Documentation/kbuild/kconfig-language.txt' say it should be done:
>
> config MODULES
> bool "modules ?"
> default y
>
> config AUTO
> bool "AUTO"
>
> config IVTV
> tristate "IVTV"
> select WM42 if AUTO
>
> menu "TV"
> depends on !AUTO
>
> config WM42_USER
> tristate "WM42"
> select WM42
>
> endmenu
>
> config WM42
> tristate
> default n
>
> - Arnaud
This may work, but it means that every single I2C/frontend/tuner will require two
entries for each driver. This means to create and manage around 100+ new symbols.
The drivers/media Kconfig files are complex enough as-is, without adding those 100+
new artificial symbols. We should work to make things simple and improve users experience,
and not to create artificial complexity that will make Kconfig almost unreadable.
I still think that the easiest way to solve this is to add some logic that will
hide the menu if a condition doesn't happen. Something like:
menu FOO
prompt if BAR
or
menu FOO
show if BAR
Mauro.
next prev parent reply other threads:[~2010-11-04 18:51 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101009224041.GA901@sepie.suse.cz>
2010-11-03 22:29 ` REGRESSION: Re: [GIT] kconfig rc fixes Mauro Carvalho Chehab
2010-11-03 22:47 ` Michal Marek
2010-11-03 23:02 ` Mauro Carvalho Chehab
2010-11-04 2:31 ` Arnaud Lacombe
2010-11-04 3:19 ` Mauro Carvalho Chehab
2010-11-04 4:02 ` Arnaud Lacombe
2010-11-04 4:15 ` Arnaud Lacombe
2010-11-04 11:10 ` Mauro Carvalho Chehab
2010-11-04 17:19 ` Randy Dunlap
2010-11-04 18:11 ` Mauro Carvalho Chehab
2010-11-04 18:32 ` Arnaud Lacombe
2010-11-04 18:51 ` Mauro Carvalho Chehab [this message]
2010-11-05 12:02 ` Jean Delvare
2010-11-06 21:30 ` [PATCH 0/5] " Arnaud Lacombe
2010-11-06 22:28 ` Mauro Carvalho Chehab
2010-11-09 17:32 ` Mauro Carvalho Chehab
2010-11-06 21:30 ` [PATCH 1/5] kconfig: add an option to determine a menu's visibility Arnaud Lacombe
2010-11-15 16:57 ` Arnaud Lacombe
2010-11-16 17:44 ` Mauro Carvalho Chehab
2010-11-16 21:41 ` Arnaud Lacombe
2010-11-16 21:52 ` Sam Ravnborg
[not found] ` <AANLkTi=WS6cveqzxVmwC2wucaCpEJJLHXx0A8XbAChRb@mail.gmail.com>
[not found] ` <4CEF8C74.8010600@suse.cz>
[not found] ` <20101126161511.GD9418@sepie.suse.cz>
[not found] ` <20101126081736.0ba8a90b.rdunlap@xenotime.net>
2011-04-28 17:38 ` Randy Dunlap
2011-05-02 15:33 ` Michal Marek
2010-11-06 21:30 ` [PATCH 2/5] kconfig: regen parser Arnaud Lacombe
2010-11-06 21:30 ` [PATCH 3/5] Revert "i2c: Fix Kconfig dependencies" Arnaud Lacombe
2010-11-06 21:30 ` [PATCH 4/5] media/video: convert Kconfig to use the menu's `visible' keyword Arnaud Lacombe
2010-11-06 21:30 ` [PATCH 5/5] i2c/algos: " Arnaud Lacombe
2010-11-04 18:34 ` REGRESSION: Re: [GIT] kconfig rc fixes Arnaud Lacombe
2010-11-04 18:43 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD300AC.3010708@redhat.com \
--to=mchehab@redhat.com \
--cc=kyle@redhat.com \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=randy.dunlap@oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox