From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
LMML <linux-media@vger.kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Jarod Wilson <jarod@redhat.com>
Subject: Re: [PATCH 3/3] i2c: Mark i2c_adapter.id as deprecated
Date: Sat, 13 Nov 2010 12:37:03 -0200 [thread overview]
Message-ID: <4CDEA28F.8040507@redhat.com> (raw)
In-Reply-To: <20101105211001.1cc93ac7@endymion.delvare>
Em 05-11-2010 18:10, Jean Delvare escreveu:
> It's about time to make it clear that i2c_adapter.id is deprecated.
> Hopefully this will remind the last user to move over to a different
> strategy.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Hans Verkuil <hverkuil@xs4all.nl>
> Cc: Jarod Wilson <jarod@redhat.com>
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> ---
> drivers/i2c/i2c-mux.c | 1 -
> include/linux/i2c.h | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> --- linux-2.6.37-rc1.orig/include/linux/i2c.h 2010-11-05 13:55:17.000000000 +0100
> +++ linux-2.6.37-rc1/include/linux/i2c.h 2010-11-05 15:41:20.000000000 +0100
> @@ -353,7 +353,7 @@ struct i2c_algorithm {
> */
> struct i2c_adapter {
> struct module *owner;
> - unsigned int id;
> + unsigned int id __deprecated;
> unsigned int class; /* classes to allow probing for */
> const struct i2c_algorithm *algo; /* the algorithm to access the bus */
> void *algo_data;
> --- linux-2.6.37-rc1.orig/drivers/i2c/i2c-mux.c 2010-11-05 16:06:18.000000000 +0100
> +++ linux-2.6.37-rc1/drivers/i2c/i2c-mux.c 2010-11-05 16:06:33.000000000 +0100
> @@ -120,7 +120,6 @@ struct i2c_adapter *i2c_add_mux_adapter(
> snprintf(priv->adap.name, sizeof(priv->adap.name),
> "i2c-%d-mux (chan_id %d)", i2c_adapter_id(parent), chan_id);
> priv->adap.owner = THIS_MODULE;
> - priv->adap.id = parent->id;
> priv->adap.algo = &priv->algo;
> priv->adap.algo_data = priv;
> priv->adap.dev.parent = &parent->dev;
>
>
next prev parent reply other threads:[~2010-11-13 14:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 20:10 [PATCH 3/3] i2c: Mark i2c_adapter.id as deprecated Jean Delvare
2010-11-07 18:57 ` Jarod Wilson
2010-11-13 14:37 ` Mauro Carvalho Chehab [this message]
2010-11-13 14:40 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDEA28F.8040507@redhat.com \
--to=mchehab@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=jarod@redhat.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox