Translation faults with OMAP ISP

Translation faults with OMAP ISP

[Lane Brooks]

Laurent,

I am getting iommu translation errors when I try to use the CCDC output 
after using the Resizer output.

If I use the CCDC output to stream some video, then close it down, 
switch to the Resizer output and open it up and try to stream, I get the 
following errors spewing out:

omap-iommu omap-iommu.0: omap2_iommu_fault_isr: da:00d0ef00 translation 
fault
omap-iommu omap-iommu.0: iommu_fault_handler: da:00d0ef00 pgd:ce664034 
*pgd:00000000

and the select times out.

 From a fresh boot, I can stream just fine from the Resizer and then 
switch to the CCDC output just fine. It is only when I go from the CCDC 
to the Resizer that I get this problem. Furthermore, when it gets into 
this state, then anything dev node I try to use has the translation 
errors and the only way to recover is to reboot.

Any ideas on the problem?

Thanks,
Lane

Re: Translation faults with OMAP ISP

[Laurent Pinchart]

Hi Lane,

On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
> Laurent,
> 
> I am getting iommu translation errors when I try to use the CCDC output
> after using the Resizer output.
> 
> If I use the CCDC output to stream some video, then close it down,
> switch to the Resizer output and open it up and try to stream, I get the
> following errors spewing out:
> 
> omap-iommu omap-iommu.0: omap2_iommu_fault_isr: da:00d0ef00 translation
> fault
> omap-iommu omap-iommu.0: iommu_fault_handler: da:00d0ef00 pgd:ce664034
> *pgd:00000000
> 
> and the select times out.
> 
>  From a fresh boot, I can stream just fine from the Resizer and then
> switch to the CCDC output just fine. It is only when I go from the CCDC
> to the Resizer that I get this problem. Furthermore, when it gets into
> this state, then anything dev node I try to use has the translation
> errors and the only way to recover is to reboot.
> 
> Any ideas on the problem?

Ouch. First of all, could you please make sure you run the latest code ? Many 
bugs have been fixed in the last few months.

-- 
Regards,

Laurent Pinchart

Re: Translation faults with OMAP ISP

[Lane Brooks]

On 11/17/2010 04:09 PM, Laurent Pinchart wrote:
> Hi Lane,
>
> On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
>> Laurent,
>>
>> I am getting iommu translation errors when I try to use the CCDC output
>> after using the Resizer output.
>>
>> If I use the CCDC output to stream some video, then close it down,
>> switch to the Resizer output and open it up and try to stream, I get the
>> following errors spewing out:
>>
>> omap-iommu omap-iommu.0: omap2_iommu_fault_isr: da:00d0ef00 translation
>> fault
>> omap-iommu omap-iommu.0: iommu_fault_handler: da:00d0ef00 pgd:ce664034
>> *pgd:00000000
>>
>> and the select times out.
>>
>>   From a fresh boot, I can stream just fine from the Resizer and then
>> switch to the CCDC output just fine. It is only when I go from the CCDC
>> to the Resizer that I get this problem. Furthermore, when it gets into
>> this state, then anything dev node I try to use has the translation
>> errors and the only way to recover is to reboot.
>>
>> Any ideas on the problem?
> Ouch. First of all, could you please make sure you run the latest code ? Many
> bugs have been fixed in the last few months

I had a pretty good idea that this would be your response, but I was 
hoping otherwise as merging has become more and more difficult to keep 
up with. Anyway, until I have a chance to merge in everything, I just 
found a work around for our usage needs, and that is to always use the 
resizer output and just change the resizer format between full 
resolution and preview resolution. This has turned out to be much more 
stable than switching between the CCDC and RESIZER dev nodes.

Thanks again for your feedback.

Lane

Re: Translation faults with OMAP ISP

[David Cohen]

Hi Lane,

On Thu, Nov 18, 2010 at 12:17:21AM +0100, ext Lane Brooks wrote:
> On 11/17/2010 04:09 PM, Laurent Pinchart wrote:
> > Hi Lane,
> >
> > On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
> >> Laurent,
> >>
> >> I am getting iommu translation errors when I try to use the CCDC output
> >> after using the Resizer output.
> >>
> >> If I use the CCDC output to stream some video, then close it down,
> >> switch to the Resizer output and open it up and try to stream, I get the
> >> following errors spewing out:
> >>
> >> omap-iommu omap-iommu.0: omap2_iommu_fault_isr: da:00d0ef00 translation
> >> fault
> >> omap-iommu omap-iommu.0: iommu_fault_handler: da:00d0ef00 pgd:ce664034
> >> *pgd:00000000
> >>
> >> and the select times out.
> >>
> >>   From a fresh boot, I can stream just fine from the Resizer and then
> >> switch to the CCDC output just fine. It is only when I go from the CCDC
> >> to the Resizer that I get this problem. Furthermore, when it gets into
> >> this state, then anything dev node I try to use has the translation
> >> errors and the only way to recover is to reboot.
> >>
> >> Any ideas on the problem?
> > Ouch. First of all, could you please make sure you run the latest code ? Many
> > bugs have been fixed in the last few months
> 
> I had a pretty good idea that this would be your response, but I was 
> hoping otherwise as merging has become more and more difficult to keep 
> up with. Anyway, until I have a chance to merge in everything, I just 
> found a work around for our usage needs, and that is to always use the 
> resizer output and just change the resizer format between full 
> resolution and preview resolution. This has turned out to be much more 
> stable than switching between the CCDC and RESIZER dev nodes.

I'm not sure if it's your case, but OMAP3 ISP driver does not support
pipeline with multiples outputs yet. We have to return error from the
driver in this case. If you configured CCDC to write to memory and then
to write to preview/resizer afterwards without deactivating the link to
write to memory, you may face a similar problem you described.

Can you please try a patch I've sent to you (CC'ing linux-media) with subject:
"[omap3isp][PATCH] omap3isp: does not allow pipeline with multiple video
outputs yet"?

Regards,

David


> 
> Thanks again for your feedback.
> 
> Lane
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Translation faults with OMAP ISP

[Lane Brooks]

On 11/19/2010 06:29 AM, David Cohen wrote:
> On Thu, Nov 18, 2010 at 12:17:21AM +0100, ext Lane Brooks wrote:
>> On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
>>>> Laurent,
>>>>
>>>> I am getting iommu translation errors when I try to use the CCDC output
>>>> after using the Resizer output.
>>>>
>>>> If I use the CCDC output to stream some video, then close it down,
>>>> switch to the Resizer output and open it up and try to stream, I get the
>>>> following errors spewing out:
>>>>
>>>> omap-iommu omap-iommu.0: omap2_iommu_fault_isr: da:00d0ef00 translation
>>>> fault
>>>> omap-iommu omap-iommu.0: iommu_fault_handler: da:00d0ef00 pgd:ce664034
>>>> *pgd:00000000
>>>>
>>>> and the select times out.
>>>>
>>>>    From a fresh boot, I can stream just fine from the Resizer and then
>>>> switch to the CCDC output just fine. It is only when I go from the CCDC
>>>> to the Resizer that I get this problem. Furthermore, when it gets into
>>>> this state, then anything dev node I try to use has the translation
>>>> errors and the only way to recover is to reboot.
>>>>
>>>> Any ideas on the problem?
> I'm not sure if it's your case, but OMAP3 ISP driver does not support
> pipeline with multiples outputs yet. We have to return error from the
> driver in this case. If you configured CCDC to write to memory and then
> to write to preview/resizer afterwards without deactivating the link to
> write to memory, you may face a similar problem you described.
>
> Can you please try a patch I've sent to you (CC'ing linux-media) with subject:
> "[omap3isp][PATCH] omap3isp: does not allow pipeline with multiple video
> outputs yet"?
>
> Regards,
>
> David
David,

I am not trying to use multiple outputs simultaneously. I get the 
translation error with the following sequence:

- Open resizer output and setup media links.
- Stream some images.
- Close resizer.
- Reset all media links.
- Open CCDC and setup media links.
- Try to stream some images but get translation faults.

Is your patch going to help with this problem?

Lane

Re: Translation faults with OMAP ISP

[Laurent Pinchart]

Hi Lane,

On Friday 19 November 2010 15:08:38 Lane Brooks wrote:
> On 11/19/2010 06:29 AM, David Cohen wrote:
> > On Thu, Nov 18, 2010 at 12:17:21AM +0100, ext Lane Brooks wrote:
> >> On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
> >>>> Laurent,
> >>>> 
> >>>> I am getting iommu translation errors when I try to use the CCDC
> >>>> output after using the Resizer output.
> >>>> 
> >>>> If I use the CCDC output to stream some video, then close it down,
> >>>> switch to the Resizer output and open it up and try to stream, I get
> >>>> the following errors spewing out:
> >>>> 
> >>>> omap-iommu omap-iommu.0: omap2_iommu_fault_isr: da:00d0ef00
> >>>> translation fault
> >>>> omap-iommu omap-iommu.0: iommu_fault_handler: da:00d0ef00 pgd:ce664034
> >>>> *pgd:00000000
> >>>> 
> >>>> and the select times out.
> >>>> 
> >>>>    From a fresh boot, I can stream just fine from the Resizer and then
> >>>> 
> >>>> switch to the CCDC output just fine. It is only when I go from the
> >>>> CCDC to the Resizer that I get this problem. Furthermore, when it
> >>>> gets into this state, then anything dev node I try to use has the
> >>>> translation errors and the only way to recover is to reboot.
> >>>> 
> >>>> Any ideas on the problem?
> > 
> > I'm not sure if it's your case, but OMAP3 ISP driver does not support
> > pipeline with multiples outputs yet. We have to return error from the
> > driver in this case. If you configured CCDC to write to memory and then
> > to write to preview/resizer afterwards without deactivating the link to
> > write to memory, you may face a similar problem you described.
> > 
> > Can you please try a patch I've sent to you (CC'ing linux-media) with
> > subject: "[omap3isp][PATCH] omap3isp: does not allow pipeline with
> > multiple video outputs yet"?
> > 
> > Regards,
> > 
> > David
> 
> David,
> 
> I am not trying to use multiple outputs simultaneously. I get the
> translation error with the following sequence:
> 
> - Open resizer output and setup media links.
> - Stream some images.
> - Close resizer.
> - Reset all media links.
> - Open CCDC and setup media links.
> - Try to stream some images but get translation faults.
> 
> Is your patch going to help with this problem?

If you reset all links before setting them up for the CCDC output, probably 
not (unless you have a bug in your CCDC links setup, but I doubt that).

-- 
Regards,

Laurent Pinchart

Re: Translation faults with OMAP ISP

[Lane Brooks]

On 11/19/2010 07:13 AM, Laurent Pinchart wrote:
> On Friday 19 November 2010 15:08:38 Lane Brooks wrote:
>> On 11/19/2010 06:29 AM, David Cohen wrote:
>>> On Thu, Nov 18, 2010 at 12:17:21AM +0100, ext Lane Brooks wrote:
>>>> On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
>>>>>> Laurent,
>>>>>>
>>>>>> I am getting iommu translation errors when I try to use the CCDC
>>>>>> output after using the Resizer output.
>>>>>>
>>>>>> If I use the CCDC output to stream some video, then close it down,
>>>>>> switch to the Resizer output and open it up and try to stream, I get
>>>>>> the following errors spewing out:
>>>>>>
>>>>>> omap-iommu omap-iommu.0: omap2_iommu_fault_isr: da:00d0ef00
>>>>>> translation fault
>>>>>> omap-iommu omap-iommu.0: iommu_fault_handler: da:00d0ef00 pgd:ce664034
>>>>>> *pgd:00000000
>>>>>>
>>>>>> and the select times out.
>>>>>>
>>>>>>     From a fresh boot, I can stream just fine from the Resizer and then
>>>>>>
>>>>>> switch to the CCDC output just fine. It is only when I go from the
>>>>>> CCDC to the Resizer that I get this problem. Furthermore, when it
>>>>>> gets into this state, then anything dev node I try to use has the
>>>>>> translation errors and the only way to recover is to reboot.
>>>>>>
>>>>>> Any ideas on the problem?
>>> I'm not sure if it's your case, but OMAP3 ISP driver does not support
>>> pipeline with multiples outputs yet. We have to return error from the
>>> driver in this case. If you configured CCDC to write to memory and then
>>> to write to preview/resizer afterwards without deactivating the link to
>>> write to memory, you may face a similar problem you described.
>>>
>>> Can you please try a patch I've sent to you (CC'ing linux-media) with
>>> subject: "[omap3isp][PATCH] omap3isp: does not allow pipeline with
>>> multiple video outputs yet"?
>>>
>>> Regards,
>>>
>>> David
>> David,
>>
>> I am not trying to use multiple outputs simultaneously. I get the
>> translation error with the following sequence:
>>
>> - Open resizer output and setup media links.
>> - Stream some images.
>> - Close resizer.
>> - Reset all media links.
>> - Open CCDC and setup media links.
>> - Try to stream some images but get translation faults.
>>
>> Is your patch going to help with this problem?
> If you reset all links before setting them up for the CCDC output, probably
> not (unless you have a bug in your CCDC links setup, but I doubt that).
I can stream just fine from the CCDC output if I do not use the resizer 
prior, so I am pretty sure I am setting up the CCDC links correctly.

Re: Translation faults with OMAP ISP

[David Cohen]

On Fri, Nov 19, 2010 at 03:16:41PM +0100, ext Lane Brooks wrote:
> On 11/19/2010 07:13 AM, Laurent Pinchart wrote:
> > On Friday 19 November 2010 15:08:38 Lane Brooks wrote:
> >> On 11/19/2010 06:29 AM, David Cohen wrote:
> >>> On Thu, Nov 18, 2010 at 12:17:21AM +0100, ext Lane Brooks wrote:
> >>>> On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
> >>>>>> Laurent,
> >>>>>>
> >>>>>> I am getting iommu translation errors when I try to use the CCDC
> >>>>>> output after using the Resizer output.
> >>>>>>
> >>>>>> If I use the CCDC output to stream some video, then close it down,
> >>>>>> switch to the Resizer output and open it up and try to stream, I get
> >>>>>> the following errors spewing out:
> >>>>>>
> >>>>>> omap-iommu omap-iommu.0: omap2_iommu_fault_isr: da:00d0ef00
> >>>>>> translation fault
> >>>>>> omap-iommu omap-iommu.0: iommu_fault_handler: da:00d0ef00 pgd:ce664034
> >>>>>> *pgd:00000000
> >>>>>>
> >>>>>> and the select times out.
> >>>>>>
> >>>>>>     From a fresh boot, I can stream just fine from the Resizer and then
> >>>>>>
> >>>>>> switch to the CCDC output just fine. It is only when I go from the
> >>>>>> CCDC to the Resizer that I get this problem. Furthermore, when it
> >>>>>> gets into this state, then anything dev node I try to use has the
> >>>>>> translation errors and the only way to recover is to reboot.
> >>>>>>
> >>>>>> Any ideas on the problem?
> >>> I'm not sure if it's your case, but OMAP3 ISP driver does not support
> >>> pipeline with multiples outputs yet. We have to return error from the
> >>> driver in this case. If you configured CCDC to write to memory and then
> >>> to write to preview/resizer afterwards without deactivating the link to
> >>> write to memory, you may face a similar problem you described.
> >>>
> >>> Can you please try a patch I've sent to you (CC'ing linux-media) with
> >>> subject: "[omap3isp][PATCH] omap3isp: does not allow pipeline with
> >>> multiple video outputs yet"?
> >>>
> >>> Regards,
> >>>
> >>> David
> >> David,
> >>
> >> I am not trying to use multiple outputs simultaneously. I get the
> >> translation error with the following sequence:
> >>
> >> - Open resizer output and setup media links.
> >> - Stream some images.
> >> - Close resizer.
> >> - Reset all media links.
> >> - Open CCDC and setup media links.
> >> - Try to stream some images but get translation faults.

You're describing some different steps from your previous e-mail, as
here the iommu faults come while CCDC outputting to memory and in your
comment above it was happening while Resizer outputting to memory.

Which one should I consider as the correct? :)

It would be nice if you could print the values of CCDC_SDR_ADDR and
RSZ_SDR_OUTADD just before the bug.

Are you also enabling CCDC's LSC?

> >>
> >> Is your patch going to help with this problem?
> > If you reset all links before setting them up for the CCDC output, probably
> > not (unless you have a bug in your CCDC links setup, but I doubt that).

As Laurent said, probably not. But if you want to go ahead to test this
patch, that's fine. It's very unlikely we have a bug on CCDC or Resizer
link setup, but not completely impossible. :)
A new version of this patch fixing the typo I mentioned there is going to be
locally applied anyway.

> I can stream just fine from the CCDC output if I do not use the resizer 
> prior, so I am pretty sure I am setting up the CCDC links correctly.

Well, iommu faults mean bug on kernel side. If you're still doing
something wrong, the driver must be able to return and error to
userland.

Regards,

David

> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Translation faults with OMAP ISP

[Laurent Pinchart]

Hi David,

On Friday 19 November 2010 16:06:21 David Cohen wrote:
> On Fri, Nov 19, 2010 at 03:16:41PM +0100, ext Lane Brooks wrote:
> > On 11/19/2010 07:13 AM, Laurent Pinchart wrote:
> > > On Friday 19 November 2010 15:08:38 Lane Brooks wrote:
> > >> On 11/19/2010 06:29 AM, David Cohen wrote:
> > >>> On Thu, Nov 18, 2010 at 12:17:21AM +0100, ext Lane Brooks wrote:
> > >>>> On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
> > >>>>>> Laurent,
> > >>>>>> 
> > >>>>>> I am getting iommu translation errors when I try to use the CCDC
> > >>>>>> output after using the Resizer output.
> > >>>>>> 
> > >>>>>> If I use the CCDC output to stream some video, then close it down,
> > >>>>>> switch to the Resizer output and open it up and try to stream, I
> > >>>>>> get the following errors spewing out:
> > >>>>>> 
> > >>>>>> omap-iommu omap-iommu.0: omap2_iommu_fault_isr: da:00d0ef00
> > >>>>>> translation fault
> > >>>>>> omap-iommu omap-iommu.0: iommu_fault_handler: da:00d0ef00
> > >>>>>> pgd:ce664034 *pgd:00000000
> > >>>>>> 
> > >>>>>> and the select times out.
> > >>>>>> 
> > >>>>>>     From a fresh boot, I can stream just fine from the Resizer and
> > >>>>>>     then
> > >>>>>> 
> > >>>>>> switch to the CCDC output just fine. It is only when I go from the
> > >>>>>> CCDC to the Resizer that I get this problem. Furthermore, when it
> > >>>>>> gets into this state, then anything dev node I try to use has the
> > >>>>>> translation errors and the only way to recover is to reboot.
> > >>>>>> 
> > >>>>>> Any ideas on the problem?
> > >>> 
> > >>> I'm not sure if it's your case, but OMAP3 ISP driver does not support
> > >>> pipeline with multiples outputs yet. We have to return error from the
> > >>> driver in this case. If you configured CCDC to write to memory and
> > >>> then to write to preview/resizer afterwards without deactivating the
> > >>> link to write to memory, you may face a similar problem you
> > >>> described.
> > >>> 
> > >>> Can you please try a patch I've sent to you (CC'ing linux-media) with
> > >>> subject: "[omap3isp][PATCH] omap3isp: does not allow pipeline with
> > >>> multiple video outputs yet"?
> > >>> 
> > >>> Regards,
> > >>> 
> > >>> David
> > >> 
> > >> David,
> > >> 
> > >> I am not trying to use multiple outputs simultaneously. I get the
> > >> translation error with the following sequence:
> > >> 
> > >> - Open resizer output and setup media links.
> > >> - Stream some images.
> > >> - Close resizer.
> > >> - Reset all media links.
> > >> - Open CCDC and setup media links.
> > >> - Try to stream some images but get translation faults.
> 
> You're describing some different steps from your previous e-mail, as
> here the iommu faults come while CCDC outputting to memory and in your
> comment above it was happening while Resizer outputting to memory.
> 
> Which one should I consider as the correct? :)
> 
> It would be nice if you could print the values of CCDC_SDR_ADDR and
> RSZ_SDR_OUTADD just before the bug.
> 
> Are you also enabling CCDC's LSC?
> 
> > >> Is your patch going to help with this problem?
> > > 
> > > If you reset all links before setting them up for the CCDC output,
> > > probably not (unless you have a bug in your CCDC links setup, but I
> > > doubt that).
> 
> As Laurent said, probably not. But if you want to go ahead to test this
> patch, that's fine. It's very unlikely we have a bug on CCDC or Resizer
> link setup, but not completely impossible. :)
> A new version of this patch fixing the typo I mentioned there is going to
> be locally applied anyway.
> 
> > I can stream just fine from the CCDC output if I do not use the resizer
> > prior, so I am pretty sure I am setting up the CCDC links correctly.
> 
> Well, iommu faults mean bug on kernel side. If you're still doing
> something wrong, the driver must be able to return and error to
> userland.

Don't forget that Lane is using an older version of the OMAP3 ISP driver. The 
bug might have been fixed in the latest code.

-- 
Regards,

Laurent Pinchart

Re: Translation faults with OMAP ISP

[David Cohen]

On Fri, Nov 19, 2010 at 04:07:27PM +0100, ext Laurent Pinchart wrote:
> Hi David,
> 
> On Friday 19 November 2010 16:06:21 David Cohen wrote:
> > On Fri, Nov 19, 2010 at 03:16:41PM +0100, ext Lane Brooks wrote:
> > > On 11/19/2010 07:13 AM, Laurent Pinchart wrote:
> > > > On Friday 19 November 2010 15:08:38 Lane Brooks wrote:
> > > >> On 11/19/2010 06:29 AM, David Cohen wrote:
> > > >>> On Thu, Nov 18, 2010 at 12:17:21AM +0100, ext Lane Brooks wrote:
> > > >>>> On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote:
> > > >>>>>> Laurent,
> > > >>>>>> 
> > > >>>>>> I am getting iommu translation errors when I try to use the CCDC
> > > >>>>>> output after using the Resizer output.
> > > >>>>>> 
> > > >>>>>> If I use the CCDC output to stream some video, then close it down,
> > > >>>>>> switch to the Resizer output and open it up and try to stream, I
> > > >>>>>> get the following errors spewing out:
> > > >>>>>> 
> > > >>>>>> omap-iommu omap-iommu.0: omap2_iommu_fault_isr: da:00d0ef00
> > > >>>>>> translation fault
> > > >>>>>> omap-iommu omap-iommu.0: iommu_fault_handler: da:00d0ef00
> > > >>>>>> pgd:ce664034 *pgd:00000000
> > > >>>>>> 
> > > >>>>>> and the select times out.
> > > >>>>>> 
> > > >>>>>>     From a fresh boot, I can stream just fine from the Resizer and
> > > >>>>>>     then
> > > >>>>>> 
> > > >>>>>> switch to the CCDC output just fine. It is only when I go from the
> > > >>>>>> CCDC to the Resizer that I get this problem. Furthermore, when it
> > > >>>>>> gets into this state, then anything dev node I try to use has the
> > > >>>>>> translation errors and the only way to recover is to reboot.
> > > >>>>>> 
> > > >>>>>> Any ideas on the problem?
> > > >>> 
> > > >>> I'm not sure if it's your case, but OMAP3 ISP driver does not support
> > > >>> pipeline with multiples outputs yet. We have to return error from the
> > > >>> driver in this case. If you configured CCDC to write to memory and
> > > >>> then to write to preview/resizer afterwards without deactivating the
> > > >>> link to write to memory, you may face a similar problem you
> > > >>> described.
> > > >>> 
> > > >>> Can you please try a patch I've sent to you (CC'ing linux-media) with
> > > >>> subject: "[omap3isp][PATCH] omap3isp: does not allow pipeline with
> > > >>> multiple video outputs yet"?
> > > >>> 
> > > >>> Regards,
> > > >>> 
> > > >>> David
> > > >> 
> > > >> David,
> > > >> 
> > > >> I am not trying to use multiple outputs simultaneously. I get the
> > > >> translation error with the following sequence:
> > > >> 
> > > >> - Open resizer output and setup media links.
> > > >> - Stream some images.
> > > >> - Close resizer.
> > > >> - Reset all media links.
> > > >> - Open CCDC and setup media links.
> > > >> - Try to stream some images but get translation faults.
> > 
> > You're describing some different steps from your previous e-mail, as
> > here the iommu faults come while CCDC outputting to memory and in your
> > comment above it was happening while Resizer outputting to memory.
> > 
> > Which one should I consider as the correct? :)
> > 
> > It would be nice if you could print the values of CCDC_SDR_ADDR and
> > RSZ_SDR_OUTADD just before the bug.
> > 
> > Are you also enabling CCDC's LSC?
> > 
> > > >> Is your patch going to help with this problem?
> > > > 
> > > > If you reset all links before setting them up for the CCDC output,
> > > > probably not (unless you have a bug in your CCDC links setup, but I
> > > > doubt that).
> > 
> > As Laurent said, probably not. But if you want to go ahead to test this
> > patch, that's fine. It's very unlikely we have a bug on CCDC or Resizer
> > link setup, but not completely impossible. :)
> > A new version of this patch fixing the typo I mentioned there is going to
> > be locally applied anyway.
> > 
> > > I can stream just fine from the CCDC output if I do not use the resizer
> > > prior, so I am pretty sure I am setting up the CCDC links correctly.
> > 
> > Well, iommu faults mean bug on kernel side. If you're still doing
> > something wrong, the driver must be able to return and error to
> > userland.
> 
> Don't forget that Lane is using an older version of the OMAP3 ISP driver. The 
> bug might have been fixed in the latest code.

Hm. We did fix some iommu faults.
Maybe it's better to test a newer version instead.
If you still see that bug using an up-to-date version, please report it
and I can try to help you. :)

Regards,

David

> 
> -- 
> Regards,
> 
> Laurent Pinchart

[omap3isp] Prefered patch base for latest code? (was: "RE: Translation faults with OMAP ISP")

[Aguirre, Sergio]

Hi David and Laurent,

<snip>

> >
> > Don't forget that Lane is using an older version of the OMAP3 ISP
> driver. The
> > bug might have been fixed in the latest code.
> 
> Hm. We did fix some iommu faults.
> Maybe it's better to test a newer version instead.
> If you still see that bug using an up-to-date version, please report it
> and I can try to help you. :)

How close is this tree from the latest internal version you guys work with?

http://meego.gitorious.com/maemo-multimedia/omap3isp-rx51/commits/devel

I have been basing my patches on top of this tree:

http://git.linuxtv.org/pinchartl/media.git?h=refs/heads/media-0004-omap3isp

Would it be better to be based on the gitorious tree instead?

What do you think?

Regards,
Sergio

> 
> Regards,
> 
> David
> 
> >
> > --
> > Regards,
> >
> > Laurent Pinchart
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [omap3isp] Prefered patch base for latest code? (was: "RE: Translation faults with OMAP ISP")

[Laurent Pinchart]

Hi Sergio,

On Friday 19 November 2010 17:07:09 Aguirre, Sergio wrote:
> Hi David and Laurent,
> 
> <snip>
> 
> > > Don't forget that Lane is using an older version of the OMAP3 ISP
> > > driver. The bug might have been fixed in the latest code.
> > 
> > Hm. We did fix some iommu faults.
> > Maybe it's better to test a newer version instead.
> > If you still see that bug using an up-to-date version, please report it
> > and I can try to help you. :)
> 
> How close is this tree from the latest internal version you guys work with?
> 
> http://meego.gitorious.com/maemo-multimedia/omap3isp-rx51/commits/devel

There's less differences between gitorious and our internal tree than between 
linuxtv and our internal tree.

> I have been basing my patches on top of this tree:
> 
> http://git.linuxtv.org/pinchartl/media.git?h=refs/heads/media-0004-omap3isp
> 
> Would it be better to be based on the gitorious tree instead?
> 
> What do you think?

I will push a big patch that ports all the changes made to the MC and V4L2 
core, as well as omap3-isp driver, during public review to our internal tree 
early next week (should be on Monday). The trees will then get in sync. The 
gitorious tree will be updated as well.

Unless you want your patches to be applied before Monday, which won't happen 
anyway, please base them on the linuxtv tree :-)

-- 
Regards,

Laurent Pinchart

RE: [omap3isp] Prefered patch base for latest code? (was: "RE: Translation faults with OMAP ISP")

[Aguirre, Sergio]

Hi Laurent,

> -----Original Message-----
> From: Laurent Pinchart [mailto:laurent.pinchart@ideasonboard.com]
> Sent: Friday, November 19, 2010 10:16 AM
> To: Aguirre, Sergio
> Cc: David Cohen; ext Lane Brooks; linux-media@vger.kernel.org
> Subject: Re: [omap3isp] Prefered patch base for latest code? (was: "RE:
> Translation faults with OMAP ISP")
> 
> Hi Sergio,
> 
> On Friday 19 November 2010 17:07:09 Aguirre, Sergio wrote:
> > Hi David and Laurent,
> >
> > <snip>
> >
> > > > Don't forget that Lane is using an older version of the OMAP3 ISP
> > > > driver. The bug might have been fixed in the latest code.
> > >
> > > Hm. We did fix some iommu faults.
> > > Maybe it's better to test a newer version instead.
> > > If you still see that bug using an up-to-date version, please report
> it
> > > and I can try to help you. :)
> >
> > How close is this tree from the latest internal version you guys work
> with?
> >
> > http://meego.gitorious.com/maemo-multimedia/omap3isp-rx51/commits/devel
> 
> There's less differences between gitorious and our internal tree than
> between
> linuxtv and our internal tree.

Ok, I guess I can treat above tree as an "omap3isp-next" tree then, to have
a sneak preview of what's coming ;)

> 
> > I have been basing my patches on top of this tree:
> >
> > http://git.linuxtv.org/pinchartl/media.git?h=refs/heads/media-0004-
> omap3isp
> >
> > Would it be better to be based on the gitorious tree instead?
> >
> > What do you think?
> 
> I will push a big patch that ports all the changes made to the MC and V4L2
> core, as well as omap3-isp driver, during public review to our internal
> tree
> early next week (should be on Monday). The trees will then get in sync.
> The
> gitorious tree will be updated as well.
> 
> Unless you want your patches to be applied before Monday, which won't
> happen
> anyway, please base them on the linuxtv tree :-)

Ok, sure. It's better for me, since the gitorious devel tree includes rx51
support which I don't even have a device to try it out :P

I'll continue to be based on media-0004-omap3isp branch then, and just watch
devel branch to know if I'm not doing something conflicting.

Regards,
Sergio
> 
> --
> Regards,
> 
> Laurent Pinchart

Re: [omap3isp] Prefered patch base for latest code? (was: "RE: Translation faults with OMAP ISP")

[Laurent Pinchart]

Hi Sergio,

On Friday 19 November 2010 17:23:45 Aguirre, Sergio wrote:
> On Friday, November 19, 2010 10:16 AM Aguirre, Sergio wrote:
> > On Friday 19 November 2010 17:07:09 Aguirre, Sergio wrote:

[snip]

> > > How close is this tree from the latest internal version you guys work
> > > with?
> > >
> > > http://meego.gitorious.com/maemo-multimedia/omap3isp-rx51/commits/devel
> > 
> > There's less differences between gitorious and our internal tree than
> > between linuxtv and our internal tree.
> 
> Ok, I guess I can treat above tree as an "omap3isp-next" tree then, to have
> a sneak preview of what's coming ;)

I haven't expressed myself clearly enough. The gitorious tree is currently 
more in sync with our internal tree that the linuxtv is for a simple reason: 
both our internal tree and the gitorious tree are missing modifications made 
during the public review process.

Patches published from our internal tree are always pushed to linuxtv and 
gitorious at the same time (or mostly). Please don't use the gitorious tree 
for anything else than trying the driver on the N900.

-- 
Regards,

Laurent Pinchart

RE: [omap3isp] Prefered patch base for latest code? (was: "RE: Translation faults with OMAP ISP")

[Aguirre, Sergio]

Hi Laurent,

> -----Original Message-----
> From: linux-media-owner@vger.kernel.org [mailto:linux-media-
> owner@vger.kernel.org] On Behalf Of Laurent Pinchart
> Sent: Friday, November 19, 2010 10:32 AM
> To: Aguirre, Sergio
> Cc: David Cohen; ext Lane Brooks; linux-media@vger.kernel.org
> Subject: Re: [omap3isp] Prefered patch base for latest code? (was: "RE:
> Translation faults with OMAP ISP")
> 
> Hi Sergio,
> 
> On Friday 19 November 2010 17:23:45 Aguirre, Sergio wrote:
> > On Friday, November 19, 2010 10:16 AM Aguirre, Sergio wrote:
> > > On Friday 19 November 2010 17:07:09 Aguirre, Sergio wrote:
> 
> [snip]
> 
> > > > How close is this tree from the latest internal version you guys
> work
> > > > with?
> > > >
> > > > http://meego.gitorious.com/maemo-multimedia/omap3isp-
> rx51/commits/devel
> > >
> > > There's less differences between gitorious and our internal tree than
> > > between linuxtv and our internal tree.
> >
> > Ok, I guess I can treat above tree as an "omap3isp-next" tree then, to
> have
> > a sneak preview of what's coming ;)
> 
> I haven't expressed myself clearly enough. The gitorious tree is currently
> more in sync with our internal tree that the linuxtv is for a simple
> reason:
> both our internal tree and the gitorious tree are missing modifications
> made
> during the public review process.

Ok. Sorry, I think I didn't quite understood that.

> 
> Patches published from our internal tree are always pushed to linuxtv and
> gitorious at the same time (or mostly). Please don't use the gitorious
> tree
> for anything else than trying the driver on the N900.

I see. So I probably won't worry about this tree at all, since I don't have an N900.

I'm trying this in my Zoom board w/OMAP3630, and I have a Beagleboard xM handy aswell (OMAP3730), so In my tree I'll try to keep support for both of
These.

Also, I'm working on trying to bring this in a very different chip, but that's a secret ;) That's why I'm working in doing cleanups.

Regards,
Sergio

> 
> --
> Regards,
> 
> Laurent Pinchart
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html