From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Dan Carpenter <error27@gmail.com>
Cc: Sergej Pupykin <pupykin.s@gmail.com>, linux-media@vger.kernel.org
Subject: Re: [patch v2] [media] bttv: take correct lock in bttv_open()
Date: Tue, 14 Dec 2010 10:33:41 -0200 [thread overview]
Message-ID: <4D076425.9050602@infradead.org> (raw)
In-Reply-To: <20101214103658.GL1620@bicker>
Em 14-12-2010 08:36, Dan Carpenter escreveu:
> On Mon, Dec 13, 2010 at 01:42:49AM +0300, Sergej Pupykin wrote:
>> mutex_lock(&btv->lock);
>> *fh = btv->init;
>> mutex_unlock(&btv->lock);
>>
>> Probably it is overkill and may be incorrect, but it starts working.
>>
>
> Mauro would be the one to know for sure.
>
>> Also I found another issue: tvtime hangs on exit in D-state, so it
>> looks like there is a problem near bttv_release function or
>> something like this.
>
> Speaking of other bugs in this driver, I submitted a another fix
> that hasn't been merged yet. I've attached it. Don't know if it's
> related at all to the other bug you noticed but it can't hurt.
I'm preparing one machine in order to test bttv and try to fix the
locking issues. Hopefully, I'll have something today.
Cheers,
Mauro
prev parent reply other threads:[~2010-12-14 12:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20101210033304.GX10623@bicker>
[not found] ` <4D01D4BE.1080000@gmail.com>
2010-12-12 16:58 ` [patch v2] [media] bttv: take correct lock in bttv_open() Dan Carpenter
2010-12-12 22:42 ` Sergej Pupykin
2010-12-14 10:36 ` Dan Carpenter
2010-12-14 12:33 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D076425.9050602@infradead.org \
--to=mchehab@infradead.org \
--cc=error27@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=pupykin.s@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox